Re: [igt-dev] [PATCH i-g-t 3/5] tests/i915/kms_frontbuffer_tracking: all gem ioctls are not supported for xe as of now

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

Hi Kunal,

On Fri-09-06-2023 03:42 pm, Kunal Joshi wrote:
> XE doesn't support all gem ioctls
> Open :- Find replacement for igt_require_gem() for xe
> 
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>   tests/i915/kms_frontbuffer_tracking.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
> index 45a601fe..09bfd3c3 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -3701,7 +3701,8 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>   	t.flip = FLIP_PAGEFLIP;
>   	t.tiling = opt.tiling;
>   	igt_subtest("basic") {
> -		igt_require_gem(drm.fd);
> +		if (!is_xe_device(drm.fd))
> +			igt_require_gem(drm.fd);
>   		basic_subtest(&t);

Patch LGTM
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

Please address below comments:
Due to the igt_fixture in Patch 5/5 of this series, "basic" test is 
getting skip [1]

Maybe you can re-arrange the tests to handle this.
Hint: subtest "basic" should be the first one in kms_frontbuffer_tracking.c

[1]: 
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9141/bat-dg2-8/igt@kms_frontbuffer_tracking@basic.html

- Bhanu

>   	}
>