Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Pranay Samala <pranay.samala@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <sameer.lattannavar@intel.com>
Subject: Re: [PATCH i-g-t v2] tests/kms_getfb: Skip getfb2-accept-ccs subtest on Xe2 platforms
Date: Fri, 12 Jul 2024 10:22:30 +0530	[thread overview]
Message-ID: <586ecd9f-0010-4c0a-927d-082b4b149017@intel.com> (raw)
In-Reply-To: <20240705044515.700219-1-pranay.samala@intel.com>


On 7/5/2024 10:15 AM, Pranay Samala wrote:
> The getfb2-accept-ccs subtest tests on ccs modifiers.
> With Xe2 platforms we no more have the ccs modifiers.
>
> Adding a check to verify the platform. If it is
> Xe2 platform then test will skip, otherwise it
> will execute further.
>
> v2: modified the check as
>      intel_graphics_ver(devid) < IP_VER(20, 0) (Juha-pekka)
>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_getfb.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> index bb9679bc9..9cc783776 100644
> --- a/tests/kms_getfb.c
> +++ b/tests/kms_getfb.c
> @@ -161,6 +161,9 @@ static void get_ccs_fb(int fd, struct drm_mode_fb_cmd2 *ret)
>   	igt_require(has_addfb2_iface(fd));
>   	devid = intel_get_drm_devid(fd);
>   
> +	igt_require_f(intel_graphics_ver(devid) < IP_VER(20, 0),
> +		      "No ccs modifiers on Xe2\n");
> +
>   	if (HAS_FLATCCS(devid)) {
>   		add.modifier[0] = I915_FORMAT_MOD_4_TILED_DG2_RC_CCS;
>   		add.pitches[0] = ALIGN(add.width * 4, 4 * 512);

  parent reply	other threads:[~2024-07-12  4:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  4:45 [PATCH i-g-t v2] tests/kms_getfb: Skip getfb2-accept-ccs subtest on Xe2 platforms Pranay Samala
2024-07-05  5:39 ` ✓ CI.xeBAT: success for tests/kms_getfb: Skip getfb2-accept-ccs subtest on Xe2 platforms (rev3) Patchwork
2024-07-05  5:46 ` ✓ Fi.CI.BAT: " Patchwork
2024-07-05  6:57 ` ✓ CI.xeFULL: " Patchwork
2024-07-05 19:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-17  8:26   ` Samala, Pranay
2024-07-12  4:52 ` Karthik B S [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-06-26  9:59 [PATCH i-g-t v2] tests/kms_getfb: Skip getfb2-accept-ccs subtest on Xe2 platforms Pranay Samala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=586ecd9f-0010-4c0a-927d-082b4b149017@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=pranay.samala@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox