Re: [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi Jeevan,


On 3/25/2026 10:21 PM, Jeevan B wrote:
> Use output instead of NULL in PSR helpers so PSR is disabled only
> when supported by the sink, avoiding unnecessary global checks and
> ensuring correct behavior on multi-eDP setups.
>
> Signed-off-by: Jeevan B<jeevan.b@intel.com>
> ---
>   tests/kms_vrr.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
> index ec0692b2f..ec17366c8 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -912,9 +912,9 @@ test_lobf(data_t *data, igt_crtc_t *crtc, igt_output_t *output,
>   			igt_skip("%s: Aux-less ALPM not enabled, LOBF not supported.\n",
>   				 igt_output_name(output));
>   
> -		if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
> -		    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))
> -			psr_disable(data->drm_fd, data->debugfs_fd, NULL);
> +		if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, output) ||
> +		    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, output))
> +			psr_disable(data->drm_fd, data->debugfs_fd, output);
>   	}
This patch updates the debugfs, and that part looks good to me. However, 
I noticed one issue: according to the current PSR check logic, it only 
checks for panel replay and PSR1 mode. If PSR2 is enabled, the test will 
be skipped because LOBF and PSR2 are mutually exclusive. It would be 
better to fix this either in a separate patch or as part of this patch.

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com> 
<mailto:ramanaidu.naladala@intel.com>



>   
>   	igt_info("LOBF test execution on %s, PIPE %s with VRR range: (%u-%u) Hz\n",

[-- Attachment #2: Type: text/html, Size: 38267 bytes --]