public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 0/4] Fix PSR handling for multi-eDP systems
@ 2026-03-25 16:51 Jeevan B
  2026-03-25 16:51 ` [PATCH i-g-t v2 1/4] tests/intel/kms_fbc_dirty_rect: Use per-output PSR check before disabling Jeevan B
                   ` (7 more replies)
  0 siblings, 8 replies; 13+ messages in thread
From: Jeevan B @ 2026-03-25 16:51 UTC (permalink / raw)
  To: igt-dev; +Cc: pranay.samala, Jeevan B

PSR handling in a few tests currently relies on global checks by
passing NULL to PSR helper functions. This works on single eDP
systems, but breaks on platforms with multiple eDP panels where PSR
capability can differ per output.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Jeevan B (4):
  tests/intel/kms_fbc_dirty_rect: Use per-output PSR check before
    disabling
  tests/kms_vrr: Avoid unnecessary PSR disable
  tests/intel/kms_psr_stress_test: Select PSR-capable output
  tests/intel/kms_pm_dc: Scope PSR handling to output

 tests/intel/kms_fbc_dirty_rect.c  | 14 +++++++++-----
 tests/intel/kms_pm_dc.c           | 26 ++++++++++++++------------
 tests/intel/kms_psr_stress_test.c | 14 +++++++-------
 tests/kms_vrr.c                   |  6 +++---
 4 files changed, 33 insertions(+), 27 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 13+ messages in thread
* RE: [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable
@ 2026-04-01  4:46 Naladala, Ramanaidu
  0 siblings, 0 replies; 13+ messages in thread
From: Naladala, Ramanaidu @ 2026-04-01  4:46 UTC (permalink / raw)
  To: jeevan.b, igt-dev, pranay.samala

[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]

Hi Jeevan,

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Jeevan B
Sent: Wednesday, March 25, 2026 10:22 PM
To: igt-dev@lists.freedesktop.org
Cc: Samala, Pranay <pranay.samala@intel.com>; B, Jeevan <jeevan.b@intel.com>
Subject: [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable

Use output instead of NULL in PSR helpers so PSR is disabled only when 
supported by the sink, avoiding unnecessary global checks and ensuring 
correct behavior on multi-eDP setups.

Signed-off-by: Jeevan B <jeevan.b@intel.com <mailto:jeevan.b@intel.com>>

---

tests/kms_vrr.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 
ec0692b2f..ec17366c8 100644

--- a/tests/kms_vrr.c

+++ b/tests/kms_vrr.c

@@ -912,9 +912,9 @@ test_lobf(data_t *data, igt_crtc_t *crtc, 
igt_output_t *output,

igt_skip("%s: Aux-less ALPM not enabled, LOBF not supported.\n",

igt_output_name(output));

-if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||

-psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))

-psr_disable(data->drm_fd, data->debugfs_fd, NULL);

+if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, output) ||

+psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, output))

+psr_disable(data->drm_fd, data->debugfs_fd, output);

}

This patch is to update the debugfs. on that part it is LGTM. But 
observed one issue, As per the above psr check logic it is only checking 
panel replay and psr1 mode. If psr2 is enabled test will skip due to 
lobf and psr2 are mutually exclusive. Better this needs to be fix in 
other patch or this patch.

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>

igt_info("LOBF test execution on %s, PIPE %s with VRR range: (%u-%u) Hz\n",

--

2.43.0


[-- Attachment #2: Type: text/html, Size: 7712 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-04-01 12:31 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-25 16:51 [PATCH i-g-t v2 0/4] Fix PSR handling for multi-eDP systems Jeevan B
2026-03-25 16:51 ` [PATCH i-g-t v2 1/4] tests/intel/kms_fbc_dirty_rect: Use per-output PSR check before disabling Jeevan B
2026-03-26  8:40   ` Samala, Pranay
2026-03-25 16:51 ` [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable Jeevan B
2026-04-01 12:30   ` Naladala, Ramanaidu
2026-03-25 16:51 ` [PATCH i-g-t v2 3/4] tests/intel/kms_psr_stress_test: Select PSR-capable output Jeevan B
2026-03-26  8:44   ` Samala, Pranay
2026-03-25 16:51 ` [PATCH i-g-t v2 4/4] tests/intel/kms_pm_dc: Scope PSR handling to output Jeevan B
2026-03-26  3:45 ` ✓ i915.CI.BAT: success for Fix PSR handling for multi-eDP systems (rev3) Patchwork
2026-03-26  3:48 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-26 16:10 ` ✓ Xe.CI.FULL: " Patchwork
2026-03-26 18:49 ` ✗ i915.CI.Full: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-04-01  4:46 [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable Naladala, Ramanaidu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox