From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 31FC36E8E0
 for <igt-dev@lists.freedesktop.org>; Fri, 29 Mar 2019 12:22:49 +0000 (UTC)
References: <20190328192206.1591-1-andi.shyti@intel.com>
 <20190328192206.1591-7-andi.shyti@intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Message-ID: <5962ecab-4406-96a1-c279-0efba329356e@linux.intel.com>
Date: Fri, 29 Mar 2019 12:22:46 +0000
MIME-Version: 1.0
In-Reply-To: <20190328192206.1591-7-andi.shyti@intel.com>
Content-Language: en-US
Subject: Re: [igt-dev] [PATCH v16 6/8] lib: igt_gt: make
 gem_engine_can_store_dword() check engine class
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Andi Shyti <andi.shyti@intel.com>, IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
List-ID: <igt-dev@lists.freedesktop.org>

Ck9uIDI4LzAzLzIwMTkgMTk6MjIsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gRW5naW5lcyByZWZlcnJl
ZCBieSBjbGFzcyBhbmQgaW5zdGFuY2UgYXJlIGdldHRpbmcgbW9yZSBwb3B1bGFyZSwKCkl0YWxp
YW4gdHlwby4gOykKCj4gZ2VtX2VuZ2luZV9jYW5fc3RvcmVfZHdvcmQoKSBzaG91bGQgaGFuZGxl
IHRoZSBzaXR1YXRpb24uCj4gCj4gU2lnbmVkLW9mZi1ieTogQW5kaSBTaHl0aSA8YW5kaS5zaHl0
aUBpbnRlbC5jb20+Cj4gLS0tCj4gICBsaWIvaWd0X2d0LmMgfCA0NiArKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gICBsaWIvaWd0X2d0LmggfCAgNiArKysr
LS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkK
PiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9ndC5jIGIvbGliL2lndF9ndC5jCj4gaW5kZXggNTk5
OTUyNDMyNmQwLi42MzBhYTQyMWZmYjMgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9ndC5jCj4gKysr
IGIvbGliL2lndF9ndC5jCj4gQEAgLTQxLDYgKzQxLDcgQEAKPiAgICNpbmNsdWRlICJpbnRlbF9y
ZWcuaCIKPiAgICNpbmNsdWRlICJpbnRlbF9jaGlwc2V0LmgiCj4gICAjaW5jbHVkZSAiaWd0X2R1
bW15bG9hZC5oIgo+ICsjaW5jbHVkZSAiaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmgiCj4gICAK
PiAgIC8qKgo+ICAgICogU0VDVElPTjppZ3RfZ3QKPiBAQCAtNTU2LDI3ICs1NTcsNTggQEAgY29u
c3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXNb
XSA9IHsKPiAgIAl7IE5VTEwsIDAsIDAgfQo+ICAgfTsKPiAgIAo+IC1ib29sIGdlbV9jYW5fc3Rv
cmVfZHdvcmQoaW50IGZkLCB1bnNpZ25lZCBpbnQgZW5naW5lKQo+ICtzdGF0aWMgYm9vbCBfX2dl
bV9jYW5fc3RvcmVfZHdvcmQoY29uc3QgaW50IGdlbiwgY29uc3Qgc3RydWN0IGludGVsX2Rldmlj
ZV9pbmZvICppbmZvKQo+ICAgewo+IC0JdWludDE2X3QgZGV2aWQgPSBpbnRlbF9nZXRfZHJtX2Rl
dmlkKGZkKTsKPiAtCWNvbnN0IHN0cnVjdCBpbnRlbF9kZXZpY2VfaW5mbyAqaW5mbyA9IGludGVs
X2dldF9kZXZpY2VfaW5mbyhkZXZpZCk7Cj4gLQljb25zdCBpbnQgZ2VuID0gZmZzKGluZm8tPmdl
bik7Cj4gLQo+ICAgCWlmIChnZW4gPD0gMikgLyogcmVxdWlyZXMgcGh5c2ljYWwgYWRkcmVzc2Vz
ICovCj4gICAJCXJldHVybiBmYWxzZTsKPiAgIAo+ICAgCWlmIChnZW4gPT0gMyAmJiAoaW5mby0+
aXNfZ3JhbnRzZGFsZSB8fCBpbmZvLT5pc19hbHZpc28pKQo+ICAgCQlyZXR1cm4gZmFsc2U7IC8q
IG9ubHkgc3VwcG9ydHMgcGh5c2ljYWwgYWRkcmVzc2VzICovCj4gICAKPiArCWlmIChpbmZvLT5p
c19icm9hZHdhdGVyKQo+ICsJCXJldHVybiBmYWxzZTsgLyogTm90IHN1cmUgeWV0Li4uICovCj4g
Kwo+ICsJcmV0dXJuIHRydWU7Cj4gK30KPiArCj4gK2Jvb2wgZ2VtX2Nhbl9zdG9yZV9kd29yZChp
bnQgZmQsIHVpbnQ2NF90IGVuZ2luZSkKClllYWggZWItPmZsYWdzIGlzIHU2NCwgYWx0aG91Z2gg
d2UgZG9uJ3QgbmVlZCBpdCBhbGwgaGVyZS4gT2theSwgSSBkb24ndCBtaW5kLgoKPiArewo+ICsJ
dWludDE2X3QgZGV2aWQgPSBpbnRlbF9nZXRfZHJtX2RldmlkKGZkKTsKPiArCWNvbnN0IHN0cnVj
dCBpbnRlbF9kZXZpY2VfaW5mbyAqaW5mbyA9IGludGVsX2dldF9kZXZpY2VfaW5mbyhkZXZpZCk7
Cj4gKwljb25zdCBpbnQgZ2VuID0gZmZzKGluZm8tPmdlbik7Cj4gKwo+ICsJaWYgKCFfX2dlbV9j
YW5fc3RvcmVfZHdvcmQoZ2VuLCBpbmZvKSkKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICAgCWlm
IChnZW4gPT0gNiAmJiAoKGVuZ2luZSAmIDB4M2YpID09IEk5MTVfRVhFQ19CU0QpKQo+ICAgCQly
ZXR1cm4gZmFsc2U7IC8qIGtpbGxzIHRoZSBtYWNoaW5lISAqLwo+ICAgCj4gLQlpZiAoaW5mby0+
aXNfYnJvYWR3YXRlcikKPiAtCQlyZXR1cm4gZmFsc2U7IC8qIE5vdCBzdXJlIHlldC4uLiAqLwo+
ICsJcmV0dXJuIHRydWU7Cj4gK30KPiArCj4gK2Jvb2wgZ2VtX2NsYXNzX2Nhbl9zdG9yZV9kd29y
ZChpbnQgZmQsIHVpbnQ2NF90IGNsYXNzKQoKQnV0IGZvciBjbGFzcyB3ZSBkZWZpbml0ZWx5IGRv
IG5vdCBuZWVkIDY0IGJpdHMuIHUxNiBvciB1bnNpZ25lZCBpbnQuCgo+ICt7Cj4gKwl1aW50MTZf
dCBkZXZpZCA9IGludGVsX2dldF9kcm1fZGV2aWQoZmQpOwo+ICsJY29uc3Qgc3RydWN0IGludGVs
X2RldmljZV9pbmZvICppbmZvID0gaW50ZWxfZ2V0X2RldmljZV9pbmZvKGRldmlkKTsKPiArCWNv
bnN0IGludCBnZW4gPSBmZnMoaW5mby0+Z2VuKTsKPiArCj4gKwlpZiAoIV9fZ2VtX2Nhbl9zdG9y
ZV9kd29yZChnZW4sIGluZm8pKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAoZ2VuID09
IDYgJiYgY2xhc3MgPT0gSTkxNV9FTkdJTkVfQ0xBU1NfVklERU8pCj4gKwkJcmV0dXJuIGZhbHNl
Owo+ICAgCj4gICAJcmV0dXJuIHRydWU7Cj4gICB9Cj4gICAKPiArYm9vbCBnZW1fZW5naW5lX2Nh
bl9zdG9yZV9kd29yZChpbnQgZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5l
MiAqZSkKPiArewo+ICsJaWYgKCFnZW1faGFzX2VuZ2luZV90b3BvbG9neShmZCkpCj4gKwkJcmV0
dXJuIGdlbV9jYW5fc3RvcmVfZHdvcmQoZmQsIGUtPmZsYWdzKTsKPiArCj4gKwlyZXR1cm4gZ2Vt
X2NsYXNzX2Nhbl9zdG9yZV9kd29yZChmZCwgZS0+Y2xhc3MpOwo+ICt9CgpDb3VsZG4ndCB5b3Ug
YWx3YXlzIHVzZSBjbGFzcz8KCkl0IGNvdWxkIGJlIHJlZmFjdG9yZWQgd2l0aCBhIGViX2ZsYWdz
X3RvX2NsYXNzIGhlbHBlciBpZiB5b3Ugd291bGQgbGlrZSB0aGlzIHNvbHV0aW9uLiBUaGVuIGl0
IHdvdWxkbid0IG5lZWQgdG8gY2FsbCBnZW1faGFzX2VuZ2luZV90b3BvbG9neSBJIHRoaW5rLgoK
Ym9vbCBnZW1fY2xhc3NfY2FuX3N0b3JlX2R3b3JkKGludCBmZCwgdWludDY0X3QgY2xhc3MpCnsK
CXVpbnQxNl90IGRldmlkID0gaW50ZWxfZ2V0X2RybV9kZXZpZChmZCk7Cgljb25zdCBzdHJ1Y3Qg
aW50ZWxfZGV2aWNlX2luZm8gKmluZm8gPSBpbnRlbF9nZXRfZGV2aWNlX2luZm8oZGV2aWQpOwoJ
Y29uc3QgaW50IGdlbiA9IGZmcyhpbmZvLT5nZW4pOwoKCWlmICghX19nZW1fY2FuX3N0b3JlX2R3
b3JkKGdlbiwgaW5mbykpCgkJcmV0dXJuIGZhbHNlOwoKCWlmIChnZW4gPT0gNiAmJiBjbGFzcyA9
PSBJOTE1X0VOR0lORV9DTEFTU19WSURFTykKCQlyZXR1cm4gZmFsc2U7CiAKIAlyZXR1cm4gdHJ1
ZTsKIH0KCmJvb2wgZ2VtX2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIHVpbnQ2NF90IGVuZ2luZSkK
ewoJdTE2IGNsYXNzID0gZWJfZW5naW5lX3RvX2NsYXNzKGVuZ2luZSk7CgoJcmV0dXJuIGdlbV9j
bGFzc19jYW5fc3RvcmVfZHdvcmQoY2xhc3MpOwp9Cgpib29sIGdlbV9lbmdpbmVfY2FuX3N0b3Jl
X2R3b3JkKGludCBmZCwgY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICplKQp7
CglyZXR1cm4gZ2VtX2NsYXNzX2Nhbl9zdG9yZV9kd29yZChmZCwgZS0+Y2xhc3MpOwp9CgpVbmxl
c3MgSSBtaXNzZWQgc29tZXRoaW5nIGZ1bmRhbWVudGFsLi4KCkxldCBtZSBzZWUgdGhlIG5leHQg
cGF0Y2hlcyBmaXJzdC4uCgpSZWdhcmRzLAoKVHZydGtvCgo+ICsKPiAgIGNvbnN0IHN0cnVjdCBp
bnRlbF9leGVjdXRpb25fZW5naW5lMiBpbnRlbF9leGVjdXRpb25fZW5naW5lczJbXSA9IHsKPiAg
IAl7ICJyY3MwIiwgSTkxNV9FTkdJTkVfQ0xBU1NfUkVOREVSLCAwIH0sCj4gICAJeyAiYmNzMCIs
IEk5MTVfRU5HSU5FX0NMQVNTX0NPUFksIDAgfSwKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9ndC5o
IGIvbGliL2lndF9ndC5oCj4gaW5kZXggNTJiMmYxZWE5NWE1Li5mM2YwN2U4OTU3MzMgMTAwNjQ0
Cj4gLS0tIGEvbGliL2lndF9ndC5oCj4gKysrIGIvbGliL2lndF9ndC5oCj4gQEAgLTg5LDggKzg5
LDYgQEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lIHsKPiAgIGJv
b2wgZ2VtX3JpbmdfaXNfcGh5c2ljYWxfZW5naW5lKGludCBmZCwgdW5zaWduZWQgaW50IHJpbmcp
Owo+ICAgYm9vbCBnZW1fcmluZ19oYXNfcGh5c2ljYWxfZW5naW5lKGludCBmZCwgdW5zaWduZWQg
aW50IHJpbmcpOwo+ICAgCj4gLWJvb2wgZ2VtX2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIHVuc2ln
bmVkIGludCBlbmdpbmUpOwo+IC0KPiAgIGV4dGVybiBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0
aW9uX2VuZ2luZTIgewo+ICAgCWNvbnN0IGNoYXIgKm5hbWU7Cj4gICAJaW50IGNsYXNzOwo+IEBA
IC05OSw2ICs5NywxMCBAQCBleHRlcm4gY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdp
bmUyIHsKPiAgIAlib29sIGlzX3ZpcnR1YWw7Cj4gICB9IGludGVsX2V4ZWN1dGlvbl9lbmdpbmVz
MltdOwo+ICAgCj4gK2Jvb2wgZ2VtX2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIHVpbnQ2NF90KTsK
PiArYm9vbCBnZW1fY2xhc3NfY2FuX3N0b3JlX2R3b3JkKGludCBmZCwgdWludDY0X3QgY2xhc3Mp
Owo+ICtib29sIGdlbV9lbmdpbmVfY2FuX3N0b3JlX2R3b3JkKGludCBmZCwgY29uc3Qgc3RydWN0
IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICplKTsKPiArCj4gICB1bnNpZ25lZCBpbnQKPiAgIGdl
bV9jbGFzc19pbnN0YW5jZV90b19lYl9mbGFncyhpbnQgZ2VtX2ZkLAo+ICAgCQkJICAgICAgIGVu
dW0gZHJtX2k5MTVfZ2VtX2VuZ2luZV9jbGFzcyBjbGFzcywKPiAKX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRl
dkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pZ3QtZGV2