Re: [PATCH i-g-t] tools/dpcd_reg: Advertise the dump command in usage text

["Randhawa, Jagmeet" <jagmeet.randhawa@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]


On 8/15/2024 12:16 PM, Gustavo Sousa wrote:
> When no command is passed, the default operation for dpcd_reg is to dump
> DPCD data. However, passing "dump" explicitly is also supported.
>
> Improve the help message to let the user know about the "dump" command
> and that it is the default operation.
>
> Signed-off-by: Gustavo Sousa<gustavo.sousa@intel.com>
> ---
>   tools/dpcd_reg.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/dpcd_reg.c b/tools/dpcd_reg.c
> index 2761168d0030..7d497e36a46b 100644
> --- a/tools/dpcd_reg.c
> +++ b/tools/dpcd_reg.c
> @@ -89,6 +89,7 @@ static void print_usage(void)
>   {
>   	printf("Usage: dpcd_reg [OPTION ...] COMMAND\n\n");
>   	printf("COMMAND is one of:\n");
> +	printf("  dump:		Dump dpcd data (default command)\n");
>   	printf(" read: Read [count] bytes dpcd reg at an offset\n");
>   	printf("  write:	Write a dpcd reg at an offset\n\n");
>   	printf("Options for the above COMMANDS are\n");
Reviewed-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>

[-- Attachment #2: Type: text/html, Size: 1708 bytes --]