public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sujaritha <sujaritha.sundaresan@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Including E2BIG error to whitelist
Date: Thu, 21 Mar 2019 15:53:49 -0700	[thread overview]
Message-ID: <5a8a84ae-212a-c107-b8a4-cdc57c3b77ac@intel.com> (raw)
In-Reply-To: <155294368968.4168.14995499269644582799@skylake-alporthouse-com>


On 3/18/19 2:14 PM, Chris Wilson wrote:
> Quoting Sujaritha Sundaresan (2019-03-18 20:47:01)
>> Adding E2BIG(7) to the whitelist to prevent it from flagging
>> up in CI and polluting the dmesg with warnings.
>>
>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> Cc: Petri Latvala <petri.latvala@intel.com>
>> ---
>>   runner/resultgen.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/runner/resultgen.c b/runner/resultgen.c
>> index 32b59d59..9bf1c406 100644
>> --- a/runner/resultgen.c
>> +++ b/runner/resultgen.c
>> @@ -490,6 +490,10 @@ static const char igt_dmesg_whitelist[] =
>>           * message.
>>           */
>>          "i915: probe of [0-9:.]+ failed with error -25" _
>> +       /* Fault injection subtest terminates with E2BIG after the
>> +        * test ends, which produces this message.
>> +        */
>> +       "i915: probe of [0-9:.]+ failed with error -7" _
> For fault injection it is legal for it to return any error code, but
> only fault injection. This needs to be a per-test whitelist, preferably
> supplied by the test itself. Could we have a control link back to the
> runner if we don't want igt to run itself?
> -Chris

It makes sense to have the whitelist be specific to tests.

-Sujaritha

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-03-21 23:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 20:47 [igt-dev] [PATCH i-g-t] runner: Including E2BIG error to whitelist Sujaritha Sundaresan
2019-03-18 21:14 ` Chris Wilson
2019-03-21 22:53   ` Sujaritha [this message]
2019-03-18 22:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-19 11:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a8a84ae-212a-c107-b8a4-cdc57c3b77ac@intel.com \
    --to=sujaritha.sundaresan@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox