Re: [igt-dev] [i-g-t] lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call

Ser, Simon
2019-05-15T12:21:09Z

On Thu, 2019-04-25 at 16:43 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
>
> Currently we allocate a state and set the state cursor to 0. The
> latter
> is not needed since it's already zero.
>
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
> Please push this for me if patch looks good. I have commit access,
> yet
> am really short on time at the moment :-(
> ---
> lib/igt_kms.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index df9aafd2..de310042 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -3274,7 +3274,6 @@ static int igt_atomic_commit(igt_display_t
> *display, uint32_t flags, void *user_
> if (display->is_atomic != 1)
> return -1;
> req = drmModeAtomicAlloc();
> - drmModeAtomicSetCursor(req, 0);
>
> for_each_pipe(display, pipe) {
> igt_pipe_t *pipe_obj = &display->pipes[pipe];