From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68C0F6EC8E for ; Thu, 10 Jun 2021 08:52:12 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id b145-20020a1c80970000b029019c8c824054so6007529wmd.5 for ; Thu, 10 Jun 2021 01:52:12 -0700 (PDT) References: <80bed39a-e899-f211-ae2f-279312b52084@gmail.com> <1623143106-8423-1-git-send-email-vidya.srinivas@intel.com> From: Juha-Pekka Heikkila Message-ID: <5bd96874-ec95-e560-9793-e3bdcbd9beec@gmail.com> Date: Thu, 10 Jun 2021 11:52:01 +0300 MIME-Version: 1.0 In-Reply-To: <1623143106-8423-1-git-send-email-vidya.srinivas@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Use igt_pipe_crc_get_current instead of igt_pipe_crc_collect_crc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Vidya Srinivas , igt-dev@lists.freedesktop.org Cc: petri.latvala@intel.com, charlton.lin@intel.com List-ID: Results look ok, there show one new fifo underrun on glk but I don't think it is caused by your change. Reviewed-by: Juha-Pekka Heikkila On 8.6.2021 12.05, Vidya Srinivas wrote: > CRC mismatch is seen between big and small CRC on > Gen11 systems for subtest y-tiled-32bpp-rotate-0. > Patch changes igt_pipe_crc_collect_crc to igt_pipe_crc_get_current > for collecting CRC for big and small fb to compare. > > Signed-off-by: Vidya Srinivas > Change-Id: Ie913127f149f577ab0a034dcbbd4314af17cad52 > --- > tests/kms_big_fb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c > index b35727a09bd0..ea12a34157f2 100644 > --- a/tests/kms_big_fb.c > +++ b/tests/kms_big_fb.c > @@ -331,14 +331,13 @@ static bool test_plane(data_t *data) > * rendering pipeline introduces slight differences into > * the result if we try that, and so the crc will not match. > */ > + igt_pipe_crc_start(data->pipe_crc); > copy_pattern(data, small_fb, 0, 0, big_fb, x, y, > small_fb->width, small_fb->height); > > igt_display_commit2(&data->display, data->display.is_atomic ? > COMMIT_ATOMIC : COMMIT_UNIVERSAL); > - > - > - igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc); > + igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &small_crc); > > igt_plane_set_fb(plane, big_fb); > igt_fb_set_position(big_fb, plane, x, y); > @@ -347,11 +346,12 @@ static bool test_plane(data_t *data) > igt_display_commit2(&data->display, data->display.is_atomic ? > COMMIT_ATOMIC : COMMIT_UNIVERSAL); > > - igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc); > + igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &big_crc); > > igt_plane_set_fb(plane, NULL); > > igt_assert_crc_equal(&big_crc, &small_crc); > + igt_pipe_crc_stop(data->pipe_crc); > } > > return true; > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev