Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/8] i915/gem_eio: Check that context create fails when wedged

From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/8] i915/gem_eio: Check that context create fails when wedged
Date: Tue, 19 Feb 2019 08:53:48 -0800	[thread overview]
Message-ID: <5bfe27d1-ec82-5ece-9a53-722f7b0c6c0f@intel.com> (raw)
In-Reply-To: <20190217143556.9482-1-chris@chris-wilson.co.uk>

On 17/02/19 06:35, Chris Wilson wrote:
> Lock down the new uABI that DRM_IOCTL_I915_GEM_CONTEXT_CREATE returns
> -EIO when wedged.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

LGTM.

Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   tests/i915/gem_eio.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index ac85a2eff..3c54820c9 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -118,6 +118,17 @@ static void test_throttle(int fd)
>   	trigger_reset(fd);
>   }
>   
> +static void test_context_create(int fd)
> +{
> +	uint32_t ctx;
> +
> +	wedge_gpu(fd);
> +
> +	igt_assert_eq(__gem_context_create(fd, &ctx), -EIO);
> +
> +	trigger_reset(fd);
> +}
> +
>   static void test_execbuf(int fd)
>   {
>   	struct drm_i915_gem_execbuffer2 execbuf;
> @@ -807,6 +818,9 @@ igt_main
>   	igt_subtest("throttle")
>   		test_throttle(fd);
>   
> +	igt_subtest("context-create")
> +		test_context_create(fd);
> +
>   	igt_subtest("execbuf")
>   		test_execbuf(fd);
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev