Re: [PATCH i-g-t 3/3] tests/intel/kms_joiner: Add a new test to validate non-joiner mode

[Karthik B S <karthik.b.s@intel.com>]

Hi,

On 2/4/2025 11:57 PM, Jeevan B wrote:
> We need to ensure that the system does not use a joiner for modes that do
> not require it. This test will validate that the correct non-joiner mode
Please mention what is the correct non-joiner mode.
> is selected, and then forcing a modeset and flip on the last pipe. If the
> joiner is mistakenly enabled for a non-joiner mode, the test should fail.
> otherwise, the commit should proceed as expected.
>
> v2: Fix nonjoiner_mode_found to find the required case(6K@30).
>      Remove clk sort and minor fixes. (Karthik)
> v3: Rename nonjoiner to non_joiner and minor modifications. (Swati)
> v4: Add joiner check. (Karthik)
> v5: Rename test name and function name, Update test description,
>      update non_joiner_mode_found logic. (Karthik)
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/intel/kms_joiner.c | 54 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 54 insertions(+)
>
> diff --git a/tests/intel/kms_joiner.c b/tests/intel/kms_joiner.c
> index 086cfeb71..4227aa8b0 100644
> --- a/tests/intel/kms_joiner.c
> +++ b/tests/intel/kms_joiner.c
> @@ -74,6 +74,10 @@
>    *
>    * SUBTEST: switch-modeset-ultra-joiner-big-joiner
>    * Description: Verify switching between ultra joiner and big joiner modeset.
> + *
> + * SUBTEST: non-joiner-corner-cases
> + * Description: Validate non-joiner mode functionality by enabling corner-case display modes
> + *		that vary across different platforms.
>    */
>   IGT_TEST_DESCRIPTION("Test joiner / force joiner");
>   
> @@ -85,6 +89,7 @@ typedef struct {
>   	int ultra_joiner_output_count;
>   	int non_big_joiner_output_count;
>   	int non_ultra_joiner_output_count;
> +	int non_joiner_output_count;
>   	int mixed_output_count;
>   	int output_count;
>   	int n_pipes;
> @@ -94,6 +99,7 @@ typedef struct {
>   	igt_output_t *non_big_joiner_output[IGT_MAX_PIPES];
>   	igt_output_t *non_ultra_joiner_output[IGT_MAX_PIPES];
>   	igt_output_t *mixed_output[IGT_MAX_PIPES];
> +	igt_output_t *non_joiner_output[IGT_MAX_PIPES];
>   	enum pipe pipe_seq[IGT_MAX_PIPES];
>   	igt_display_t display;
>   } data_t;
> @@ -491,6 +497,41 @@ static void test_ultra_joiner(data_t *data, bool invalid_pipe, bool two_display,
>   	}
>   }
>   
> +static void test_non_joiner_corner_cases(data_t *data)
> +{
> +	int count;
> +	enum pipe pipe;
> +	igt_output_t **outputs, *output;
> +	igt_fb_t fb;
> +	igt_plane_t *primary;
> +	drmModeModeInfo *mode;
> +
> +	count = data->non_joiner_output_count;
> +	outputs = data->non_joiner_output;
> +	igt_display_reset(&data->display);
> +
> +	for (int i = 0; i < count; i++) {
> +		output = outputs[i];
> +		mode = igt_output_get_mode(output);
> +		for (pipe = 0; pipe < data->n_pipes - 1; pipe++) {
> +			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
> +				igt_output_set_pipe(output, pipe);
> +				primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> +				igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> +						      DRM_FORMAT_MOD_LINEAR, &fb);
> +				igt_plane_set_fb(primary, &fb);
> +				igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +				igt_assert_f(!igt_is_joiner_enabled(data->drm_fd, pipe),
> +					     "Joiner enabled on pipe %c", 'A' + pipe);
> +
> +				igt_display_reset(&data->display);
> +				igt_plane_set_fb(primary, NULL);
> +				igt_remove_fb(data->drm_fd, &fb);
> +			}
> +		}
> +	}
> +}
> +
>   igt_main
>   {
>   	bool ultra_joiner_supported, is_dgfx;
> @@ -505,6 +546,7 @@ igt_main
>   		data.ultra_joiner_output_count = 0;
>   		data.non_big_joiner_output_count = 0;
>   		data.non_ultra_joiner_output_count = 0;
> +		data.non_joiner_output_count = 0;
>   		data.mixed_output_count = 0;
>   		data.output_count = 0;
>   		j = 0;
> @@ -523,6 +565,7 @@ igt_main
>   
>   		for_each_connected_output(&data.display, output) {
>   			bool ultrajoiner_found = false, bigjoiner_found = false, force_joiner_supported = false;
> +			bool non_joiner_found = false;
>   			drmModeConnector *connector = output->config.connector;
>   
>   			/*
> @@ -533,6 +576,7 @@ igt_main
>   			 */
>   			bigjoiner_found = bigjoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
>   			ultrajoiner_found = ultrajoiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
> +			non_joiner_found = non_joiner_mode_found(data.drm_fd, connector, max_dotclock, &mode);
>   
>   			if (igt_has_force_joiner_debugfs(data.drm_fd, output->name))
>   				force_joiner_supported = true;
> @@ -548,6 +592,9 @@ igt_main
>   			else if (force_joiner_supported)
>   				data.non_big_joiner_output[data.non_big_joiner_output_count++] = output;
>   
> +			if (non_joiner_found)
> +				data.non_joiner_output[data.non_joiner_output_count++] = output;
> +
>   			data.output_count++;
>   		}
>   		if (data.big_joiner_output_count == 1 && data.non_big_joiner_output_count >= 1) {
> @@ -713,6 +760,13 @@ igt_main
>   		}
>   	}
>   
> +	igt_describe("Verify the basic modeset on big joiner mode on all pipes");
Please fix/update this.
> +	igt_subtest_with_dynamic("non-joiner-corner-cases") {

'basic-max-non-joiner' maybe? Please update other function names also 
accordingly.

Thanks,
Karthik.B.S
> +		igt_require_f(data.n_pipes >= 1,
> +			      "Minimum of 1 pipe is required.\n");
> +			test_non_joiner_corner_cases(&data);
> +	}
> +
>   	igt_fixture {
>   		igt_display_fini(&data.display);
>   		drm_close_driver(data.drm_fd);