From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E4A7C61DBE for ; Sat, 29 Aug 2026 18:38:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51B4A10E11F; Sat, 29 Aug 2026 18:38:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="IwAN1N4l"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4BC410E11F for ; Sat, 29 Aug 2026 18:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788028671; x=1819564671; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=vHOnKc32Ra7/Swr5TGV9jotbtLy9TUprVptrmGg/GfA=; b=IwAN1N4lQvC/S2u3u1pFOCxMlxzY2B42PVU2A7IM4hplxzIDncCBz6vE hf2/pLfiQY3oKUY3vQiAFZJKfRikl8fVEtIJR4QADdc95qOpbcdklAlAO XZaHwOmemEqBSHukjUznaYgpQ8gB9w801+y9MSbYhBnpq/44vfBW0YOnV MDF2WiadDTSvP9IjF/qQjoMJB1JmFjZvSuKSa9q9hDdLyAThzphCjIXug Veqe2AINC4zBvPNOx/vpccQeFKLP2+Idnl7VBnTlSipZgn9rPHu2ENnLh uXaoGk1N4WBgEzrqeIQoVd1eEJLYbOLTcLDv79smkBC/qJ7uDul3TcOWS g==; X-CSE-ConnectionGUID: SCexOZghSnmrCIgpSM+CXg== X-CSE-MsgGUID: UQrMSKkeTIe0DIn2iXZIcA== X-IronPort-AV: E=McAfee;i="6800,10657,11890"; a="87445344" X-IronPort-AV: E=Sophos;i="6.25,250,1779174000"; d="scan'208,217";a="87445344" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2026 11:37:50 -0700 X-CSE-ConnectionGUID: QK4muVxMSNKOXurZu4jnRg== X-CSE-MsgGUID: itGqg319QmCI70gDRJIsIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,250,1779174000"; d="scan'208,217";a="291925802" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2026 11:37:50 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sat, 29 Aug 2026 11:37:49 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46 via Frontend Transport; Sat, 29 Aug 2026 11:37:49 -0700 Received: from BYAPR05CU005.outbound.protection.outlook.com (52.101.85.1) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Sat, 29 Aug 2026 11:37:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TtwNZ6r6ujyxq06n2ENyKMCynfMM4z6Vbrqzn5qSkP4gt9iwhVR/ULxALHhzDpgEAqO0UYDI8sBkVnX8o4Cz33VQ1ihDxODvg0Cl4/ZACqHsaaJRW36nHNEd6+Hi0ecZkv9WYfB3qfZazw8Tu9VlGrWQ3nZkbMrVvEE0TEpAd8R5GGFaucj8mnPPK7Qm+rFdQjba270vrJEdE1axYIw+/wTDpTesq2XgkHZmFbeLh/R/5iporGuoY1Ak16LqeWCbVZYBaTRPnD5WT4kzHlwYDh1QXV3n2tNU9RXu2quGcfVRj+mT67DwxUU/smD1tqxuPEO8bwPpbmT3hbsnyUFzNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzWCQ2YwX+Hr9QpkSGhCyVae1AVu/L9aUFiIaoGWu48=; b=LWoblJ79PiJdFz5Kq7YD/T0AO3jJPWeynPSUeny5oCEglC0YfaHCmy2ITcw0hNSzgUtl4kPqslZaBIwD17XVeTUqxk7CGStINWs7NBDF6Bz1X5GI7the8JocU7iXEBNgty6FPXwoP1VsfD9mS/NC8N/cradGlCeKgiJd+jPjY5JtI+H+akI+xT1cLE+WFAm2BCRFwdQYmZR4Ut1yaz8mhj3S8m6XSbZkqI5HVYKtjBC8Io20IoXiaAEOVtGRAxsmpaJNfeQEU48+9QYgDoJ4Wp4mQNHjYaM3ssmyjdngI5BTHVBlk9b6Z7JuSy2GEbvPse0AB+aW1i4ftOKt2apA+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4913.namprd11.prod.outlook.com (2603:10b6:303:9f::20) by PH3PPF7A88A980A.namprd11.prod.outlook.com (2603:10b6:518:1::d32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.12; Sat, 29 Aug 2026 18:37:42 +0000 Received: from CO1PR11MB4913.namprd11.prod.outlook.com ([fe80::938d:6d4c:e26f:ed03]) by CO1PR11MB4913.namprd11.prod.outlook.com ([fe80::938d:6d4c:e26f:ed03%5]) with mapi id 15.21.0360.008; Sat, 29 Aug 2026 18:37:41 +0000 Content-Type: multipart/alternative; boundary="------------NfOLTOxgljFgFeEyo5cxMbp0" Message-ID: <5d262a77-d304-4c1f-a4bd-307883cf9197@intel.com> Date: Sun, 30 Aug 2026 00:07:35 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t v3 06/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack` To: =?UTF-8?Q?Micha=C5=82_Grzelak?= , CC: , References: <20260821124834.1974029-1-michal.grzelak@intel.com> <20260821124834.1974029-7-michal.grzelak@intel.com> Content-Language: en-GB From: "Thasleem, Mohammed" In-Reply-To: <20260821124834.1974029-7-michal.grzelak@intel.com> X-ClientProxiedBy: MA5PR01CA0253.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:223::17) To CO1PR11MB4913.namprd11.prod.outlook.com (2603:10b6:303:9f::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4913:EE_|PH3PPF7A88A980A:EE_ X-MS-Office365-Filtering-Correlation-Id: 506db9bf-dcef-48ed-436a-08df05fc9bdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|366016|1800799024|4143699003|10067099003|5023799004|11063799006|56012099006|22082099003|18002099003|8096899003; X-Microsoft-Antispam-Message-Info: fLRBXMyLBsfv1gwrCPH14Ok7jx3ZwO9W2trRYTGllu1h4mSu09IaRKVUpDkydaxIV4e151B3Qhe4/TCyLtxnEbODhYi525W2fHjCstju3aftDgr3nXPwYx1iHLd/N1EiI/a8Tjo2WdJ0U41Kjpq87PGM/48yvbohH+T2VquSuc8lb5uQDXErOC1OWJkWXTwyIjCMNLmR7B8dpXby3wCMX243qJDv9M/qJ990N62hDa/uI9/b6/xLJI+w4ycta4MwirB2XeUg+TqA/Y/b5xbzEfoxSo9lFN9dZi1uNOhgl1I8qmum6cqSFO2xU+NfQwm+xhPeV4Yek1ujGC36GS6Sc3ksZ3hMv9+0KhZRztLA1hGefmGi1MjfaGGU190DbnSESIS3U7eJhgfn6e1S8dfK8dLfH6dUBUx+9UIQKKHD7frTYMKjkMTAEMuA9PpLnteeUFjNuv7C1kkJ9KwFFhfDYSu68VhArc4F1NNe7+aa3wdG3V251pMlmfXw/RSelkHhRUhAJYDX+xblacEVeLpImjHMeL1ZjP67RCy0NJiCiYkB+01QBnk5XkaWPLM23vSokOMtcwHoBwkXAx5dsusASFlWwOBVRM2H8R8/3AXdU1Z05V8TpGxGv3uOZAmykqzSw1D/5UgRKzgLzOaDpFdMnpQZhhuqEZoltk231+Zw2AI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4913.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(4143699003)(10067099003)(5023799004)(11063799006)(56012099006)(22082099003)(18002099003)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU5VVVg4MmphUER5NmlIVG8zWWVMSDl1ajBjQzFNSjdEaktPVnFCZEhkN3pV?= =?utf-8?B?NzkvSE42L0JuM3M3MmVQYVIrM2JCM2dUemdTeHhoOEsya0ZEZ3hORHc1TzFt?= =?utf-8?B?ZWFXR1NlaVpLQ045Nmp0a0xGdnhFZW9FMW5Ba2NacEdFeExtdlNCMHlHWWV6?= =?utf-8?B?Und5NENXaCt0TWl0aXlGK010Z0t2bSsyUVcyRTFLb3BKQXUxWFpaRktZQWRH?= =?utf-8?B?OFYzaFFmWHlkdUk1TzFySlg5UytmRzhTRXcyQnZNYlMxY21waEhldUd5VS84?= =?utf-8?B?dm9mSU41ZUlyemo2K2VYZEdiWUJTZ0grRmRwdmRrRFpBMTlWczFsWU5CR1ha?= =?utf-8?B?SDhqM0Z2OUYvSThjQjE3ZTVZeW1WcXRJc1EvZGdYcXJyN1hlRE4reDJmRUlT?= =?utf-8?B?T1ZYQWdtVXpaZ3FpSm1FVFdibE5tdWx5S2pqaTY0Tis0UnpZeW5TN3JQMzVD?= =?utf-8?B?M04yRlNXQW91OVZMUGRwVGUxa2VySnorL2xwMzlrUHBONDVTa2VMaVdWck9k?= =?utf-8?B?QU5QbHBKM2xQSnhBNTN3SmVHY2JOTGxTOFFEc2Q3cFZ6bmlSRU04bTBNMm1V?= =?utf-8?B?UWwrRnFxSVoydE54b2kvb1hIN3ZrM0dhTVhBeDFsWUxjMnJlOWJYN2YyM05H?= =?utf-8?B?VkU2ZVFpTVVjUVNmY3ZFOUJWMG9nRmxxTVdlbmV5OVhRYkFNcVZzQWFnajRm?= =?utf-8?B?c1QzYW8yY3pxWlJCVFpkaUgyVmV3N2xNaHN5dXU2MHBIeXZaUkFDVldCQ2FT?= =?utf-8?B?WGpabE4zT25lYWx3OXRKQSt1VWlZdVNNdGcycVBvZUtMbE5xVUlwU0w3dFNZ?= =?utf-8?B?K1VkRVVrRVlzQWFKRDZVczlua24zc25lMjVKcXR2TDJnSGlZMGVsa2JDbEJ4?= =?utf-8?B?UWJ1aUZkK09zRW1aOEVJWDJpSUREYWZHbFFCazU4ZVY0V1VnQWlOQ1MwTkh4?= =?utf-8?B?QkNBSDFlZ3RMM2R5QmxINlV5QmVOT3J4OUt4TTNTV1BpNHZXMWp3ZExqanQv?= =?utf-8?B?RW9IWUlqQmtsOXJkMHBReUJKQXVQdXkvQzBybmZtaE92Y25OVG5weEFIZDRX?= =?utf-8?B?YTI5T0dQOWsxTk1UVGwxRmQyTFNVeVErb3NXekg3Zjh6aG9ZM2hKNElZM3gw?= =?utf-8?B?YVUrU1M3MzBrWnBvQ1JUSTQ4bEJJVElINSsrVVNGMzg4SjZ4WUx1Z2J5QlBF?= =?utf-8?B?QXBSS2htVHhqV0loc0p4OStqeCtiN0JSSE1FMFN4UCtvMUtjNjRuUit0b0gw?= =?utf-8?B?YU1hMVFZbDJvcTZDZS9hZFFoNFBHbzNLZHEwaDNEL1R3bkZNZUVmT2g0Mjh6?= =?utf-8?B?bUZoZjc5Z2ZZcGZMWW5LOTN4Qk1SSlpUUmVlWGZsVUxjV2VXeHJ5amU4SjJG?= =?utf-8?B?enNRUFBSNkdjQVdvUzdQa0RMK2FEdFFDMDVmWG4xRlFRWWhJd2F4MHVXSUFa?= =?utf-8?B?N1FKcTQwQk5xT01VRzV2RmwyQjdYSHlEamVIYVlRdmkyVmNsVkdLbVk0bHVD?= =?utf-8?B?aXhJbjJWZS9jMFJFc3N0QjFLV1lvelJuT2dOcDlnaWxwZFo2Ulh3Z05GT3ZT?= =?utf-8?B?TG5tQWZXaWh5bnhlTlFqR1hxZmZ0QS9seUlRTVpCTmFLYTRIUThnVHZqdy9n?= =?utf-8?B?SmxoVkJMSmNlSFVaSmJmSmZWK1h4c0QxWkJxdnhVUWhvT2xCNmFtSWFOZW5F?= =?utf-8?B?NGNHSWxWblJIdVYxRUFjY2FNWWViMGhjelg1OFlLc2o3ZHI0c05EbHVSSjRT?= =?utf-8?B?WmJRaFhEMW1RKzFRUmxqOXBPcmo0TDZNZlBtYWVQNVdWbkt3djFURlV3V2tn?= =?utf-8?B?NENGT3JTMHhMY0JQKzUyMktQSDlKMTBRc3NzRFc3NTNQR1N1bzNQOWhvaG9k?= =?utf-8?B?K0paVDkyVmhaQzZwZGpHMkJnQWhlK3lGUk1xUlp5SzNRcUlQYnhZdFFCQmNQ?= =?utf-8?B?RWdjdi9SUUc3UTdyRDMyRDJHbHJKS0sxNmlKY3lzVXU1VVM5b3BXTzJCUUVU?= =?utf-8?B?YnJ5VDJMcFhCcTB4RWRQbzU2K0l0cHdQVWw4QzJIS3R1R09xcXlQSXpER1F6?= =?utf-8?B?NEVDQWwvZ2J2RHN4SzJKeFd2TXpXd2tpRWZTM2pEMmQxeGUyNUxsekQxcjFa?= =?utf-8?B?cVhlOXcwQ0VOUmVNUStTSm1KM2tGZXIrNU5zWjVWb3FWUXpNSkREcVlYTmg4?= =?utf-8?B?ckxNRWs3MDFDbUJYTGVaQURYQ1kzWmxST2IwcTI0VXV4MXNCaFRLRzUzTnhu?= =?utf-8?B?RGRBRnFtaXB0Tit1ZWY3Sm53RU9ENFRKRG1OYTdTY2dNVlIrdHNTUUpjbENX?= =?utf-8?B?WDNBbkZPbUIyUnNZa1dMWjArUGNWQTZ4SzJldGtRSUpmbUtiZzhEdWtMbW4v?= =?utf-8?Q?6hnoaXTgqdoCfqk4=3D?= X-Exchange-RoutingPolicyChecked: AiZmHSvLXY2pj0V2q2LMc8EUvzTisn2wVKuORvtFfzU3D0AUeNXpX+1MpRCseBVW9cjoB0bTtyuVrhGzYS+1M2VmAlN1btIt5Apagz1QsS8+aTDSmjVXbV8DWGCu7/eBlW4tKdSLxFsUpKAUsLJPM2fcooCeQ31sQp0JMAn6JNRVo2+yuKGBVTmaFYmPqre4TnWLgeChz/MfiOz70uXrvm6iKDxmhuOjOLnh8ZXLqHSZXPsCo1pC3NNemcxT8dfPv+vcTRvZECC4F9FNk0Gv4So7SIY0O6oayKndCxcXRTupx3kpgLSV5FLZfQfa2PzfjRN/t4g7/PolTWOUSZDB3Q== X-MS-Exchange-CrossTenant-Network-Message-Id: 506db9bf-dcef-48ed-436a-08df05fc9bdb X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4913.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2026 18:37:41.8029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J9RpdJHGqDyAiWaSqcy47RqKVDB2V4D5tx/Wmug7APF4d9avDkB7bk2xLCDu1+KZQVKGkTL2Vw4qtAm5gRanMT0sn52NUKMbkL2381+eGqo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF7A88A980A X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" --------------NfOLTOxgljFgFeEyo5cxMbp0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 21-08-2026 06:18 pm, Michał Grzelak wrote: > igt@kms_frontbuffer_tracking uses TEST_MODE_ITER_BEGIN(t) which consists > of nested for loops. However many loops can be omitted due to continue > statements. This obfuscates following the execution of any given > codepath. Replace TEST_MODE_ITER_BEGIN(t) for fliptrack tests with macro > definition and remove loops that are skipped. > > v2->v3 > - identation cleanups (Mohammed) > - pull conditions after first loop (Mohammed) > > v1->v2 > - indent for-loops (Mohammed) > > Signed-off-by: Michał Grzelak LGTM: Reviewed-by: Mohammed Thasleem > --- > tests/intel/kms_frontbuffer_tracking.c | 40 +++++++++++++++++--------- > 1 file changed, 26 insertions(+), 14 deletions(-) > > diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c > index dc8ef069b8..9faae7d3fd 100644 > --- a/tests/intel/kms_frontbuffer_tracking.c > +++ b/tests/intel/kms_frontbuffer_tracking.c > @@ -4502,23 +4502,35 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL) > } > TEST_MODE_ITER_END > > - TEST_MODE_ITER_BEGIN(t) > - if (t.plane != PLANE_PRI || > - t.screen != SCREEN_PRIM || > - t.method != IGT_DRAW_MMAP_GTT || > - (t.feature & FEATURE_FBC) == 0) > + t.format = FORMAT_DEFAULT; > + t.flip = FLIP_PAGEFLIP; > + t.tiling = opt.tiling; > + t.plane = PLANE_PRI; > + t.screen = SCREEN_PRIM; > + t.method = IGT_DRAW_MMAP_GTT; > + > + for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) { > + if (!opt.show_hidden && t.feature == FEATURE_NONE) > + continue; > + if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS)) > + continue; > + if ((t.feature & FEATURE_FBC) == 0) > continue; > > - igt_subtest_f("%s-%s-%s-fliptrack-%s", > - feature_str(t.feature), > - pipes_str(t.pipes), > - fbs_str(t.fbs), > - igt_draw_get_method_name(t.method)) > - { > - igt_require(igt_draw_supports_method(drm.fd, t.method)); > - fliptrack_subtest(&t, FLIP_PAGEFLIP); > + for (t.pipes = 0; t.pipes < PIPE_COUNT; t.pipes++) { > + for (t.fbs = 0; t.fbs < FBS_COUNT; t.fbs++) { > + igt_subtest_f("%s-%s-%s-fliptrack-%s", > + feature_str(t.feature), > + pipes_str(t.pipes), > + fbs_str(t.fbs), > + igt_draw_get_method_name(t.method)) > + { > + igt_require(igt_draw_supports_method(drm.fd, t.method)); > + fliptrack_subtest(&t, FLIP_PAGEFLIP); > + } > + } > } > - TEST_MODE_ITER_END > + } > > TEST_MODE_ITER_BEGIN(t) > if (t.screen == SCREEN_OFFSCREEN || --------------NfOLTOxgljFgFeEyo5cxMbp0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 21-08-2026 06:18 pm, Michał Grzelak wrote:
igt@kms_frontbuffer_tracking uses TEST_MODE_ITER_BEGIN(t) which consists
of nested for loops. However many loops can be omitted due to continue
statements. This obfuscates following the execution of any given
codepath. Replace TEST_MODE_ITER_BEGIN(t) for fliptrack tests with macro
definition and remove loops that are skipped.

v2->v3
- identation cleanups (Mohammed)
- pull conditions after first loop (Mohammed)

v1->v2
- indent for-loops (Mohammed)

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>

LGTM:

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

---
 tests/intel/kms_frontbuffer_tracking.c | 40 +++++++++++++++++---------
 1 file changed, 26 insertions(+), 14 deletions(-)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index dc8ef069b8..9faae7d3fd 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -4502,23 +4502,35 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
 			}
 	TEST_MODE_ITER_END
 
-	TEST_MODE_ITER_BEGIN(t)
-		if (t.plane != PLANE_PRI ||
-		    t.screen != SCREEN_PRIM ||
-		    t.method != IGT_DRAW_MMAP_GTT ||
-		    (t.feature & FEATURE_FBC) == 0)
+	t.format = FORMAT_DEFAULT;
+	t.flip = FLIP_PAGEFLIP;
+	t.tiling = opt.tiling;
+	t.plane = PLANE_PRI;
+	t.screen = SCREEN_PRIM;
+	t.method = IGT_DRAW_MMAP_GTT;
+
+	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
+		if (!opt.show_hidden && t.feature == FEATURE_NONE)
+			continue;
+		if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS))
+			continue;
+		if ((t.feature & FEATURE_FBC) == 0)
 			continue;
 
-		igt_subtest_f("%s-%s-%s-fliptrack-%s",
-			      feature_str(t.feature),
-			      pipes_str(t.pipes),
-			      fbs_str(t.fbs),
-			      igt_draw_get_method_name(t.method))
-		{
-			igt_require(igt_draw_supports_method(drm.fd, t.method));
-			fliptrack_subtest(&t, FLIP_PAGEFLIP);
+		for (t.pipes = 0; t.pipes < PIPE_COUNT; t.pipes++) {
+			for (t.fbs = 0; t.fbs < FBS_COUNT; t.fbs++) {
+				igt_subtest_f("%s-%s-%s-fliptrack-%s",
+					      feature_str(t.feature),
+					      pipes_str(t.pipes),
+					      fbs_str(t.fbs),
+					      igt_draw_get_method_name(t.method))
+				{
+					igt_require(igt_draw_supports_method(drm.fd, t.method));
+					fliptrack_subtest(&t, FLIP_PAGEFLIP);
+				}
+			}
 		}
-	TEST_MODE_ITER_END
+	}
 
 	TEST_MODE_ITER_BEGIN(t)
 		if (t.screen == SCREEN_OFFSCREEN ||
--------------NfOLTOxgljFgFeEyo5cxMbp0--