Re: [PATCH v3 2/2] lib/igt_core: add timestamps to error logs

["Knop, Ryszard" <ryszard.knop@intel.com>]

LGTM, so:

Reviewed-by: Ryszard Knop <ryszard.knop@intel.com>

On Mon, 2026-05-11 at 14:55 +0200, Andrzej Hajda wrote:
> IGT tests run often time consuming tasks. Timestamps should simplify
> time analysis and matching with kernel logs.
> Since IGT is closely connected with the kernel let's use the same format.
> 
> v2: adjusted string format and commit subject
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
>  lib/igt_core.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 5a0ab4361eaa..72b7d3449888 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -3226,10 +3226,15 @@ void igt_vlog(const char *domain, enum igt_log_level level, const char *format,
>  		formatted_line = strdup(line);
>  		if (!formatted_line)
>  			goto out;
> -	} else if (asprintf(&formatted_line, "(%s:%d) %s%s%s%s: %s", program_name,
> -		     getpid(), thread_id, (domain) ? domain : "", (domain) ? "-" : "",
> -		     igt_log_level_str[level], line) == -1) {
> -		goto out;
> +	} else {
> +		struct timespec ts;
> +
> +		igt_gettime(&ts);
> +		if (asprintf(&formatted_line, "[%ld.%06ld] (%s:%d) %s%s%s%s: %s", (long)ts.tv_sec,
> +			     ts.tv_nsec / 1000, program_name, getpid(), thread_id,
> +			     (domain) ? domain : "", (domain) ? "-" : "", igt_log_level_str[level],
> +			     line) == -1)
> +			goto out;
>  	}
>  
>  	if (line[strlen(line) - 1] == '\n')