Re: [PATCH i-g-t v1 1/1] lib/igt_psr: Remove SRD status change check for DP2.1 Panel Replay

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Thu, 2024-09-05 at 14:23 +0530, Naladala Ramanaidu wrote:
> We do not have ALPM on the DP2.1 Panel Replay. Due to this, the
> SRD_STATUS [SRD State] doesn't change from SRDENT_ON after Panel
> Replay is enabled until it gets disabled. As a result, the igt
> tests fail. To resolve this issue, add a condition to skip the
> check in the 'psr_wait_update' and 'psr_long_wait_update'
> functions for DP2.1 PR.
> 
> v1: Update change for all users of psr_wait_update and
>     psr_long_wait_update. (Jouni)
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com> 
> ---
>  lib/igt_psr.c | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index e3e7577eb..2677d4822 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -113,12 +113,28 @@ bool psr_wait_entry(int debugfs_fd, enum
> psr_mode mode, igt_output_t *output)
>  
>  bool psr_wait_update(int debugfs_fd, enum psr_mode mode,
> igt_output_t *output)
>  {
> -       return igt_wait(!psr_active_check(debugfs_fd, mode, output),
> 40, 1);
> +       /*
> +        * TODO: After enabling Panel Replay on DP2.1, observe that
> the SRD status
> +        * remains in the SRDENT_ON state. Remove the polling
> mechanism for the SRD
> +        * status change for the DP2.1 output.
> +        */
> +       if (output->config.connector->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort)
> +               return igt_wait(psr_active_check(debugfs_fd, mode,
> output), 40, 1);
> +       else
> +               return igt_wait(!psr_active_check(debugfs_fd, mode,
> output), 40, 1);
>  }
>  
>  bool psr_long_wait_update(int debugfs_fd, enum psr_mode mode,
> igt_output_t *output)
>  {
> -       return igt_wait(!psr_active_check(debugfs_fd, mode, output),
> 500, 1);
> +       /*
> +        * TODO: After enabling Panel Replay on DP2.1, observe that
> the SRD status
> +        * remains in the SRDENT_ON state. Remove the polling
> mechanism for the SRD
> +        * status change for the DP2.1 output.
> +        */
> +       if (output->config.connector->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort)
> +               return igt_wait(psr_active_check(debugfs_fd, mode,
> output), 500, 1);
> +       else
> +               return igt_wait(!psr_active_check(debugfs_fd, mode,
> output), 500, 1);

This actually shows that we need to add SRDENT_ON into
psr_active_check. Maybe you could do add second patch to this set?

BR,

Jouni Högander

>  }
>  
>  static ssize_t psr_write(int debugfs_fd, const char *buf,
> igt_output_t *output)