From: "Ser, Simon" <simon.ser@intel.com>
To: "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>,
"Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Sarvela, Tomi P" <tomi.p.sarvela@intel.com>
Subject: Re: [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: add hdmi-audio test (rev2)
Date: Mon, 13 May 2019 14:17:53 +0000 [thread overview]
Message-ID: <5ef0f8ab007d9a9a60c93f3c857cc78de1945d87.camel@intel.com> (raw)
In-Reply-To: <20190513125545.GK22949@platvala-desk.ger.corp.intel.com>
On Mon, 2019-05-13 at 15:55 +0300, Petri Latvala wrote:
> On Mon, May 13, 2019 at 03:09:04PM +0300, Arkadiusz Hiler wrote:
> > (kms_chamelium:2919) igt_chamelium-CRITICAL: Chamelium RPC call
> > failed: RPC failed at server. <type 'exceptions.Exception'>:method
> > "GetAudioFormat" is not supported
> >
> > Welp, at least there are no regressions. I guess our Chameliums
> > need
> > to be updated...
> >
> > Anyway, everything (sans the HAX) is:
> > Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
> Hold on, recording the conversation from the office to email:
>
> These fails need to be skips instead.
Actually, calling HasAudioSupport will only work for DisplayPort tests.
For HDMI tests, the old Chamelium devices support audio capture but are
missing some API calls (GetAudioChannelMapping, GetAudioFormat).
These new functions fail if no audio capture has been started. Thus,
we'd need to call them, expect them to fail, and check the error
message. It'd be a bit hacky.
Is it really that important?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-13 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 8:15 [igt-dev] [PATCH i-g-t 0/8] tests/kms_chamelium: add hdmi-audio test Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 1/8] lib/igt_edid: add support for Short Audio Descriptors Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 2/8] lib/igt_edid: add support for Vendor Specific Data blocks Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 3/8] lib/igt_chamelium: add CHAMELIUM_DEFAULT_EDID Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 4/8] tests/kms_chamelium: generate an EDID with audio support Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 5/8] test/kms_chamelium: disable >48KHz audio tests Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 6/8] tests/kms_chamelium: enable audio test on HDMI ports Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 7/8] tests/kms_chamelium: don't abort audio test on first fail Simon Ser
2019-05-13 8:15 ` [igt-dev] [PATCH i-g-t 8/8] HAX: add {dp, hdmi}-audio test to fast-feedback Simon Ser
2019-05-13 8:19 ` [igt-dev] [PATCH i-g-t 0/8] tests/kms_chamelium: add hdmi-audio test Ser, Simon
2019-05-13 8:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: add hdmi-audio test (rev2) Patchwork
2019-05-13 12:09 ` Arkadiusz Hiler
2019-05-13 12:55 ` Petri Latvala
2019-05-13 13:01 ` Ser, Simon
2019-05-13 14:17 ` Ser, Simon [this message]
2019-05-14 9:02 ` Petri Latvala
2019-05-14 9:49 ` Ser, Simon
2019-05-13 9:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ef0f8ab007d9a9a60c93f3c857cc78de1945d87.camel@intel.com \
--to=simon.ser@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox