From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6886510E194 for ; Tue, 25 Apr 2023 22:59:37 +0000 (UTC) Message-ID: <5f1a7a38-f7b0-9d2c-fb3c-3f81550b3b98@amd.com> Date: Tue, 25 Apr 2023 16:59:32 -0600 Content-Language: en-US To: Hersen Wu , igt-dev@lists.freedesktop.org, rodrigo.siqueira@amd.com, aurabindo.pillai@amd.com, hamza.mahfooz@amd.com References: <20230424130657.50263-1-hersenxs.wu@amd.com> From: Alex Hung In-Reply-To: <20230424130657.50263-1-hersenxs.wu@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH] [i-g-t] lib/igt_amd: add delay waiting for hotplug complete List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Reviewed-by: Alex Hung On 2023-04-24 07:06, Hersen Wu wrote: > when run amd tests, amd_hotplug, amd_link_setings, in patch, > amd_link_settings be skipped. debugfs_hpd_trigger requests > kernel to generate hot plug event, but not wait for process > finish.it takes time for kernel and user mode components to > complete process for hot plug. > > Signed-off-by: Hersen Wu > --- > lib/igt_amd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/igt_amd.c b/lib/igt_amd.c > index bef9c193..09923101 100644 > --- a/lib/igt_amd.c > +++ b/lib/igt_amd.c > @@ -799,6 +799,8 @@ int igt_amd_trigger_hotplug(int drm_fd, char *connector_name) > wr_len = write(hpd_fd, enable_hpd, strlen(enable_hpd)); > close(hpd_fd); > igt_assert_eq(wr_len, strlen(enable_hpd)); > + /* wait for hotplug process complete by kernel and user mode components */ > + sleep(30); > > return 0; > }