From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71FC16E6AA for ; Tue, 15 Jan 2019 13:14:13 +0000 (UTC) References: <20190115123511.11474-1-andi.shyti@intel.com> <20190115123511.11474-3-andi.shyti@intel.com> <154755723693.30063.8985044656295200164@skylake-alporthouse-com> From: Tvrtko Ursulin Message-ID: <5fb9e076-2371-12cc-c8db-6fbae7e2cb8c@linux.intel.com> Date: Tue, 15 Jan 2019 13:14:10 +0000 MIME-Version: 1.0 In-Reply-To: <154755723693.30063.8985044656295200164@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [RFC PATCH v4 2/3] lib: implement new engine discovery interface List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDE1LzAxLzIwMTkgMTM6MDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIEFuZGkg U2h5dGkgKDIwMTktMDEtMTUgMTI6MzU6MTApCj4+IEtlcm5lbCBjb21taXRzOgo+Pgo+PiBbMV0g YWU4ZjQ1NDRkZDhmICgiZHJtL2k5MTU6IEVuZ2luZSBkaXNjb3ZlcnkgcXVlcnkiKQo+PiBbMl0g MzFlN2QzNTY2N2EwICgiZHJtL2k5MTU6IEFsbG93IGEgY29udGV4dCB0byBkZWZpbmUgaXRzIHNl dCBvZiBlbmdpbmVzIikKPj4KPj4gZnJvbSBbKl0gcmVwb3NpdG9yeSwgaW1wbGVtZW50IGEgbmV3 IHVhcGkgZm9yIGVuZ2luZSBkaXNjb3ZlcnkKPj4gdGhhdCBjb25zaXN0IGluIGZpcnN0IHF1ZXJ5 aW5nIHRoZSBkcml2ZXIgYWJvdXQgdGhlIGVuZ2luZXMgaW4KPj4gdGhlIGdwdSBbMV0gYW5kIHRo ZW4gYmluZGluZyBhIGNvbnRleHQgdG8gdGhlIHNldCBvZiBlbmdpbmVzIHRoYXQKPj4gaXQgY2Fu IGFjY2VzcyBbMl0uCj4+Cj4+IEluIGlndCB0aGUgY2xhc3NpYyB3YXkgZm9yIGRpc2NvdmVyaW5n IGVuZ2luZXMgaXMgZG9uZSB0aHJvdWdoCj4+IHRoZSBmb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUo KSBtYWNybywgdGhhdCB3b3VsZCBiZSByZXBsYWNlZCBieQo+PiB0aGUgbmV3IGZvcl9lYWNoX2Vu Z2luZV9jdHgoKS4KPj4KPj4gQSBuZXcgZnVuY3Rpb24gaXMgYWRkZWQgZ2VtX2luaXRfZW5naW5l X2xpc3QoKSB0aGF0IGlzIGNhbGxlZAo+PiBkdXJpbmcgZGV2aWNlIG9wZW4gd2hpY2ggY3JlYXRl cyB0aGUgbGlzdCBvZiBlbmdpbmVzLiBUaGF0IGxpc3QKPj4gaXMgc3RvcmVkIGluIHRoZSBpbnRl bF9leGVjdXRpb25fZW5naW5lczIgdGhhdCByZXBsYWNlcyB0aGUKPj4gY3VycmVudCBhcnJheSB3 aGljaCBoYXMgbW9yZSBhIHJlZmVyZW5jZSBtZWFuaW5nLiBOb3cgdGhlCj4+IGludGVsX2V4ZWN1 dGlvbl9lbmdpbmVzMiBzdG9yZXMgdGhlIGVuZ2luZXMgY3VycmVudGx5IHByZXNlbnQgaW4KPj4g dGhlIEdQVS4KPj4KPj4gWypdIGdpdDovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmcvfnR1cnN1bGlu L2RybS1pbnRlbAo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRpQGlu dGVsLmNvbT4KPj4gLS0tCj4+ICAgbGliL2RybXRlc3QuYyB8IDEyICsrKysrLS0KPj4gICBsaWIv aWd0X2d0LmMgIHwgOTkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tCj4+ICAgbGliL2lndF9ndC5oICB8IDEwICsrKysrLQo+PiAgIDMgZmlsZXMgY2hh bmdlZCwgMTEwIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0 IGEvbGliL2RybXRlc3QuYyBiL2xpYi9kcm10ZXN0LmMKPj4gaW5kZXggN2MxMjRhYzY2NmVjLi4y ZDE1NWVlYThhMTMgMTAwNjQ0Cj4+IC0tLSBhL2xpYi9kcm10ZXN0LmMKPj4gKysrIGIvbGliL2Ry bXRlc3QuYwo+PiBAQCAtMzAxLDcgKzMwMSw3IEBAIHN0YXRpYyBpbnQgX19vcGVuX2RyaXZlcihj b25zdCBjaGFyICpiYXNlLCBpbnQgb2Zmc2V0LCB1bnNpZ25lZCBpbnQgY2hpcHNldCkKPj4gICAK Pj4gICAgICAgICAgZmQgPSBfX3NlYXJjaF9hbmRfb3BlbihiYXNlLCBvZmZzZXQsIGNoaXBzZXQp Owo+PiAgICAgICAgICBpZiAoZmQgIT0gLTEpCj4+IC0gICAgICAgICAgICAgICByZXR1cm4gZmQ7 Cj4+ICsgICAgICAgICAgICAgICBnb3RvIHNldF9lbmdpbmVzX2FuZF9yZXR1cm47Cj4+ICAgCj4+ ICAgICAgICAgIHB0aHJlYWRfbXV0ZXhfbG9jaygmbXV0ZXgpOwo+PiAgICAgICAgICBmb3IgKGNv bnN0IHN0cnVjdCBtb2R1bGUgKm0gPSBtb2R1bGVzOyBtLT5tb2R1bGU7IG0rKykgewo+PiBAQCAt MzE0LDcgKzMxNCwxNSBAQCBzdGF0aWMgaW50IF9fb3Blbl9kcml2ZXIoY29uc3QgY2hhciAqYmFz ZSwgaW50IG9mZnNldCwgdW5zaWduZWQgaW50IGNoaXBzZXQpCj4+ICAgICAgICAgIH0KPj4gICAg ICAgICAgcHRocmVhZF9tdXRleF91bmxvY2soJm11dGV4KTsKPj4gICAKPj4gLSAgICAgICByZXR1 cm4gX19zZWFyY2hfYW5kX29wZW4oYmFzZSwgb2Zmc2V0LCBjaGlwc2V0KTsKPj4gKyAgICAgICBm ZCA9IF9fc2VhcmNoX2FuZF9vcGVuKGJhc2UsIG9mZnNldCwgY2hpcHNldCk7Cj4+ICsgICAgICAg aWYgKGZkIDwgMCkKPj4gKyAgICAgICAgICAgICAgIHJldHVybiBmZDsKPj4gKwo+PiArc2V0X2Vu Z2luZXNfYW5kX3JldHVybjoKPj4gKyAgICAgICBpZiAoaXNfaTkxNV9kZXZpY2UoZmQpKQo+PiAr ICAgICAgICAgICAgICAgZ2VtX2luaXRfZW5naW5lX2xpc3QoZmQpOwo+IAo+IERvIHdlIHJlYWxs eSB3YW50IG1vcmUgaW1wbGljaXQgYWN0aW9ucyBvbiBvcGVuaW5nIGFuIGZkPwo+IAo+IFdlIGFs cmVhZHkgaGF2ZSBpZ3RfcmVxdWlyZV9nZW0oKSB3aGljaCB3b3VsZCBtYWtlIGFuIGludGVyZXN0 aW5nCj4gc3RhcnRpbmcgcG9pbnQsIGZvciB0aGF0IHdlIG1heSB3YW50IHRvIHVzZSBmZCBub3Qg ZnJvbQo+IGRybV9vcGVuX2RyaXZlcigpLiBIb3dldmVyLCB0aGVyZSBzZWVtcyB0byBiZSBubyBp c3N1ZSB3aXRoIGNyZWF0aW5nIHRoZQo+IG5hbWVzIG9uIHRoZSBmbHkgKGFuZCBhc2sgZm9yIHRo ZSBjb21wbGVtZW50YXJ5IGdldHRlciBmb3IgZW5naW5lc1tdIHNvCj4gdGhhdCBhbiBpbmRleCBj b3VsZCBiZSB0cmFuc2xhdGVkIGJhY2sgdG8gY2xhc3M6aW5zdGFuY2UpLgo+IAo+IENlcnRhaW5s eSBoYXZpbmcgZHJtdGVzdCBwcmVzdW1lIEdFTSAoYW5kIGJlIHN1YmplY3QgdG8gYWxsIG9mIHRo ZSBleHRyYQo+IHJ1bGVzKSBnaXZlbiBpOTE1IHNlZW1zIGEgYml0IHJ1ZGUuCgpNeSBzdWdnZXN0 aW9uIHdhcyB0byBjby1zaXRlIHdpdGggZXhpc3RpbmcgImlzIGk5MTUiIGNvZGUgaW4gCmRybV9v cGVuX2RyaXZlciBhbmQgZHJtX29wZW5fZHJpdmVyX3JlbmRlci4gQnV0IGlndF9yZXF1aXJlX2dl bSBhbHNvIApzb3VuZHMgb2theS4KCkkgZGlkbid0IHVuZGVyc3RhbmQgdGhlIGJpdCBhYm91dCB0 aGUgY29tcGxlbWVudGFyeSBnZXR0ZXIuCgo+IAo+PiArCj4+ICsgICAgICAgcmV0dXJuIGZkOwo+ PiAgIH0KPj4gICAKPj4gICAvKioKPj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZ3QuYyBiL2xpYi9p Z3RfZ3QuYwo+PiBpbmRleCBhMjA2MTkyNDYyOTYuLmFiNzNkNGI0NTA4NyAxMDA2NDQKPj4gLS0t IGEvbGliL2lndF9ndC5jCj4+ICsrKyBiL2xpYi9pZ3RfZ3QuYwo+PiBAQCAtNTc3LDE0ICs1Nzcs NyBAQCBib29sIGdlbV9jYW5fc3RvcmVfZHdvcmQoaW50IGZkLCB1bnNpZ25lZCBpbnQgZW5naW5l KQo+PiAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gICB9Cj4+ICAgCj4+IC1jb25zdCBzdHJ1Y3Qg aW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyW10gPSB7Cj4+ IC0gICAgICAgeyAicmNzMCIsIEk5MTVfRU5HSU5FX0NMQVNTX1JFTkRFUiwgMCB9LAo+PiAtICAg ICAgIHsgImJjczAiLCBJOTE1X0VOR0lORV9DTEFTU19DT1BZLCAwIH0sCj4+IC0gICAgICAgeyAi dmNzMCIsIEk5MTVfRU5HSU5FX0NMQVNTX1ZJREVPLCAwIH0sCj4+IC0gICAgICAgeyAidmNzMSIs IEk5MTVfRU5HSU5FX0NMQVNTX1ZJREVPLCAxIH0sCj4+IC0gICAgICAgeyAidmVjczAiLCBJOTE1 X0VOR0lORV9DTEFTU19WSURFT19FTkhBTkNFLCAwIH0sCj4+IC0gICAgICAgeyB9Cj4+IC19Owo+ PiArc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyIGludGVsX2V4ZWN1dGlvbl9lbmdpbmVz MlszMl0gPSB7IH07CgpJJ2QganVzdCBtYWtlIGl0IGEgcG9pbnRlciwgYm90aCBzaXplIGFuZCBl eHBsaWNpdCBzdGF0aWMgaW5pdGlhbGl6YXRpb24gCnRvIHplcm8gYXJlIG5vdCBuZWVkZWQuCgo+ PiAgIAo+PiAgIHVuc2lnbmVkIGludAo+PiAgIGdlbV9jbGFzc19pbnN0YW5jZV90b19lYl9mbGFn cyhpbnQgZ2VtX2ZkLAo+PiBAQCAtNjUwLDMgKzY0Myw5MyBAQCBib29sIGdlbV9yaW5nX2hhc19w aHlzaWNhbF9lbmdpbmUoaW50IGZkLCB1bnNpZ25lZCByaW5nKQo+PiAgIAo+PiAgICAgICAgICBy ZXR1cm4gZ2VtX2hhc19yaW5nKGZkLCByaW5nKTsKPj4gICB9Cj4+ICsKPj4gK3N0YXRpYyBzdHJ1 Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8gKnF1ZXJ5X2VuZ2luZXMoaW50IGZkKQo+PiAr ewo+PiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9xdWVyeSBxdWVyeSA9IHsgfTsKPj4gKyAgICAg ICBzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfaXRlbSBpdGVtID0geyB9Owo+PiArICAgICAgIHN0cnVj dCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAqcXVlcnlfZW5naW5lczsKPj4gKwo+PiArICAg ICAgIGl0ZW0ucXVlcnlfaWQgPSBEUk1fSTkxNV9RVUVSWV9FTkdJTkVfSU5GTzsKPj4gKyAgICAg ICBxdWVyeS5pdGVtc19wdHIgPSB0b191c2VyX3BvaW50ZXIoJml0ZW0pOwo+PiArICAgICAgIHF1 ZXJ5Lm51bV9pdGVtcyA9IDE7Cj4+ICsKPj4gKyAgICAgICAvKgo+PiArICAgICAgICAqIFRoZSBm aXJzdCBpb2N0bCBpcyBzZW50IHdpdGggaXRlbS5sZW5ndGggPSAwCj4+ICsgICAgICAgICogd2hp Y2ggYXNrcyB0byB0aGUgZHJpdmVyIHRvIHN0b3JlIGluIGxlbmd0aCB0aGUKPj4gKyAgICAgICAg KiBtZW1vcnkgbmVlZGVkIGZvciB0aGUgZW5naW5lcy4gSW4gdGhlIGRyaXZlciwgbGVuZ3RoCj4+ ICsgICAgICAgICogaXMgZXF1YWwgdG8KPj4gKyAgICAgICAgKgo+PiArICAgICAgICAqICAgbGVu ID0gc2l6ZW9mKHN0cnVjdCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbykgKwo+PiArICAgICAg ICAqICAgICAgICAgICAgICAgICAgIElOVEVMX0lORk8oaTkxNSktPm51bV9yaW5ncyAqCj4+ICsg ICAgICAgICogICAgICAgICAgICAgICAgICAgc2l6ZW9mKHN0cnVjdCBkcm1faTkxNV9lbmdpbmVf aW5mbyk7Cj4gCj4gTmFoLCBkbyBub3QgaW1wbHkgeW91IGFyZSB0aWVkIHRvIGltcGxlbWVudGF0 aW9uIGRldGFpbHMgLSB0aGF0IGlzIHRoZQo+IHdob2xlIHBvaW50IG9mIHF1ZXJ5aW5nIHRoZSBs ZW5ndGggZmlyc3QuIERvIG5vdGUgdGhhdCB5b3UgY2FuIG92ZXIKPiBhbGxvY2F0ZSAoc2F5IHVz ZSBhIHNtYWxsIGJpdCBvZiBzdGFjaykgYW5kIGRvIHRoZSBxdWVyeSBpbiBvbmUgc2hvdCwKPiBv bmx5IGFsbG9jYXRpbmcgZnJvbSBoZWFwIGlmIHdlIG5lZWQgbW9yZSByb29tLgo+IAo+PiArICAg ICAgICAqLwo+PiArICAgICAgIGlndF9hc3NlcnQoIWlvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9R VUVSWSwgJnF1ZXJ5KSk7Cj4gCj4gQmFkIG5ld3MgZm9yIG9sZCBrZXJuZWxzLgoKRG8gd2UgY2Fy ZSBhYm91dCBvbGQga2VybmVscz8gSSB0aG91Z2h0IGZvciBJR1Qgd2UgZGlkIG5vdC4KClJlZ2Fy ZHMsCgpUdnJ0a28KCj4gCj4+ICsgICAgICAgaWd0X2Fzc2VydCgocXVlcnlfZW5naW5lcyA9IGNh bGxvYyhpdGVtLmxlbmd0aCwgMSkpKTsKPj4gKyAgICAgICBpdGVtLmRhdGFfcHRyID0gdG9fdXNl cl9wb2ludGVyKHF1ZXJ5X2VuZ2luZXMpOwo+PiArCj4+ICsgICAgICAgLyogVGhlIHNlY29uZCBp b2N0bCBzdG9yZXMgdGhlIGVuZ2luZXMgaW4gcXVlcnlfZW5naW5lcyAqLwo+PiArICAgICAgIGln dF9hc3NlcnQoIWlvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9RVUVSWSwgJnF1ZXJ5KSk7Cj4+ICsK Pj4gKyAgICAgICByZXR1cm4gcXVlcnlfZW5naW5lczsKPj4gK30KPj4gKwo+PiArdm9pZCBfX3Nl dF9jdHhfZW5naW5lX21hcChpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCkKPj4gK3sKPj4gKyAgICAg ICBpbnQgaTsKPj4gKyAgICAgICB1bnNpZ25lZCBjaGFyIG47Cj4+ICsgICAgICAgc3RydWN0IGRy bV9pOTE1X2dlbV9jb250ZXh0X3BhcmFtIGN0eF9wYXJhbTsKPj4gKyAgICAgICBzdHJ1Y3QgaTkx NV9jb250ZXh0X3BhcmFtX2VuZ2luZXMgKmN0eF9lbmdpbmU7Cj4+ICsgICAgICAgc2l6ZV90IHNp emU7Cj4+ICsKPj4gKyAgICAgICBmb3IgKG4gPSAwOyBpbnRlbF9leGVjdXRpb25fZW5naW5lczJb bl0ubmFtZTsgbisrKTsKPiAKPiBDbG9zZSB5b3VyIGV5ZXMgYW5kIHRlbGwgbWUgd2hlcmUgdGhl ICc7JyBpcy4KPiAKPj4gKyAgICAgICBzaXplID0gc2l6ZW9mKHN0cnVjdCBpOTE1X2NvbnRleHRf cGFyYW1fZW5naW5lcykgKwo+PiArICAgICAgICAgICAgICAgICAgICAgKG4gKyAxKSAqIHNpemVv ZigqY3R4X2VuZ2luZS0+Y2xhc3NfaW5zdGFuY2UpOwo+IAo+IFNob3VsZCBiZSBzbWFsbCBlbm91 Z2ggZm9yIGEgc3RhY2sgYWxsb2NhdGlvbnMgb2Ygc2F5IDY0IGVuZ2luZXMgKHRoZQo+IGxpbWl0 IG9mIHRoZSBjdXJyZW50IGV4ZWNidWYgdWFiaSkuCj4gCj4+ICsgICAgICAgaWd0X2Fzc2VydCgo Y3R4X2VuZ2luZSA9IG1hbGxvYyhzaXplKSkpOwo+PiArCj4+ICsgICAgICAgY3R4X2VuZ2luZS0+ ZXh0ZW5zaW9ucyA9IDA7Cj4+ICsgICAgICAgZm9yIChpID0gMDsgaSA8PSBuOyBpKyspIHsKPj4g KyAgICAgICAgICAgICAgIGN0eF9lbmdpbmUtPmNsYXNzX2luc3RhbmNlW2ldLmNsYXNzID0KPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludGVsX2V4ZWN1dGlvbl9l bmdpbmVzMltpXS5jbGFzczsKPj4gKyAgICAgICAgICAgICAgIGN0eF9lbmdpbmUtPmNsYXNzX2lu c3RhbmNlW2ldLmluc3RhbmNlID0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMltpXS5pbnN0YW5jZTsKPj4gKyAgICAgICB9 Cj4+ICsKPj4gKyAgICAgICBjdHhfcGFyYW0uY3R4X2lkID0gY3R4X2lkOwo+PiArICAgICAgIGN0 eF9wYXJhbS5zaXplID0gc2l6ZTsKPj4gKyAgICAgICBjdHhfcGFyYW0ucGFyYW0gPSBJOTE1X0NP TlRFWFRfUEFSQU1fRU5HSU5FUzsKPj4gKyAgICAgICBjdHhfcGFyYW0udmFsdWUgPSB0b191c2Vy X3BvaW50ZXIoY3R4X2VuZ2luZSk7Cj4+ICsKPj4gKyAgICAgICBpZ3RfYXNzZXJ0KCFpb2N0bChm ZCwgRFJNX0lPQ1RMX0k5MTVfR0VNX0NPTlRFWFRfU0VUUEFSQU0sICZjdHhfcGFyYW0pKTsKPiAK PiBEbyB5b3UgcmVhbGx5IHdhbnQgdG8gcmlzayB0aGF0IHRoaXMgd29uJ3QgYmUgaW50ZXJydXB0 ZWQgYnkgYSBzaWduYWwgYXQKPiBhbnkgcG9pbnQgaW4gdGhlIGZ1dHVyZT8KPiAKPj4gKwo+PiAr ICAgICAgIGZyZWUoY3R4X2VuZ2luZSk7Cj4+ICt9Cj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaWd0LWRldgo=