Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: "Garg, Nemesa" <nemesa.garg@intel.com>, igt-dev@lists.freedesktop.org
Cc: Garg@freedesktop.org
Subject: Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Reducing the IOCTL(drm_mode_cursor_ioctl) calls by reducing the timeout.
Date: Thu, 15 Jun 2023 18:31:05 +0300	[thread overview]
Message-ID: <610aee85-ee0e-3c05-d989-070fc6c24acc@gmail.com> (raw)
In-Reply-To: <20230615123654.1672601-1-nemesa.garg@intel.com>

I agree, I don't see any reason why this test execution couldn't be made 
shorter this way.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 15.6.2023 15.36, Garg, Nemesa wrote:
> Due to excessive IOCTL calls in a stress test we are getting
> disk limit issue. Hence by reducing the timeout from 20 to 5
> the IOCTL call will get reduced.
> 
> Checked with different values and found 5 as optimal value.
> 
> Signed-off-by: Garg, Nemesa <nemesa.garg@intel.com>
> ---
>   tests/kms_cursor_legacy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index f1e55906..13918345 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1562,12 +1562,12 @@ igt_main
>   					errno = 0;
>   
>   					igt_dynamic_f("pipe-%s", kmstest_pipe_name(n))
> -						stress(&display, n, tests[i].ncpus, tests[i].flags, 20);
> +						stress(&display, n, tests[i].ncpus, tests[i].flags, 5);
>   				}
>   
>   				errno = 0;
>   				igt_dynamic("all-pipes")
> -					stress(&display, -1, tests[i].ncpus, tests[i].flags, 20);
> +					stress(&display, -1, tests[i].ncpus, tests[i].flags, 5);
>   			}
>   		}
>   	}

  reply	other threads:[~2023-06-15 15:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 12:36 [igt-dev] [PATCH] tests/kms_cursor_legacy: Reducing the IOCTL(drm_mode_cursor_ioctl) calls by reducing the timeout Garg, Nemesa
2023-06-15 15:31 ` Juha-Pekka Heikkila [this message]
2023-06-15 16:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-06-16 12:34   ` Kamil Konieczny
2023-06-20  8:07     ` Yedireswarapu, SaiX Nandan
2023-06-16 12:37 ` [igt-dev] [PATCH] " Kamil Konieczny
2023-06-17  9:59   ` Garg, Nemesa
2023-06-20  7:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-06-20  8:42 ` Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-06-17  9:54 [igt-dev] [PATCH] " Garg, Nemesa
2023-06-19  6:03 ` Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=610aee85-ee0e-3c05-d989-070fc6c24acc@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=Garg@freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=nemesa.garg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox