From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [i-g-t,2/3] lib/kms: Simplify force_connectors[] error handling
Date: Thu, 11 Apr 2024 11:45:57 +0530 [thread overview]
Message-ID: <61c3379d-3ad6-41ea-90d1-7914eda2823b@intel.com> (raw)
In-Reply-To: <20240410150229.28922-2-ville.syrjala@linux.intel.com>
On 4/10/2024 8:32 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The failure to allocate a forced_connector entry is entirely
> our own fault. If we hit this then we've screwd up and made
> the array too small. Skip the error handling and just assert
> that we must have enough room in the array.
>
> Cc: Kunal Joshi <kunal1.joshi@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
LGTM
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
next prev parent reply other threads:[~2024-04-11 6:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 15:02 [PATCH i-g-t 1/3] lib/kms: Introduce struct igt_forced_connector Ville Syrjala
2024-04-10 15:02 ` [PATCH i-g-t 2/3] lib/kms: Simplify force_connectors[] error handling Ville Syrjala
2024-04-11 6:15 ` Joshi, Kunal1 [this message]
2024-04-11 8:25 ` Kamil Konieczny
2024-04-11 13:23 ` Ville Syrjälä
2024-04-10 15:02 ` [PATCH i-g-t 3/3] lib/kms: Generalize forced_connectors[] to handle arbitrary attributes Ville Syrjala
2024-04-11 7:47 ` [i-g-t,3/3] " Joshi, Kunal1
2024-04-11 14:51 ` Ville Syrjälä
2024-04-10 23:56 ` ✗ CI.xeBAT: failure for series starting with [i-g-t,1/3] lib/kms: Introduce struct igt_forced_connector Patchwork
2024-04-11 0:17 ` ✗ Fi.CI.BAT: " Patchwork
2024-04-11 6:14 ` Joshi, Kunal1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c3379d-3ad6-41ea-90d1-7914eda2823b@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox