Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kahola, Mika" <mika.kahola@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: Don't fill small fb during test setup
Date: Fri, 22 Apr 2022 11:44:28 +0000	[thread overview]
Message-ID: <638d5a2c162d48a8805796667b744cd0@intel.com> (raw)
In-Reply-To: <20220407183733.7329-2-juhapekka.heikkila@gmail.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Juha-
> Pekka Heikkila
> Sent: Thursday, April 7, 2022 9:38 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: Don't fill small fb
> during test setup
> 
> Change small fb not to be filled with green color, this will never show anywhere
> and just take time while setting up test.
> 

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/i915/kms_big_fb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c index
> b7bcc3401..7a8504017 100644
> --- a/tests/i915/kms_big_fb.c
> +++ b/tests/i915/kms_big_fb.c
> @@ -420,9 +420,8 @@ static bool test_pipe(data_t *data)
>  	if (igt_rotation_90_or_270(data->rotation))
>  		igt_swap(width, height);
> 
> -	igt_create_color_fb(data->drm_fd, width, height,
> -			    data->format, data->modifier,
> -			    0, 1, 0, &data->small_fb);
> +	igt_create_fb(data->drm_fd, width, height,
> +		      data->format, data->modifier, &data->small_fb);
> 
>  	igt_output_set_pipe(data->output, data->pipe);
> 
> --
> 2.28.0


  reply	other threads:[~2022-04-22 11:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 18:37 [igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit Juha-Pekka Heikkila
2022-04-07 18:37 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: Don't fill small fb during test setup Juha-Pekka Heikkila
2022-04-22 11:44   ` Kahola, Mika [this message]
2022-04-07 19:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit Patchwork
2022-04-07 21:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev2) Patchwork
2022-04-08 17:18 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev3) Patchwork
2022-04-11 20:48 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev4) Patchwork
2022-04-11 21:12 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2022-04-12  7:11   ` Juha-Pekka Heikkila
2022-04-12 14:58     ` Vudum, Lakshminarayana
2022-04-12 14:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-04-12 16:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-04-22  8:17 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit (rev5) Patchwork
2022-04-22 10:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-04-22 11:44 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit Kahola, Mika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=638d5a2c162d48a8805796667b744cd0@intel.com \
    --to=mika.kahola@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox