From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 243BD10EB8C for ; Fri, 30 Sep 2022 06:26:46 +0000 (UTC) Message-ID: <6396675b-d415-ad06-91d1-a9da57a2c390@intel.com> Date: Fri, 30 Sep 2022 11:56:30 +0530 Content-Language: en-US To: Bhanuprakash Modem , References: <20220922160004.2041598-1-bhanuprakash.modem@intel.com> <20220922160004.2041598-31-bhanuprakash.modem@intel.com> From: "Thasleem, Mohammed" In-Reply-To: <20220922160004.2041598-31-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t V4 30/52] tests/kms_rmfb: Add support for Bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 9/22/2022 9:29 PM, Bhanuprakash Modem wrote: > This patch will add a check to Skip the subtest if a selected pipe/output > combo won't support Bigjoiner or 8K mode. > > Example: > * Pipe-D wont support a mode > 5K > * To use 8K mode on a pipe then consecutive pipe must be available & free. > > V2: - Use updated helper name > > Signed-off-by: Bhanuprakash Modem > --- > tests/kms_rmfb.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c > index 7e43e1bd..50df4295 100644 > --- a/tests/kms_rmfb.c > +++ b/tests/kms_rmfb.c > @@ -155,8 +155,15 @@ run_rmfb_test(struct rmfb_data *data, bool reopen) > { > igt_output_t *output; > enum pipe pipe; > + igt_display_t *display = &data->display; > + > + for_each_pipe_with_single_output(display, pipe, output) { > + igt_display_reset(display); > + > + igt_output_set_pipe(output, pipe); > + if (!i915_pipe_output_combo_valid(display)) > + continue; > > - for_each_pipe_with_single_output(&data->display, pipe, output) { > igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), > igt_output_name(output)) > test_rmfb(data, output, pipe, reopen); > @@ -192,7 +199,6 @@ igt_main > igt_describe(tests[i].description); > igt_subtest_with_dynamic(tests[i].name) { > run_rmfb_test(&data, tests[i].reopen); > - > } > } > Reviewed-by: Mohammed Thasleem