Re: [igt-dev] [PATCH i-g-t] lib/igt_params: Fix verifying of debugfs parameters

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

On 19.5.2020 14.00, Petri Latvala wrote:
> On Tue, May 19, 2020 at 01:54:08PM +0300, Juha-Pekka Heikkila wrote:
>> After found correct place in debugfs for parameters there
>> was used wrong path for verifying existence of parameter
>> which caused fallback path to be used.
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>>   lib/igt_params.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/igt_params.c b/lib/igt_params.c
>> index d8649dfd..410ca650 100644
>> --- a/lib/igt_params.c
>> +++ b/lib/igt_params.c
>> @@ -143,14 +143,14 @@ static int __igt_params_open(int device, char **outpath, const char *param)
>>   
>>   		devname = openat(dir, "name", O_RDONLY);
>>   		igt_require_f(devname >= 0,
>> -		              "Driver need to name itself in debugfs!");
>> +			      "Driver need to name itself in debugfs!");
>>   
>>   		read(devname, searchname, sizeof(searchname));
>>   		close(devname);
>>   
>>   		foundname = strtok_r(searchname, " ", &ctx);
>>   		igt_require_f(foundname,
>> -		              "Driver need to name itself in debugfs!");
>> +			      "Driver need to name itself in debugfs!");
> 
> 
> While changing whitespace here, also add the missing \n to the string!
> 
> But do take a look at Chris's cleanup patches.

Chris seems to be removing default device guesswork. I didn't at initial 
stage want to go that route because there was quite many tests affected 
by that. From Chris's CI runs it look like there's probably still few 
rounds ahead as I recognize those failing tests. I'll add those couple 
of newlines and make new patch, this will not affect Chris's work if it 
take time for him to finish.

/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev