Re: [igt-dev] [PATCH i-g-t 1/2] tests/fbdev: Add debug traces to subtest pan

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2942 bytes --]



Am 05.11.21 um 11:54 schrieb Petri Latvala:
> This helps debugging
> https://gitlab.freedesktop.org/drm/intel/-/issues/4435
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   tests/fbdev.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/fbdev.c b/tests/fbdev.c
> index 7a2a5c4e..794882a6 100644
> --- a/tests/fbdev.c
> +++ b/tests/fbdev.c
> @@ -139,15 +139,15 @@ static void mode_tests(int fd)
>   		 * Tests that are expected to succeed.
>   		 */
>   
> -		/* jump to opposite end of virtual screen */
> +		igt_debug("Jump to opposite end of virtual screen\n");
>   		pan_var.xoffset = XOFFSET(var_info.xres_virtual - var_info.xres - var_info.xoffset);
>   		pan_var.yoffset = YOFFSET(var_info.yres_virtual - var_info.yres - var_info.yoffset);
>   		pan_test(fd, &pan_var, 0);
> -		/* jump to (0, 0) */
> +		igt_debug("Jump to (0, 0)\n");
>   		pan_var.xoffset = XOFFSET(0);
>   		pan_var.yoffset = YOFFSET(0);
>   		pan_test(fd, &pan_var, 0);
> -		/* jump to maximum extend */
> +		igt_debug("Jump to maximum extend\n");
>   		pan_var.xoffset = XOFFSET(var_info.xres_virtual - var_info.xres);
>   		pan_var.yoffset = YOFFSET(var_info.yres_virtual - var_info.yres);
>   		pan_test(fd, &pan_var, 0);
> @@ -156,11 +156,11 @@ static void mode_tests(int fd)
>   		 * Tests that are expected to fail.
>   		 */
>   
> -		/* jump beyond maximum horizontal extend */
> +		igt_debug("Jump beyond maximum horizontal extend\n");
>   		pan_var.xoffset = XOFFSET(var_info.xres_virtual - var_info.xres + PANSTEP(fix_info.xpanstep));
>   		pan_var.yoffset = YOFFSET(0);
>   		pan_test(fd, &pan_var, -1);
> -		/* jump beyond horizontal virtual resolution */
> +		igt_debug("Jump beyond horizontal virtual resolution\n");
>   		pan_var.xoffset = XOFFSET(var_info.xres_virtual);
>   		pan_var.yoffset = YOFFSET(0);
>   		pan_test(fd, &pan_var, -1);
> @@ -184,11 +184,11 @@ static void mode_tests(int fd)
>   			expected_ret = -1;
>   		}
>   
> -		/* jump beyond maximum vertical extend */
> +		igt_debug("Jump beyond maximum vertical extend\n");
>   		pan_var.xoffset = XOFFSET(0);
>   		pan_var.yoffset = YOFFSET(var_info.yres_virtual - var_info.yres + PANSTEP(fix_info.ypanstep));
>   		pan_test(fd, &pan_var, expected_ret);
> -		/* jump beyond vertical virtual resolution */
> +		igt_debug("Jump beyond vertical virtual resolution\n");
>   		pan_var.xoffset = XOFFSET(0);
>   		pan_var.yoffset = YOFFSET(var_info.yres_virtual);
>   		pan_test(fd, &pan_var, expected_ret);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]