From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1295C10E079 for ; Tue, 4 Jul 2023 06:01:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------XHVkvcKP3fTU0hWf1dQVgi8n" Message-ID: <63f3bd6e-7a02-57b4-9b8c-0c5e4adfbf55@intel.com> Date: Tue, 4 Jul 2023 11:31:11 +0530 To: , References: <20230704052717.664717-1-priyanka.dandamudi@intel.com> Content-Language: en-US From: "Bommu, Krishnaiah" In-Reply-To: <20230704052717.664717-1-priyanka.dandamudi@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] xe/xe_mmap: Optimise code to use xe_bo_mmap List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: --------------XHVkvcKP3fTU0hWf1dQVgi8n Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 04-07-2023 10:57, priyanka.dandamudi@intel.com wrote: > From: Priyanka Dandamudi > > Optimise code to use xe_bo_mmap. > > Cc: Bommu Krishnaiah > Signed-off-by: Priyanka Dandamudi > --- > tests/xe/xe_mmap.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c > index 664ed54fc..7fe8f73a4 100644 > --- a/tests/xe/xe_mmap.c > +++ b/tests/xe/xe_mmap.c > @@ -46,11 +46,8 @@ test_mmap(int fd, uint32_t flags) > igt_require_f(flags, "Device doesn't support such memory region\n"); > > bo = xe_bo_create_flags(fd, 0, 4096, flags); > - mmo = xe_bo_mmap_offset(fd, bo); > - > - map = mmap(NULL, 4096, PROT_WRITE, MAP_SHARED, fd, mmo); > - igt_assert(map != MAP_FAILED); > > + map = xe_bo_map(fd, bo, 4096); > strcpy(map, "Write some data to the BO!"); > > munmap(map, 4096); Changes looks good to me Reviewed-by: Bommu Krishnaiah krishnaiah.bommu@intel.com --------------XHVkvcKP3fTU0hWf1dQVgi8n Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit

On 04-07-2023 10:57, priyanka.dandamudi@intel.com wrote:

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Optimise code to use xe_bo_mmap.

Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/xe/xe_mmap.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/xe/xe_mmap.c b/tests/xe/xe_mmap.c
index 664ed54fc..7fe8f73a4 100644
--- a/tests/xe/xe_mmap.c
+++ b/tests/xe/xe_mmap.c
@@ -46,11 +46,8 @@ test_mmap(int fd, uint32_t flags)
 	igt_require_f(flags, "Device doesn't support such memory region\n");
 
 	bo = xe_bo_create_flags(fd, 0, 4096, flags);
-	mmo = xe_bo_mmap_offset(fd, bo);
-
-	map = mmap(NULL, 4096, PROT_WRITE, MAP_SHARED, fd, mmo);
-	igt_assert(map != MAP_FAILED);
 
+	map = xe_bo_map(fd, bo, 4096);
 	strcpy(map, "Write some data to the BO!");
 
 	munmap(map, 4096);

Changes looks good to me

Reviewed-by: Bommu Krishnaiah krishnaiah.bommu@intel.com

--------------XHVkvcKP3fTU0hWf1dQVgi8n--