From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Martin Peres <martin.peres@free.fr>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors
Date: Thu, 14 Mar 2019 15:35:39 -0700 [thread overview]
Message-ID: <6475bd683dc97972715cbc1c48996ef212cc5ffb.camel@intel.com> (raw)
In-Reply-To: <20190314110305.28903-1-arkadiusz.hiler@intel.com>
On Thu, 2019-03-14 at 13:03 +0200, Arkadiusz Hiler wrote:
> Currently we are printing one igt_warn for each CRC mismatch, which
> gets
> quite overwhelming with having to see the same error 8 times for each
> color tested:
>
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
> WARNING: CRC mismatch with format NV12 (0x3231564e) on A.3
>
> Since the most interesting information here is which format on which
> pipe/plane is broken we can skip igt_warn just once.
>
> For those weirder and rarer case where just certain colors would fail
> we
> still provide the count:
IMO it's better to have all the information in the logs, particularly
for those 'weirder and rare cases, which are hard to reproduce. And
don't see how count is useful. I think, we should be even logging the
RGB values for the mismatching cases.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-14 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 11:03 [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane: Print count of mismatched colors Arkadiusz Hiler
2019-03-14 11:03 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane: Use just one valid output Arkadiusz Hiler
2019-03-14 12:19 ` Maarten Lankhorst
2019-03-14 12:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane: Print count of mismatched colors Patchwork
2019-03-14 13:07 ` [igt-dev] [PATCH i-g-t 1/2] " Martin Peres
2019-03-14 19:41 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork
2019-03-14 22:35 ` Dhinakaran Pandiyan [this message]
2019-03-15 11:56 ` [igt-dev] [PATCH i-g-t 1/2] " Martin Peres
2019-03-15 19:41 ` Dhinakaran Pandiyan
2019-03-18 10:48 ` Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2019-03-15 12:53 Petri Latvala
2019-03-19 3:26 ` Dhinakaran Pandiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6475bd683dc97972715cbc1c48996ef212cc5ffb.camel@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox