From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A92D86E1E4 for ; Thu, 20 Sep 2018 17:59:52 +0000 (UTC) From: "Souza, Jose" Date: Thu, 20 Sep 2018 17:59:51 +0000 Message-ID: <64da4316bbdcbfd9e48834e52178b0b30e772fc7.camel@intel.com> References: <20180918221531.18233-1-jose.souza@intel.com> <20180918221531.18233-3-jose.souza@intel.com> <60b123cda1ca05aed84c8963d6d7822c36b6bdf8.camel@intel.com> In-Reply-To: <60b123cda1ca05aed84c8963d6d7822c36b6bdf8.camel@intel.com> Content-Language: en-US Content-ID: <95C4D058FD8FB64F8E6CC58147339D7C@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/3] test/kms_fbcon_fbt: Give a explicit parameter name to functions that expect debugfs fd List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Pandiyan, Dhinakaran" List-ID: T24gV2VkLCAyMDE4LTA5LTE5IGF0IDIxOjU5IC0wNzAwLCBQYW5kaXlhbiwgRGhpbmFrYXJhbiB3 cm90ZToNCj4gT24gVHVlLCAyMDE4LTA5LTE4IGF0IDE1OjE1IC0wNzAwLCBKb3PDqSBSb2JlcnRv IGRlIFNvdXphIHdyb3RlOg0KPiA+IExldCdzIHJlbmFtZSB0byBkZWJ1Z2ZzX2ZkIGFsbCB0aGUg cGFyYW1ldGVycyBvZiB0aGUgZnVuY3Rpb25zIHRoYXQNCj4gPiBleHBlY3QgZGVidWdmcyBmZCB0 byBhdm9pZCBjYWxsIG9uZSB0aG9zZSBmdW5jdGlvbnMgd2l0aCB0aGUgd3JvbmcNCj4gPiBmaWxl IGRlc2NyaXB0b3IuDQo+IA0KPiBJIHdhcyBhYm91dCB0byBtZXJnZSB0aGUgc2VyaWVzIGJ1dCBu b3RpY2VkDQo+IGZiY193YWl0X3VudGlsX2VuYWJsZWQoaW50DQo+IGZkKSB3YXMgbWlzc2VkLg0K PiANCj4gQ2FuIHlvdSBwbGVhc2UgZml4IHRoYXQgYWxvbmcgd2l0aCB0d28gb3RoZXIgY2hlY2tw YXRjaCBlcnJvcnMgdGhhdA0KPiB0aGUNCj4gc2VyaWVzIGhhcz8NCg0KRG9uZQ0KDQo+IA0KPiBX QVJOSU5HOiBsaW5lIG92ZXIgODAgY2hhcmFjdGVycw0KPiAjNTY6IEZJTEU6IHRlc3RzL2ttc19m cm9udGJ1ZmZlcl90cmFja2luZy5jOjE2MzQ6DQo+ICsgICAgICAgICAgICAgICBpZ3RfYXNzZXJ0 X2YocHNyX3dhaXRfZW50cnkoZHJtLmRlYnVnZnMpLCAiUFNSIHN0aWxsDQo+IGRpc2FibGVkXG4i KTsNCj4gDQo+IA0KPiBXQVJOSU5HOiBNaXNzaW5nIGEgYmxhbmsgbGluZSBhZnRlciBkZWNsYXJh dGlvbnMNCj4gIzM1OiBGSUxFOiB0ZXN0cy9rbXNfZmJjb25fZmJ0LmM6MjA5Og0KPiArICAgICAg IGJvb2wgciA9IGlndF93YWl0KHBzcl9pc19lbmFibGVkKGRlYnVnZnNfZmQpLCA1MDAwLCAxKTsN Cj4gKyAgICAgICBwc3JfcHJpbnRfc3RhdHVzKGRlYnVnZnNfZmQpOw0KPiANCj4gDQo+IC1ESw0K PiANCj4gPiANCj4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlh bkBpbnRlbC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8 am9zZS5zb3V6YUBpbnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIHRlc3RzL2ttc19mYmNvbl9mYnQu YyB8IDIyICsrKysrKysrKysrLS0tLS0tLS0tLS0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDExIGlu c2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS90ZXN0 cy9rbXNfZmJjb25fZmJ0LmMgYi90ZXN0cy9rbXNfZmJjb25fZmJ0LmMNCj4gPiBpbmRleCAxMzhl ZGE5Yi4uOTg2OWFhMTQgMTAwNjQ0DQo+ID4gLS0tIGEvdGVzdHMva21zX2ZiY29uX2ZidC5jDQo+ ID4gKysrIGIvdGVzdHMva21zX2ZiY29uX2ZidC5jDQo+ID4gQEAgLTIwMywzNCArMjAzLDM0IEBA IHN0YXRpYyBib29sIHBzcl9pc19lbmFibGVkKGludCBkZWJ1Z2ZzX2ZkKQ0KPiA+ICAJcmV0dXJu IHN0cnN0cihidWYsICJcbkhXIEVuYWJsZWQgJiBBY3RpdmUgYml0OiB5ZXNcbiIpOw0KPiA+ICB9 DQo+ID4gIA0KPiA+IC1zdGF0aWMgYm9vbCBwc3Jfd2FpdF91bnRpbF9lbmFibGVkKGludCBmZCkN Cj4gPiArc3RhdGljIGJvb2wgcHNyX3dhaXRfdW50aWxfZW5hYmxlZChpbnQgZGVidWdmc19mZCkN Cj4gPiAgew0KPiA+IC0JYm9vbCByID0gaWd0X3dhaXQocHNyX2lzX2VuYWJsZWQoZmQpLCA1MDAw LCAxKTsNCj4gPiAtCXBzcl9wcmludF9zdGF0dXMoZmQpOw0KPiA+ICsJYm9vbCByID0gaWd0X3dh aXQocHNyX2lzX2VuYWJsZWQoZGVidWdmc19mZCksIDUwMDAsIDEpOw0KPiA+ICsJcHNyX3ByaW50 X3N0YXR1cyhkZWJ1Z2ZzX2ZkKTsNCj4gPiAgCXJldHVybiByOw0KPiA+ICB9DQo+ID4gIA0KPiA+ IC1zdGF0aWMgdm9pZCBkaXNhYmxlX2ZlYXR1cmVzKGludCBmZCkNCj4gPiArc3RhdGljIHZvaWQg ZGlzYWJsZV9mZWF0dXJlcyhpbnQgZGVidWdmc19mZCkNCj4gPiAgew0KPiA+ICAJaWd0X3NldF9t b2R1bGVfcGFyYW1faW50KCJlbmFibGVfZmJjIiwgMCk7DQo+ID4gLQlwc3JfZGlzYWJsZShmZCk7 DQo+ID4gKwlwc3JfZGlzYWJsZShkZWJ1Z2ZzX2ZkKTsNCj4gPiAgfQ0KPiA+ICANCj4gPiAtc3Rh dGljIGlubGluZSB2b2lkIGZiY19tb2RwYXJhbV9lbmFibGUoaW50IGZkKQ0KPiA+ICtzdGF0aWMg aW5saW5lIHZvaWQgZmJjX21vZHBhcmFtX2VuYWJsZShpbnQgZGVidWdmc19mZCkNCj4gPiAgew0K PiA+ICAJaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJlbmFibGVfZmJjIiwgMSk7DQo+ID4gIH0N Cj4gPiAgDQo+ID4gLXN0YXRpYyBpbmxpbmUgdm9pZCBwc3JfZGVidWdmc19lbmFibGUoaW50IGZk KQ0KPiA+ICtzdGF0aWMgaW5saW5lIHZvaWQgcHNyX2RlYnVnZnNfZW5hYmxlKGludCBkZWJ1Z2Zz X2ZkKQ0KPiA+ICB7DQo+ID4gLQlwc3JfZW5hYmxlKGZkKTsNCj4gPiArCXBzcl9lbmFibGUoZGVi dWdmc19mZCk7DQo+ID4gIH0NCj4gPiAgDQo+ID4gIHN0cnVjdCBmZWF0dXJlIHsNCj4gPiAtCWJv b2wgKCpzdXBwb3J0ZWRfb25fY2hpcHNldCkoaW50IGZkKTsNCj4gPiAtCWJvb2wgKCp3YWl0X3Vu dGlsX2VuYWJsZWQpKGludCBmZCk7DQo+ID4gKwlib29sICgqc3VwcG9ydGVkX29uX2NoaXBzZXQp KGludCBkZWJ1Z2ZzX2ZkKTsNCj4gPiArCWJvb2wgKCp3YWl0X3VudGlsX2VuYWJsZWQpKGludCBk ZWJ1Z2ZzX2ZkKTsNCj4gPiAgCWJvb2wgKCpjb25uZWN0b3JfcG9zc2libGVfZm4pKGRybU1vZGVD b25uZWN0b3JQdHINCj4gPiBjb25uZWN0b3IpOw0KPiA+IC0Jdm9pZCAoKmVuYWJsZSkoaW50IGZk KTsNCj4gPiArCXZvaWQgKCplbmFibGUpKGludCBkZWJ1Z2ZzX2ZkKTsNCj4gPiAgfSBmYmMgPSB7 DQo+ID4gIAkuc3VwcG9ydGVkX29uX2NoaXBzZXQgPSBmYmNfc3VwcG9ydGVkX29uX2NoaXBzZXQs DQo+ID4gIAkud2FpdF91bnRpbF9lbmFibGVkID0gZmJjX3dhaXRfdW50aWxfZW5hYmxlZCwNCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFp bGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=