Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Belgaumkar, Vinay" <vinay.belgaumkar@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: matthew.d.roper@intel.com, rodrigo.vivi@intel.com
Subject: Re: [PATCH i-g-t 1/2] tests/intel/xe_gt_freq: Fix freq_low_max test
Date: Fri, 19 Jan 2024 16:56:20 -0800	[thread overview]
Message-ID: <64e5eae0-3f78-43f3-807f-5f3423b17ab3@intel.com> (raw)
In-Reply-To: <20240119170448.1889777-2-badal.nilawar@intel.com>


On 1/19/2024 9:04 AM, Badal Nilawar wrote:
> freq_low_max test is intended to validate GuC PC (SLPC) behaviour
> when max freq set to less than min freq. As workloads are not being
> run validating cur freq is enough.
>
> v2: Validate act freq as well when gt is not in C6 (Vinay)
>
> Fixes: acaaca0bf317 ("tests/xe: Add Xe IGT tests")
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   tests/intel/xe_gt_freq.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index 4334a8a41..bf63e4298 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -263,7 +263,9 @@ static void test_freq_low_max(int fd, int gt_id)
>   	igt_assert(set_freq(fd, gt_id, "max", rpn) > 0);
>   	usleep(ACT_FREQ_LATENCY_US);
>   	igt_assert(get_freq(fd, gt_id, "cur") == rpe);
> -	igt_assert(get_freq(fd, gt_id, "act") == rpe);
> +
> +	if (!xe_is_gt_in_c6(fd, gt_id))
> +		igt_assert(get_freq(fd, gt_id, "act") == rpe);
Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>   }
>   
>   /**

  reply	other threads:[~2024-01-20  0:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 17:04 [PATCH i-g-t 0/2] Couple of fixes to guc_pc tests Badal Nilawar
2024-01-19 17:04 ` [PATCH i-g-t 1/2] tests/intel/xe_gt_freq: Fix freq_low_max test Badal Nilawar
2024-01-20  0:56   ` Belgaumkar, Vinay [this message]
2024-01-19 17:04 ` [PATCH i-g-t 2/2] tests/intel/xe_gt_freq: Skip GuC PC tests if GuC PC not supported Badal Nilawar
2024-01-20  1:26   ` Belgaumkar, Vinay
2024-01-19 18:18 ` ✓ CI.xeBAT: success for Couple of fixes to guc_pc tests (rev3) Patchwork
2024-01-19 18:31 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64e5eae0-3f78-43f3-807f-5f3423b17ab3@intel.com \
    --to=vinay.belgaumkar@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox