From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B0BC6E6D3 for ; Tue, 5 Feb 2019 12:53:19 +0000 (UTC) Message-ID: <65514566511c64a97279ba75585c7dd271b78fc7.camel@bootlin.com> From: Paul Kocialkowski Date: Tue, 05 Feb 2019 13:53:16 +0100 In-Reply-To: <20190125145842.15738-5-maxime.ripard@bootlin.com> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-5-maxime.ripard@bootlin.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , eben@raspberrypi.org, Thomas Petazzoni List-ID: SGksCgpPbiBGcmksIDIwMTktMDEtMjUgYXQgMTU6NTggKzAxMDAsIE1heGltZSBSaXBhcmQgd3Jv dGU6Cj4gVGhlIFlVViBidWZmZXIgYWxsb2NhdGlvbiBwYXRoIGZvciB0aGUgaTkxNSBkcml2ZXIg YWxzbyBoYXMgc29tZSBjb2RlIHRvCj4gY2xlYXIgYSBZVVYgYnVmZmVyLgo+IAo+IEFzIHRoYXQg aXMgZ29pbmcgdG8gYmUgdXNlZnVsIGZvciBhbGwgdGhlIG90aGVyIGRyaXZlcnMsIGxldCdzIG1v dmUgaXQgdG8KPiBhIHNlcGFyYXRlIGZ1bmN0aW9uLgoKUHVzaGVkLCB0aGFua3MhCgpDaGVlcnMs CgpQYXVsCgo+IFJldmlld2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dz a2lAYm9vdGxpbi5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJp cGFyZEBib290bGluLmNvbT4KPiAtLS0KPiAgbGliL2lndF9mYi5jIHwgODAgKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgNDIgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2xp Yi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDQ1NjkxZmQ0NDFkOS4uZDY5YzNmYjJk MzhkIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+IEBA IC00ODQsNiArNDg0LDQ3IEBAIHVpbnQ2NF90IGlndF9mYl90aWxpbmdfdG9fbW9kKHVpbnQ2NF90 IHRpbGluZykKPiAgCX0KPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgY2xlYXJfeXV2X2J1ZmZlcihz dHJ1Y3QgaWd0X2ZiICpmYikKPiArewo+ICsJYm9vbCBmdWxsX3JhbmdlID0gZmItPmNvbG9yX3Jh bmdlID09IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JBTkdFOwo+ICsJdm9pZCAqcHRyOwo+ICsKPiAr CWlndF9hc3NlcnQoaWd0X2Zvcm1hdF9pc195dXYoZmItPmRybV9mb3JtYXQpKTsKPiArCj4gKwkv KiBFbnN1cmUgdGhlIGZyYW1lYnVmZmVyIGlzIHByZWFsbG9jYXRlZCAqLwo+ICsJcHRyID0gaWd0 X2ZiX21hcF9idWZmZXIoZmItPmZkLCBmYik7Cj4gKwlpZ3RfYXNzZXJ0KCoodWludDMyX3QgKilw dHIgPT0gMCk7Cj4gKwo+ICsJc3dpdGNoIChmYi0+ZHJtX2Zvcm1hdCkgewo+ICsJY2FzZSBEUk1f Rk9STUFUX05WMTI6Cj4gKwkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ICsJCSAgICAg ICBmdWxsX3JhbmdlID8gMHgwMCA6IDB4MTAsCj4gKwkJICAgICAgIGZiLT5zdHJpZGVzWzBdICog ZmItPnBsYW5lX2hlaWdodFswXSk7Cj4gKwkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzFdLAo+ ICsJCSAgICAgICAweDgwLAo+ICsJCSAgICAgICBmYi0+c3RyaWRlc1sxXSAqIGZiLT5wbGFuZV9o ZWlnaHRbMV0pOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSBEUk1fRk9STUFUX1hZVVY4ODg4Ogo+ICsJ CXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sIGZ1bGxfcmFuZ2UgPyAweDAwMDA4MDgwIDog MHgwMDEwODA4MCwKPiArCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8g c2l6ZW9mKHdjaGFyX3QpKTsKPiArCQlicmVhazsKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZVVlWOgo+ ICsJY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4gKwkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1sw XSwKPiArCQkJZnVsbF9yYW5nZSA/IDB4ODAwMDgwMDAgOiAweDgwMTA4MDEwLAo+ICsJCQlmYi0+ c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ICsJ CWJyZWFrOwo+ICsJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gKwljYXNlIERSTV9GT1JNQVRfVllV WToKPiArCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ICsJCQlmdWxsX3JhbmdlID8g MHgwMDgwMDA4MCA6IDB4MTA4MDEwODAsCj4gKwkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5l X2hlaWdodFswXSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gKwkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJ aWd0X2ZiX3VubWFwX2J1ZmZlcihmYiwgcHRyKTsKPiArfQo+ICsKPiAgLyogaGVscGVycyB0byBj cmVhdGUgbmljZS1sb29raW5nIGZyYW1lYnVmZmVycyAqLwo+ICBzdGF0aWMgaW50IGNyZWF0ZV9i b19mb3JfZmIoc3RydWN0IGlndF9mYiAqZmIpCj4gIHsKPiBAQCAtNTAxLDUwICs1NDIsMTMgQEAg c3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICAJCWZiLT5p c19kdW1iID0gZmFsc2U7Cj4gIAo+ICAJCWlmIChpc19pOTE1X2RldmljZShmZCkpIHsKPiAtCQkJ dm9pZCAqcHRyOwo+IC0JCQlib29sIGZ1bGxfcmFuZ2UgPSBmYi0+Y29sb3JfcmFuZ2UgPT0gSUdU X0NPTE9SX1lDQkNSX0ZVTExfUkFOR0U7Cj4gIAo+ICAJCQlmYi0+Z2VtX2hhbmRsZSA9IGdlbV9j cmVhdGUoZmQsIGZiLT5zaXplKTsKPiAgCj4gIAkJCWdlbV9zZXRfdGlsaW5nKGZkLCBmYi0+Z2Vt X2hhbmRsZSwKPiAgCQkJCSAgICAgICBpZ3RfZmJfbW9kX3RvX3RpbGluZyhmYi0+dGlsaW5nKSwK PiAgCQkJCSAgICAgICBmYi0+c3RyaWRlc1swXSk7Cj4gLQo+IC0JCQlnZW1fc2V0X2RvbWFpbihm ZCwgZmItPmdlbV9oYW5kbGUsCj4gLQkJCQkgICAgICAgSTkxNV9HRU1fRE9NQUlOX0dUVCwgSTkx NV9HRU1fRE9NQUlOX0dUVCk7Cj4gLQo+IC0JCQkvKiBFbnN1cmUgdGhlIGZyYW1lYnVmZmVyIGlz IHByZWFsbG9jYXRlZCAqLwo+IC0JCQlwdHIgPSBnZW1fbW1hcF9fZ3R0KGZkLCBmYi0+Z2VtX2hh bmRsZSwKPiAtCQkJCQkgICAgZmItPnNpemUsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUpOwo+IC0J CQlpZ3RfYXNzZXJ0KCoodWludDMyX3QgKilwdHIgPT0gMCk7Cj4gLQo+IC0JCQlzd2l0Y2ggKGZi LT5kcm1fZm9ybWF0KSB7Cj4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9OVjEyOgo+IC0JCQkJbWVtc2V0 KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+IC0JCQkJICAgICAgIGZ1bGxfcmFuZ2UgPyAweDAwIDog MHgxMCwKPiAtCQkJCSAgICAgICBmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0p Owo+IC0JCQkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzFdLAo+IC0JCQkJICAgICAgIDB4ODAs Cj4gLQkJCQkgICAgICAgZmItPnN0cmlkZXNbMV0gKiBmYi0+cGxhbmVfaGVpZ2h0WzFdKTsKPiAt CQkJCWJyZWFrOwo+IC0JCQljYXNlIERSTV9GT1JNQVRfWFlVVjg4ODg6Cj4gLQkJCQl3bWVtc2V0 KHB0ciArIGZiLT5vZmZzZXRzWzBdLCBmdWxsX3JhbmdlID8gMHgwMDAwODA4MCA6IDB4MDAxMDgw ODAsCj4gLQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9m KHdjaGFyX3QpKTsKPiAtCQkJCWJyZWFrOwo+IC0JCQljYXNlIERSTV9GT1JNQVRfWVVZVjoKPiAt CQkJY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4gLQkJCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRz WzBdLAo+IC0JCQkJCWZ1bGxfcmFuZ2UgPyAweDgwMDA4MDAwIDogMHg4MDEwODAxMCwKPiAtCQkJ CQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkp Owo+IC0JCQkJYnJlYWs7Cj4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9VWVZZOgo+IC0JCQljYXNlIERS TV9GT1JNQVRfVllVWToKPiAtCQkJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gLQkJ CQkJZnVsbF9yYW5nZSA/IDB4MDA4MDAwODAgOiAweDEwODAxMDgwLAo+IC0JCQkJCWZiLT5zdHJp ZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gLQkJCQli cmVhazsKPiAtCQkJfQo+IC0JCQlnZW1fbXVubWFwKHB0ciwgZmItPnNpemUpOwo+ICsJCQljbGVh cl95dXZfYnVmZmVyKGZkKTsKPiAgCj4gIAkJCXJldHVybiBmYi0+Z2VtX2hhbmRsZTsKPiAgCQl9 IGVsc2UgewotLSAKUGF1bCBLb2NpYWxrb3dza2ksIEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5k IGtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK