From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
"Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>,
<igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation
Date: Thu, 26 Oct 2023 12:08:05 +0530 [thread overview]
Message-ID: <672e13c3-3d92-63c3-07d2-6dd5491d3c8e@intel.com> (raw)
In-Reply-To: <20231004103641.wj5dukxexd73r62e@kamilkon-desk.igk.intel.com>
Hello Kamil,
On 10/4/2023 4:06 PM, Kamil Konieczny wrote:
> Hi Juha-Pekka,
>
> On 2023-10-04 at 11:15:25 +0300, Juha-Pekka Heikkila wrote:
>> On 4.10.2023 8.48, Modem, Bhanuprakash wrote:
>>> Forgot to add Kamil to the TO/CC list.
>>>
>>> On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
>>>> Hi Kunal,
>>>>
>>>> On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
>>>>> Test to validate hotplug in simulation environment we
>>>>> have scratch pad register 0x4f080 from which we can
>>>>> trigger uevents such as HPD, VBLANK..etc, Idea is to
>>>>> have port mapping placed in igtrcthrough which test
>>>>> can write to 0x4f080 and check if we get hotplug
>>>> In first glance, do we really need to upstream this test? I am
>>>> pretty sure, no one (including Intel) is going to use this test from
>>>> upstream repo (We don't have any simulation environment in public
>>>> CI).
>>>>
>>>> So, we can't merge this.
>>>>
>>>> + Kamil, thoughts?
>>>>
>> Not sure why this wouldn't fit in upstream? It is valid igt test, will be of
>> interest only for Intel guys hence in in intel directory and when in
>> upstream it will not be causing issues during backports. We anyway already
>> have more generic tests taking into account if they're being run in
>> simulated environments.
>>
>> /Juha-Pekka
>>
> imho this should not be upstreamed as any user outside Intel
> will not be able to run it. Why it cannot be a subtest with
> some generic test like kms_hotplug.c with only timeout increased
> for simulation? Such test may be in upstream if it will work
> with existing hardware in CI.
>
> Regards,
> Kamil
This test will only work in presi environment, for testing hotplug in
hardware we have kms_chamelium_hpd,
But we can have it in upstream as someday we may require to run upstream
igt's on presi.
Any thoughts bhanu and JP?
Thanks and Regards
Kunal Joshi
next prev parent reply other threads:[~2023-10-26 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 10:30 [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation Kunal Joshi
2023-10-01 10:30 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_simulation_hpd: New test for hotplug validation Kunal Joshi
2023-10-01 10:30 ` [igt-dev] [PATCH i-g-t 2/2] tests/meson: added test to meson.build Kunal Joshi
2023-10-01 10:50 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Add test for hotplug validation in simulation Patchwork
2023-10-01 10:54 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-10-03 9:12 ` [igt-dev] [PATCH i-g-t 0/2] " Modem, Bhanuprakash
2023-10-04 5:48 ` Modem, Bhanuprakash
2023-10-04 8:15 ` Juha-Pekka Heikkila
2023-10-04 10:36 ` Kamil Konieczny
2023-10-26 6:38 ` Joshi, Kunal1 [this message]
2023-10-26 7:31 ` Modem, Bhanuprakash
2023-10-04 13:28 ` Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672e13c3-3d92-63c3-07d2-6dd5491d3c8e@intel.com \
--to=kunal1.joshi@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox