RE: [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]

Hi Jeevan,

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Jeevan B
Sent: Wednesday, March 25, 2026 10:22 PM
To: igt-dev@lists.freedesktop.org
Cc: Samala, Pranay <pranay.samala@intel.com>; B, Jeevan <jeevan.b@intel.com>
Subject: [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable

Use output instead of NULL in PSR helpers so PSR is disabled only when 
supported by the sink, avoiding unnecessary global checks and ensuring 
correct behavior on multi-eDP setups.

Signed-off-by: Jeevan B <jeevan.b@intel.com <mailto:jeevan.b@intel.com>>

---

tests/kms_vrr.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 
ec0692b2f..ec17366c8 100644

--- a/tests/kms_vrr.c

+++ b/tests/kms_vrr.c

@@ -912,9 +912,9 @@ test_lobf(data_t *data, igt_crtc_t *crtc, 
igt_output_t *output,

igt_skip("%s: Aux-less ALPM not enabled, LOBF not supported.\n",

igt_output_name(output));

-if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||

-psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))

-psr_disable(data->drm_fd, data->debugfs_fd, NULL);

+if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, output) ||

+psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, output))

+psr_disable(data->drm_fd, data->debugfs_fd, output);

}

This patch is to update the debugfs. on that part it is LGTM. But 
observed one issue, As per the above psr check logic it is only checking 
panel replay and psr1 mode. If psr2 is enabled test will skip due to 
lobf and psr2 are mutually exclusive. Better this needs to be fix in 
other patch or this patch.

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>

igt_info("LOBF test execution on %s, PIPE %s with VRR range: (%u-%u) Hz\n",

--

2.43.0


[-- Attachment #2: Type: text/html, Size: 7712 bytes --]