Re: [PATCH i-g-t 00/17] lib/kms: Finish the igt_crtc_t API refactoring

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 27 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Convert the remaining (more or less) igt_kms APIs to
> igt_crtc_t* from enum pipe.
>
> To get rid of the kmstest_vbl*() stuff from most places I 
> did some (technically functional) pipe to crtc_index conversions,
> and then added the igt_crtc_t* based igt_crtc_vbl*() wrappers.

There are a few issues with invalid CRTCs, mentioned inline. Also some
nitpicks. With the issues fixed,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Felt like some of the places could've gone more directly to
igt_crtc_vblank(), but I'm guessing step by step is easier with cocci.

There are also some lefover kmstest_get_vblank() that I think could've
been converted, but overall this is good forward progress.

>
> There are also some cleanups of a few random leftovers from
> earlier conversion attempts.
>
> I also did a bunch of renaming across the tree, just to
> reduce the appearance of the word "pipe". That should hopefully
> make it a bit easier to see which parts of the codebase still
> need work.
>
> Ville Syrjälä (17):
>   lib/kms: Replace igt_pipe_has_valid_output() with
>     igt_crtc_has_valid_output()
>   lib/kms: Replace igt_display_require_output_on_pipe() with
>     igt_display_require_output_on_crtc()
>   lib/kms: Replace igt_get_single_output_for_pipe() with
>     igt_get_single_output_for_crtc()
>   lib/kms: Make the igt_*_bpc_*() interfaces more abstract
>   tests/kms: Use igt_crtc_name()
>   tests/kms: Clean up crtc->pipe comparions
>   tests/vmwgfx/vmw_prime: Replace igt_pipe_crc_new() with
>     igt_crtc_crc_new()
>   lib/kms: Prefer "crtc" over "pipe" in function names
>   tests/kms_color*: Prefer "crtc" over "pipe" in function names
>   tests/kms: Prefer "crtc" over "pipe" in function names
>   tests/kms_tiled_display: Remove mention of PIPE_NONE
>   tests/kms: Remove hand rolled get_vblank() stuff
>   lib/kms: Fix kmstest_get_vblank() docs
>   tests/kms: Pass crtc_index to kmstest_get_vbl_flag()
>   tests/kms: Pass crtc_index to kmstest_get_vblank()
>   lib/kms: Introduce igt_crtc_get_vbl_flag()
>   lib/kms: Introduce igt_crtc_get_vblank()
>
>  lib/igt_kms.c                                 | 120 ++++++++++--------
>  lib/igt_kms.h                                 |  19 +--
>  tests/amdgpu/amd_abm.c                        |   3 +-
>  tests/amdgpu/amd_bypass.c                     |   5 +-
>  tests/amdgpu/amd_color.c                      |   3 +-
>  tests/amdgpu/amd_dp_dsc.c                     |   7 +-
>  tests/amdgpu/amd_freesync_video_mode.c        |   6 +-
>  tests/amdgpu/amd_max_bpc.c                    |   4 +-
>  tests/amdgpu/amd_multidisplay_modeset.c       |   2 +-
>  tests/amdgpu/amd_psr.c                        |   3 +-
>  tests/amdgpu/amd_replay.c                     |   3 +-
>  tests/chamelium/kms_chamelium_color.c         |  22 ++--
>  .../kms_chamelium_sharpness_filter.c          |   4 +-
>  tests/drm_read.c                              |   4 +-
>  tests/intel/gem_eio.c                         |   2 +-
>  tests/intel/kms_busy.c                        |  10 +-
>  tests/intel/kms_ccs.c                         |   3 +-
>  tests/intel/kms_dsc.c                         |   4 +-
>  tests/intel/kms_dsc_helper.c                  |   2 +-
>  tests/intel/kms_flip_tiling.c                 |   4 +-
>  tests/intel/kms_pipe_b_c_ivb.c                |  40 +++---
>  tests/intel/kms_pipe_stress.c                 |  28 +---
>  tests/intel/perf_pmu.c                        |   2 +-
>  tests/kms_async_flips.c                       |   8 +-
>  tests/kms_atomic.c                            |  26 ++--
>  tests/kms_atomic_interruptible.c              |  16 +--
>  tests/kms_atomic_transition.c                 |   6 +-
>  tests/kms_bw.c                                |   3 +-
>  tests/kms_color.c                             |  24 ++--
>  tests/kms_color_helper.c                      |  34 ++---
>  tests/kms_color_helper.h                      |   8 +-
>  tests/kms_color_pipeline.c                    |   2 +-
>  tests/kms_cursor_legacy.c                     | 119 ++++++++++-------
>  tests/kms_display_modes.c                     |   2 +-
>  tests/kms_dither.c                            |   4 +-
>  tests/kms_hdr.c                               |  31 +++--
>  tests/kms_pipe_crc_basic.c                    |  10 +-
>  tests/kms_plane.c                             |   9 +-
>  tests/kms_plane_alpha_blend.c                 |  10 +-
>  tests/kms_plane_multiple.c                    |   2 +-
>  tests/kms_plane_scaling.c                     |  40 +++---
>  tests/kms_properties.c                        |  20 +--
>  tests/kms_rotation_crc.c                      |  10 +-
>  tests/kms_tiled_display.c                     |   3 +-
>  tests/kms_universal_plane.c                   |  32 ++---
>  tests/kms_vblank.c                            |  24 ++--
>  tests/kms_vrr.c                               |   8 +-
>  tests/nouveau_crc.c                           |   6 +-
>  tests/prime_vgem.c                            |  28 +---
>  tests/vmwgfx/vmw_prime.c                      |   4 +-
>  50 files changed, 397 insertions(+), 392 deletions(-)

-- 
Jani Nikula, Intel