Re: [PATCH i-g-t 2/8] tools/intel_vbt_decode.c: Include linux_scaffold.h

Karthik B S
2026-04-27T05:09:52Z

On 4/22/2026 9:13 AM, Ankit Nautiyal wrote:
> linux_scaffold.h provides kernel compat macros including GENMASK and
> BIT_U32, which will be needed by intel_vbt_defs.h in subsequent changes.
> Include it in intel_vbt_decode.c and remove the now duplicate typedefs
> for u8, u16, u32, and u64.
>
> While at it, move drmtest.h in asciibetical order.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tools/intel_vbt_decode.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index d4aada743e42..7785e9e82b1f 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -38,17 +38,13 @@
> #include <sys/stat.h>
> #include <sys/types.h>
>
> +#include "drmtest.h"
> #include "igt_aux.h"
> #include "igt_halffloat.h"
> #include "intel_chipset.h"
> #include "intel_io.h"
> -#include "drmtest.h"
> +#include "linux_scaffold.h"
>
> -/* kernel types for intel_vbt_defs.h */
> -typedef uint8_t u8;
> -typedef uint16_t u16;
> -typedef uint32_t u32;
> -typedef uint64_t u64;
> #define __packed __attribute__ ((packed))
>
> #define _INTEL_BIOS_PRIVATE