Re: [igt-dev] [PATCH i-g-t v2 3/6] tests/i915/kms_dsc: Remove pointless struct

[Swati Sharma <swati2.sharma@intel.com>]

Hi Kamil,

Can we add checkpatch for patchwork IGT in CI infrastructure like how we 
have for patchwork intel-gfx?

On 03-Feb-23 5:59 PM, Kamil Konieczny wrote:
> Hi Swati,
> 
> On 2023-02-02 at 12:51:18 +0530, Swati Sharma wrote:
>> Array can be used for plane_format. Use that and remove
>> struct.
>>
>> v2: -make format list static (Jouni)
> 
> Please use checkpatch script from Linux kernel source to find out
> and correct some problems. You can sometimes ignore some warnings
> like line too long or string splitted but please correct all
> others.
> 
> +cc Jouni

Sorry, this patch is already merged; will take care next time.

> 
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/i915/kms_dsc.c | 15 +++------------
>>   1 file changed, 3 insertions(+), 12 deletions(-)
>>
>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>> index af9466518..0f048e575 100644
>> --- a/tests/i915/kms_dsc.c
>> +++ b/tests/i915/kms_dsc.c
>> @@ -52,16 +52,7 @@ typedef struct {
>>   	enum pipe pipe;
>>   } data_t;
>>   
>> -const struct {
>> -	const int format;
>> -	const char format_str[20];
>> -} format_list[] = {
>> -	{DRM_FORMAT_XYUV8888, "XYUV8888"},
>> -	{DRM_FORMAT_XRGB2101010, "XRGB2101010"},
>> -	{DRM_FORMAT_XRGB16161616F, "XRGB16161616F"},
>> -	{DRM_FORMAT_YUYV, "YUYV"},
>> -};
>> -
>> +static int format_list[] =  {DRM_FORMAT_XYUV8888, DRM_FORMAT_XRGB2101010, DRM_FORMAT_XRGB16161616F, DRM_FORMAT_YUYV};
> ---------------------------- ^^ ^
> imho this should be:
> static int format_list[] = {
> 	DRM_FORMAT_XYUV8888,
> 	DRM_FORMAT_XRGB2101010,
> 	DRM_FORMAT_XRGB16161616F,
> 	DRM_FORMAT_YUYV
> };
> 
> Regards,
> Kamil
> 
>>   uint32_t bpc_list[] = {12, 10, 8};
>>   
>>   static inline void manual(const char *expected)
>> @@ -242,7 +233,7 @@ igt_main
>>   		     "with default parameters and creating fb with diff formats");
>>   	igt_subtest_with_dynamic("dsc-with-formats") {
>>   		for (int k = 0; k < ARRAY_SIZE(format_list); k++)
>> -			test_dsc(&data, TEST_DSC_BASIC, 0, format_list[k].format);
>> +			test_dsc(&data, TEST_DSC_BASIC, 0, format_list[k]);
>>   	}
>>   
>>   	igt_describe("Tests basic display stream compression functionality if supported "
>> @@ -259,7 +250,7 @@ igt_main
>>   	igt_subtest_with_dynamic("dsc-with-bpc-formats") {
>>   		for (int j = 0; j < ARRAY_SIZE(bpc_list); j++) {
>>   			for (int k = 0; k < ARRAY_SIZE(format_list); k++) {
>> -				test_dsc(&data, TEST_DSC_BPC, bpc_list[j], format_list[k].format);
>> +				test_dsc(&data, TEST_DSC_BPC, bpc_list[j], format_list[k]);
>>   			}
>>   		}
>>   	}
>> -- 
>> 2.25.1
>>

-- 
~Swati Sharma