From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA6AE6E682 for ; Thu, 6 Dec 2018 22:57:54 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id e5so2468680qtr.12 for ; Thu, 06 Dec 2018 14:57:54 -0800 (PST) Message-ID: <6a5aa96390b4d8b29f056d19d496e7c102d372bd.camel@redhat.com> From: Lyude Paul Date: Thu, 06 Dec 2018 17:57:52 -0500 In-Reply-To: <20181206141132.23349-8-paul.kocialkowski@bootlin.com> References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-8-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 7/9] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: V2l0aCB0aGUgY2hhbmdlcyB0aGF0IE1heGltZSBtZW50aW9uZWQ6CgpSZXZpZXdlZC1ieTogTHl1 ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KCk9uIFRodSwgMjAxOC0xMi0wNiBhdCAxNToxMSAr MDEwMCwgUGF1bCBLb2NpYWxrb3dza2kgd3JvdGU6Cj4gVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRp b24gb2YgaWd0X2ZiX2NvbnZlcnQgZG9lcyBub3QgYWxsb3cgcGFzc2luZwo+IHRoZSBkZXN0aW5h dGlvbiBzdHJpZGUsIHdoaWNoIGlzIHNvbWV0aGluZyB3ZSB3YW50IHRvIGNoYW5nZSBmb3IgdGVz dHMuCj4gCj4gQWRkIGEgbmV3IGZhc2hpb24gb2YgdGhpcyBmdW5jdGlvbiB0aGF0IGFsbG9jYXRl cyB0aGUgZGVzaW50YXRpb24gYnVmZmVyCj4gd2l0aCBhIGdpdmVuIHN0cmlkZS4gU2luY2UgdGhl IGN1cnJlbnQgZnVuY3Rpb24gZG9lcyB0aGUgc2FtZSB0aGluZyB3aXRoCj4gYW4gdW5zcGVjaWZp ZWQgc3RyaWRlIChzZXQgdG8gemVybywgd2hpY2ggd2lsbCBiZSBmaWxsZWQgbGF0ZXIpLCBtYWtl IGl0Cj4gY2FsbCBvdXIgbmV3IGZhc2hpb24gd2l0aCB0aGUgc3RyaWRlIHNldCB0byB6ZXJvIHRv IGF2b2lkIGR1cGxpY2F0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgS29jaWFsa293c2tp IDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KPiAtLS0KPiAgbGliL2lndF9mYi5jIHwg MzggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPiAgbGliL2lndF9mYi5o IHwgIDMgKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5k ZXggNjEyNTBiMGUuLjE1NDhiZjRlIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBi L2xpYi9pZ3RfZmIuYwo+IEBAIC0yMjUzLDE0ICsyMjUzLDE1IEBAIHZvaWQgaWd0X3JlbW92ZV9m YihpbnQgZmQsIHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICB9Cj4gIAo+ICAvKioKPiAtICogaWd0X2Zi X2NvbnZlcnQ6Cj4gKyAqIGlndF9mYl9jb252ZXJ0X3dpdGhfc3RyaWRlOgo+ICAgKiBAZHN0OiBw b2ludGVyIHRvIHRoZSAjaWd0X2ZiIHN0cnVjdHVyZSB0aGF0IHdpbGwgc3RvcmUgdGhlIGNvbnZl cnNpb24KPiByZXN1bHQKPiAgICogQHNyYzogcG9pbnRlciB0byB0aGUgI2lndF9mYiBzdHJ1Y3R1 cmUgdGhhdCBzdG9yZXMgdGhlIGZyYW1lIHdlIGNvbnZlcnQKPiAgICogQGRzdF9mb3VyY2M6IERS TSBmb3JtYXQgc3BlY2lmaWVyIHRvIGNvbnZlcnQgdG8KPiArICogQGRzdF9zdHJpZGU6IERSTSBm b3JtYXQgc3BlY2lmaWVyIHRvIGNvbnZlcnQgdG8KPiAgICoKPiAgICogVGhpcyB3aWxsIGNvbnZl cnQgYSBnaXZlbiBAc3JjIGNvbnRlbnQgdG8gdGhlIEBkc3RfZm91cmNjIGZvcm1hdCwKPiAgICog c3RvcmluZyB0aGUgcmVzdWx0IGluIHRoZSBAZHN0IGZiLCBhbGxvY2F0aW5nIHRoZSBAZHN0IGZi Cj4gLSAqIHVuZGVybHlpbmcgYnVmZmVyLgo+ICsgKiB1bmRlcmx5aW5nIGJ1ZmZlciB3aXRoIGEg c3RyaWRlIG9mIEBkc3Rfc3RyaWRlIHN0cmlkZS4KPiAgICoKPiAgICogT25jZSBkb25lIHdpdGgg QGRzdCwgdGhlIGNhbGxlciB3aWxsIGhhdmUgdG8gY2FsbCBpZ3RfcmVtb3ZlX2ZiKCkKPiAgICog b24gaXQgdG8gZnJlZSB0aGUgYXNzb2NpYXRlZCByZXNvdXJjZXMuCj4gQEAgLTIyNjgsMTUgKzIy NjksMTggQEAgdm9pZCBpZ3RfcmVtb3ZlX2ZiKGludCBmZCwgc3RydWN0IGlndF9mYiAqZmIpCj4g ICAqIFJldHVybnM6Cj4gICAqIFRoZSBrbXMgaWQgb2YgdGhlIGNyZWF0ZWQgZnJhbWVidWZmZXIu Cj4gICAqLwo+IC11bnNpZ25lZCBpbnQgaWd0X2ZiX2NvbnZlcnQoc3RydWN0IGlndF9mYiAqZHN0 LCBzdHJ1Y3QgaWd0X2ZiICpzcmMsCj4gLQkJCSAgICB1aW50MzJfdCBkc3RfZm91cmNjKQo+ICt1 bnNpZ25lZCBpbnQgaWd0X2ZiX2NvbnZlcnRfd2l0aF9zdHJpZGUoc3RydWN0IGlndF9mYiAqZHN0 LCBzdHJ1Y3QgaWd0X2ZiCj4gKnNyYywKPiArCQkJCQl1aW50MzJfdCBkc3RfZm91cmNjLAo+ICsJ CQkJCXVuc2lnbmVkIGludCBkc3Rfc3RyaWRlKQo+ICB7Cj4gIAlzdHJ1Y3QgZmJfY29udmVydCBj dnQgPSB7IH07Cj4gIAl2b2lkICpkc3RfcHRyLCAqc3JjX3B0cjsKPiAgCWludCBmYl9pZDsKPiAg Cj4gLQlmYl9pZCA9IGlndF9jcmVhdGVfZmIoc3JjLT5mZCwgc3JjLT53aWR0aCwgc3JjLT5oZWln aHQsCj4gLQkJCSAgICAgIGRzdF9mb3VyY2MsIExPQ0FMX0RSTV9GT1JNQVRfTU9EX05PTkUsIGRz dCk7Cj4gKwlmYl9pZCA9IGlndF9jcmVhdGVfZmJfd2l0aF9ib19zaXplKHNyYy0+ZmQsIHNyYy0+ d2lkdGgsIHNyYy0+aGVpZ2h0LAo+ICsJCQkJCSAgIGRzdF9mb3VyY2MsCj4gKwkJCQkJICAgTE9D QUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSwKPiArCQkJCQkgICBkc3QsIDAsIGRzdF9zdHJpZGUpOwo+ ICAJaWd0X2Fzc2VydChmYl9pZCA+IDApOwo+ICAKPiAgCXNyY19wdHIgPSBpZ3RfZmJfbWFwX2J1 ZmZlcihzcmMtPmZkLCBzcmMpOwo+IEBAIC0yMjk3LDYgKzIzMDEsMjggQEAgdW5zaWduZWQgaW50 IGlndF9mYl9jb252ZXJ0KHN0cnVjdCBpZ3RfZmIgKmRzdCwKPiBzdHJ1Y3QgaWd0X2ZiICpzcmMs Cj4gIAlyZXR1cm4gZmJfaWQ7Cj4gIH0KPiAgCj4gKy8qKgo+ICsgKiBpZ3RfZmJfY29udmVydDoK PiArICogQGRzdDogcG9pbnRlciB0byB0aGUgI2lndF9mYiBzdHJ1Y3R1cmUgdGhhdCB3aWxsIHN0 b3JlIHRoZSBjb252ZXJzaW9uCj4gcmVzdWx0Cj4gKyAqIEBzcmM6IHBvaW50ZXIgdG8gdGhlICNp Z3RfZmIgc3RydWN0dXJlIHRoYXQgc3RvcmVzIHRoZSBmcmFtZSB3ZSBjb252ZXJ0Cj4gKyAqIEBk c3RfZm91cmNjOiBEUk0gZm9ybWF0IHNwZWNpZmllciB0byBjb252ZXJ0IHRvCj4gKyAqCj4gKyAq IFRoaXMgd2lsbCBjb252ZXJ0IGEgZ2l2ZW4gQHNyYyBjb250ZW50IHRvIHRoZSBAZHN0X2ZvdXJj YyBmb3JtYXQsCj4gKyAqIHN0b3JpbmcgdGhlIHJlc3VsdCBpbiB0aGUgQGRzdCBmYiwgYWxsb2Nh dGluZyB0aGUgQGRzdCBmYgo+ICsgKiB1bmRlcmx5aW5nIGJ1ZmZlci4KPiArICoKPiArICogT25j ZSBkb25lIHdpdGggQGRzdCwgdGhlIGNhbGxlciB3aWxsIGhhdmUgdG8gY2FsbCBpZ3RfcmVtb3Zl X2ZiKCkKPiArICogb24gaXQgdG8gZnJlZSB0aGUgYXNzb2NpYXRlZCByZXNvdXJjZXMuCj4gKyAq Cj4gKyAqIFJldHVybnM6Cj4gKyAqIFRoZSBrbXMgaWQgb2YgdGhlIGNyZWF0ZWQgZnJhbWVidWZm ZXIuCj4gKyAqLwo+ICt1bnNpZ25lZCBpbnQgaWd0X2ZiX2NvbnZlcnQoc3RydWN0IGlndF9mYiAq ZHN0LCBzdHJ1Y3QgaWd0X2ZiICpzcmMsCj4gKwkJCSAgICB1aW50MzJfdCBkc3RfZm91cmNjKQo+ ICt7Cj4gKwlyZXR1cm4gaWd0X2ZiX2NvbnZlcnRfd2l0aF9zdHJpZGUoZHN0LCBzcmMsIGRzdF9m b3VyY2MsIDApOwo+ICt9Cj4gKwo+ICAvKioKPiAgICogaWd0X2JwcF9kZXB0aF90b19kcm1fZm9y bWF0Ogo+ICAgKiBAYnBwOiBkZXNpcmVkIGJpdHMgcGVyIHBpeGVsCj4gZGlmZiAtLWdpdCBhL2xp Yi9pZ3RfZmIuaCBiL2xpYi9pZ3RfZmIuaAo+IGluZGV4IDlmMDI3ZGViLi5jYjIxZmRiYyAxMDA2 NDQKPiAtLS0gYS9saWIvaWd0X2ZiLmgKPiArKysgYi9saWIvaWd0X2ZiLmgKPiBAQCAtMTMwLDYg KzEzMCw5IEBAIHVuc2lnbmVkIGludCBpZ3RfY3JlYXRlX2ltYWdlX2ZiKGludCBkcm1fZmQsICBp bnQgd2lkdGgsCj4gaW50IGhlaWdodCwKPiAgCQkJCSBzdHJ1Y3QgaWd0X2ZiICpmYiAvKiBvdXQg Ki8pOwo+ICB1bnNpZ25lZCBpbnQgaWd0X2NyZWF0ZV9zdGVyZW9fZmIoaW50IGRybV9mZCwgZHJt TW9kZU1vZGVJbmZvICptb2RlLAo+ICAJCQkJICB1aW50MzJfdCBmb3JtYXQsIHVpbnQ2NF90IHRp bGluZyk7Cj4gK3Vuc2lnbmVkIGludCBpZ3RfZmJfY29udmVydF93aXRoX3N0cmlkZShzdHJ1Y3Qg aWd0X2ZiICpkc3QsIHN0cnVjdCBpZ3RfZmIKPiAqc3JjLAo+ICsJCQkJCXVpbnQzMl90IGRzdF9m b3VyY2MsCj4gKwkJCQkJdW5zaWduZWQgaW50IHN0cmlkZSk7Cj4gIHVuc2lnbmVkIGludCBpZ3Rf ZmJfY29udmVydChzdHJ1Y3QgaWd0X2ZiICpkc3QsIHN0cnVjdCBpZ3RfZmIgKnNyYywKPiAgCQkJ ICAgIHVpbnQzMl90IGRzdF9mb3VyY2MpOwo+ICB2b2lkIGlndF9yZW1vdmVfZmIoaW50IGZkLCBz dHJ1Y3QgaWd0X2ZiICpmYik7Ci0tIApDaGVlcnMsCglMeXVkZSBQYXVsCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdApp Z3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK