From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9A9A89CC4 for ; Thu, 18 Jul 2019 06:24:38 +0000 (UTC) From: "Ser, Simon" Date: Thu, 18 Jul 2019 06:24:33 +0000 Message-ID: <6a7512c12f04cb23827f6d19536409b2359a7eb7.camel@intel.com> References: <20190717181055.581-1-madhumitha.tolakanahalli.pradeep@intel.com> In-Reply-To: <20190717181055.581-1-madhumitha.tolakanahalli.pradeep@intel.com> Content-Language: en-US Content-ID: <0AF004D93996C64B83FD1ADF67F54053@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH] lib/igt_kms.c igt_kms.h: tile property parser List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Tolakanahalli Pradeep, Madhumitha" Cc: "Navare, Manasi D" , "Latvala, Petri" List-ID: SGksDQoNCkhlcmUgYXJlIGEgZmV3IGNvbW1lbnRzLg0KDQpPbiBXZWQsIDIwMTktMDctMTcgYXQg MTE6MTAgLTA3MDAsIE1hZGh1bWl0aGEgVG9sYWthbmFoYWxsaSBQcmFkZWVwIHdyb3RlOg0KPiBU aGUgdGlsZSBwcm9wZXJ0eSBwYXJzZXIgcGFyc2VzIHRoZSBjb25uZWN0b3IgdGlsZSBwcm9wZXJ0 eSBvYnRhaW5lZA0KPiBmcm9tIGNvbm5lY3RvcidzIERpc3BsYXkgSUQgYmxvY2sgYW5kIHNldCBw ZXIgY29ubmVjdG9yLg0KPiANCj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp bnRlbC5jb20+DQo+IENjOiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGludGVsLmNvbT4N Cj4gU2lnbmVkLW9mZi1ieTogTWFkaHVtaXRoYSBUb2xha2FuYWhhbGxpIFByYWRlZXAgPG1hZGh1 bWl0aGEudG9sYWthbmFoYWxsaS5wcmFkZWVwQGludGVsLmNvbT4NCj4gLS0tDQo+ICBsaWIvaWd0 X2ttcy5jIHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gIGxpYi9pZ3Rfa21zLmgg fCAxMSArKysrKysrKysrKw0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCspDQo+ IA0KPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9pZ3Rfa21zLmMNCj4gaW5kZXgg MTc1ZTcxYzMuLjg0NjMxNGRlIDEwMDY0NA0KPiAtLS0gYS9saWIvaWd0X2ttcy5jDQo+ICsrKyBi L2xpYi9pZ3Rfa21zLmMNCj4gQEAgLTQ1MTEsMyArNDUxMSwyOSBAQCBib29sIGlndF9kaXNwbGF5 X2hhc19mb3JtYXRfbW9kKGlndF9kaXNwbGF5X3QgKmRpc3BsYXksIHVpbnQzMl90IGZvcm1hdCwN Cj4gIA0KPiAgCXJldHVybiBmYWxzZTsNCj4gIH0NCj4gKw0KPiArLyoqDQo+ICsgKiBpZ3RfcGFy c2VfY29ubmVjdG9yX3RpbGVfYmxvYjoNCj4gKyAqIEBibG9iOiBwb2ludGVyIHRvIHRoZSBjb25u ZWN0b3IncyB0aWxlIHByb3BlcnRpZXMNCj4gKyAqIEB0aWxlOiBwb2ludGVyIHRvIHRpbGUgc3Ry dWN0dXJlIHRoYXQgaXMgcG9wdWxhdGVkIGJ5IHRoZSBmdW5jdGlvbg0KPiArICoNCj4gKyAqIFBh cnNlcyB0aGUgY29ubmVjdG9yIHRpbGUgYmxvYiB0byBleHRyYWN0IHRoZSB0aWxlIGluZm9ybWF0 aW9uDQo+ICsgKg0KPiArICovDQo+ICsNCj4gK3ZvaWQgaWd0X3BhcnNlX2Nvbm5lY3Rvcl90aWxl X2Jsb2IoZHJtTW9kZVByb3BlcnR5QmxvYlB0ciBibG9iLA0KPiArCQkJCWlndF90aWxlX2luZm9f dCAqIHRpbGUpDQoNClN0eWxlOiBhbGlnbiB3aXRoIGFzIG1hbnkgdGFicyBhcyBwb3NzaWJsZSwg dGhlbiBmaWxsIHRoZSByZXN0IHdpdGgNCnNwYWNlcy4NCg0KPiArew0KPiArCWNoYXIgKiBibG9i X2RhdGEgPSBibG9iLT5kYXRhOw0KDQpTdHlsZTogbm8gc3BhY2UgYWZ0ZXIgc3Rhci4NCg0KICAg IGNoYXIgKnRoaW5nID0gc3R1ZmY7DQoNCkFwcGxpZXMgdG8gdGhlIHdob2xlIHBhdGNoLg0KDQo+ ICsJaWYoYmxvYikgew0KDQpTdHlsZTogc3BhY2UgYWZ0ZXIgaWYga2V5d29yZC4NCg0KPiArCQl0 aWxlLT50aWxlX2dyb3VwX2lkID0gYXRvaShzdHJ0b2soYmxvYl9kYXRhLCAiOiIpKTsNCg0KVGhp cyBzZWdmYXVsdHMgaWYgdGhlIGZpZWxkIGRvZXNuJ3QgZXhpc3QuIEl0IHdvdWxkIGJlIG5pY2Vy IHRvDQppZ3RfYXNzZXJ0IHRoYXQgc3RydG9rIGRvZXNuJ3QgcmV0dXJuIE5VTEwuIE1heWJlIHdp dGggYSB3cmFwcGVyDQpmdW5jdGlvbj8gZS5nLg0KDQogICAgc3RhdGljIGludCBwYXJzZV9uZXh0 X3RpbGVfZmllbGQoY2hhciAqZGF0YSkNCg0KQWxzbyB0aGlzIGRvZXNuJ3QgY2hlY2sgZm9yIGlu dGVnZXIgb3ZlcmZsb3dzLCBidXQgbm90IHN1cmUgaXQncyB3b3J0aA0KdGhlIGhhc3NsZS4NCg0K PiArCQl0aWxlLT50aWxlX2lzX3NpbmdsZV9tb25pdG9yID0gYXRvaShzdHJ0b2soTlVMTCwgIjoi KSk7DQo+ICsJCXRpbGUtPm51bV9oX3RpbGUgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4g KwkJdGlsZS0+bnVtX3ZfdGlsZSA9IGF0b2koc3RydG9rKE5VTEwsICI6IikpOw0KPiArCQl0aWxl LT50aWxlX2hfbG9jID0gYXRvaShzdHJ0b2soTlVMTCwgIjoiKSk7DQo+ICsJCXRpbGUtPnRpbGVf dl9sb2MgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gKwkJdGlsZS0+dGlsZV9oX3NpemUg PSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gKwkJdGlsZS0+dGlsZV92X3NpemUgPSBhdG9p KHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gKwl9DQo+ICt9DQo+IGRpZmYgLS1naXQgYS9saWIvaWd0 X2ttcy5oIGIvbGliL2lndF9rbXMuaA0KPiBpbmRleCAwNDg2NzM3Yi4uMDg0ODM1MDUgMTAwNjQ0 DQo+IC0tLSBhL2xpYi9pZ3Rfa21zLmgNCj4gKysrIGIvbGliL2lndF9rbXMuaA0KPiBAQCAtMzg3 LDYgKzM4NywxNCBAQCBzdHJ1Y3QgaWd0X2Rpc3BsYXkgew0KPiAgCWludCBmb3JtYXRfbW9kX2Nv dW50Ow0KPiAgfTsNCj4gIA0KPiArdHlwZWRlZiBzdHJ1Y3Qgew0KPiArCWludCB0aWxlX2dyb3Vw X2lkOw0KPiArCWJvb2wgdGlsZV9pc19zaW5nbGVfbW9uaXRvcjsNCj4gKwl1aW50OF90IG51bV9o X3RpbGUsIG51bV92X3RpbGU7DQo+ICsJdWludDhfdCB0aWxlX2hfbG9jLCB0aWxlX3ZfbG9jOw0K PiArCXVpbnQxNl90IHRpbGVfaF9zaXplLCB0aWxlX3Zfc2l6ZTsNCg0KSSB3b3VsZG4ndCByZXBl YXQgdGhlIHRpbGVfIHByZWZpeCBmb3IgYWxsIG9mIHRoZXNlIGZpZWxkcywgaXQncw0KYWxyZWFk eSBjbGVhciB0aGF0IGl0J3MgYWJvdXQgdGhlIHRpbGUgZnJvbSB0aGUgdHlwZSBuYW1lLg0KDQo+ ICt9IGlndF90aWxlX2luZm9fdDsNCg0KSSdtIHBlcnNvbmFsbHkgbm90IGEgZmFuIG9mIHR5cGVk ZWZzLCBidXQgaXQgc2VlbXMgbGlrZSB0aGUgcmVzdCBvZiBJR1QNCmRvZXNuJ3QgY2FyZSwgc28g aXQncyBwcm9iYWJseSBmaW5lLg0KDQo+ICB2b2lkIGlndF9kaXNwbGF5X3JlcXVpcmUoaWd0X2Rp c3BsYXlfdCAqZGlzcGxheSwgaW50IGRybV9mZCk7DQo+ICB2b2lkIGlndF9kaXNwbGF5X2Zpbmko aWd0X2Rpc3BsYXlfdCAqZGlzcGxheSk7DQo+ICB2b2lkIGlndF9kaXNwbGF5X3Jlc2V0KGlndF9k aXNwbGF5X3QgKmRpc3BsYXkpOw0KPiBAQCAtODM1LDQgKzg0Myw3IEBAIHN0YXRpYyBpbmxpbmUg Ym9vbCBpZ3RfdmJsYW5rX2JlZm9yZSh1aW50MzJfdCBhLCB1aW50MzJfdCBiKQ0KPiAgCXJldHVy biBpZ3RfdmJsYW5rX2FmdGVyKGIsIGEpOw0KPiAgfQ0KPiAgDQo+ICt2b2lkIGlndF9wYXJzZV9j b25uZWN0b3JfdGlsZV9ibG9iKGRybU1vZGVQcm9wZXJ0eUJsb2JQdHIgYmxvYiwNCj4gKwkJCWln dF90aWxlX2luZm9fdCAqIHRpbGUpOw0KPiArDQo+ICAjZW5kaWYgLyogX19JR1RfS01TX0hfXyAq Lw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRl diBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2