Re: [PATCH i-g-t 2/8] tests/intel/i915_pm_rpm: Nuke bogus NULL check

Jani Nikula
2026-01-13T14:31:34Z

On Tue, 13 Jan 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> '&data->display' is never NULL, so don't check for it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> tests/intel/i915_pm_rpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/i915_pm_rpm.c b/tests/intel/i915_pm_rpm.c
> index 778f46dbcfb9..b4da27b21b20 100644
> --- a/tests/intel/i915_pm_rpm.c
> +++ b/tests/intel/i915_pm_rpm.c
> @@ -356,7 +356,7 @@ static bool init_modeset_params_for_type(struct mode_set_data *data,
> igt_output_t *output = NULL;
> igt_display_t *display = &data->display;
>
> - if (!data->res || !display)
> + if (!data->res)
> return false;
>
> for_each_connected_output(display, output) {

--
Jani Nikula, Intel