Re: [PATCH i-g-t, v3 1/5] lib/igt_hdr: Move HDR helpers from kms_hdr into shared library

[Alex Hung <alex.hung@amd.com>]

On 4/17/26 15:38, Swati Sharma wrote:
> +void igt_hdr_disable(igt_output_t *output)
> +{
> +	igt_hdr_set_metadata(output, NULL);
> +	igt_output_set_prop_value(output, IGT_CONNECTOR_MAX_BPC, 8);
> +}
> +
> +void igt_hdr_enable(igt_output_t *output)
> +{
> +	struct hdr_output_metadata meta;
> +
> +	/* Fill HDR metadata and enable it on the output */
> +	igt_hdr_fill_st2084(&meta);
> +	igt_hdr_set_metadata(output, &meta);
> +	igt_output_set_prop_value(output, IGT_CONNECTOR_MAX_BPC, 10);
> +}

There are warnings during compilation, and there are fixed by PATCH 4 
"lib/igt_hdr: Add helpers to enable and disable HDR on an output".

[11/927] Compiling C object lib/libigt-igt_hdr_c.a.p/igt_hdr.c.o
../lib/igt_hdr.c:203:6: warning: no previous prototype for 
‘igt_hdr_disable’ [-Wmissing-prototypes]
   203 | void igt_hdr_disable(igt_output_t *output)
       |      ^~~~~~~~~~~~~~~
../lib/igt_hdr.c:209:6: warning: no previous prototype for 
‘igt_hdr_enable’ [-Wmissing-prototypes]
   209 | void igt_hdr_enable(igt_output_t *output)
       |      ^~~~~~~~~~~~~~

How about squashing patch 4 to patch 1?