Re: [PATCH i-g-t] tests/intel/kms_pm_rpm: Fix cursor_fb3 framebuffer creation format

["Sharma, Swati2" <swati2.sharma@intel.com>]

On 22-11-2024 11:11 am, Samala, Pranay wrote:

> Hi Jeevan,
>
> Add bspec id. in commit message.
Hi Pranay,
Here there is no need to specify bspec id since its a generic change, 
nothing specific to

platform.

Jeevan,

You can update subject, here nothing is being fixed. You are just 
updating fb format,
since there is no specific need to use X tile.
>
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Jeevan B
>> Sent: Friday, November 22, 2024 9:40 AM
>> To: igt-dev@lists.freedesktop.org
>> Cc: B S, Karthik <karthik.b.s@intel.com>; B, Jeevan <jeevan.b@intel.com>
>> Subject: [PATCH i-g-t] tests/intel/kms_pm_rpm: Fix cursor_fb3 framebuffer
>> creation format
>>
>> Updated cursor_fb3 framebuffer creation in the cursor subtest function to use
>> linear tiling instead of x-tile. As x-tile is no longer supported on latest platforms.
>>
>> Signed-off-by: Jeevan B <jeevan.b@intel.com>
>> ---
>>   tests/intel/kms_pm_rpm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/intel/kms_pm_rpm.c b/tests/intel/kms_pm_rpm.c index
>> 990c50915..aeeaf69f7 100644
>> --- a/tests/intel/kms_pm_rpm.c
>> +++ b/tests/intel/kms_pm_rpm.c
>> @@ -1199,7 +1199,7 @@ static void cursor_subtest(bool dpms)
>>   	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>>   		      DRM_FORMAT_MOD_LINEAR, &cursor_fb2);
>>   	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_XRGB8888,
>> -		      I915_FORMAT_MOD_X_TILED, &cursor_fb3);
>> +		      DRM_FORMAT_MOD_LINEAR, &cursor_fb3);
>>
>>   	fill_igt_fb(&cursor_fb1, 0xFF00FFFF);
>>   	fill_igt_fb(&cursor_fb2, 0xFF00FF00);
>> --
>> 2.25.1