From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
Subject: Re: [igt-dev] [PATCH] tests/i915/pxp: test_pxp_stale_buf_optout_execution requires arb session
Date: Tue, 14 Feb 2023 16:45:15 +0000 [thread overview]
Message-ID: <6b6936e0940a18cf9e8a6087783a9f78e2984f7d.camel@intel.com> (raw)
In-Reply-To: <8e12e09c-bcdc-921e-0887-77de5d510c11@intel.com>
On Mon, 2023-02-13 at 15:30 -0800, Ceraolo Spurio, Daniele wrote:
>
> On 2/7/2023 10:24 PM, Alan Previn wrote:
> > Subtest 'test_pxp_stale_buf_optout_execution' when run on its own,
> > could be executing without the PXP Arb session being alive. This
> > would result in the termination trigger to fail (when writing to
> > the pxp termination debugfs).
> >
> > Create a background protected context to start the Arb session so
> > the simulated termination will succeed.
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > + prepare_exec_assets(i915, &data2, true, true);
>
alan:snip
> Since you only need the context, wouldn't a call to
> create_ctx_with_params be more appropriate here? that way we don't have
> to allocate all the extra stuff.
>
> Daniele
>
good point - yes we can use that - will re-rev.
prev parent reply other threads:[~2023-02-14 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 6:24 [igt-dev] [PATCH] tests/i915/pxp: test_pxp_stale_buf_optout_execution requires arb session Alan Previn
2023-02-08 17:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-08 19:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-02-13 23:30 ` [igt-dev] [PATCH] " Ceraolo Spurio, Daniele
2023-02-14 16:45 ` Teres Alexis, Alan Previn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b6936e0940a18cf9e8a6087783a9f78e2984f7d.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox