Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: Hersen Wu <hersenxs.wu@amd.com>,
	igt-dev@lists.freedesktop.org, rodrigo.siqueira@amd.com,
	aurabindo.pillai@amd.com, stylon.wang@amd.com,
	hamza.mahfooz@amd.com
Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_bypass: Skip test when DP Rx output bpc < 8 bpc
Date: Tue, 20 Jun 2023 16:28:14 -0600	[thread overview]
Message-ID: <6b92bde7-a8ab-f40f-1975-748aff4d9914@amd.com> (raw)
In-Reply-To: <20230620212035.147910-1-hersenxs.wu@amd.com>

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 2023-06-20 15:20, Hersen Wu wrote:
> Check DP or eDP Rx output bpc, skip test when output bpc is
> less than 8bpc.
> 
> This test compares CRC of CRTC and Rx. It needs both CRTC_CRC
> and Rx-CRC with 8bpc. If CRTC-CRC with 8bpc, but Rx-CRC with
> 6bpc, then their values  will not match.
> 
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
>   tests/amdgpu/amd_bypass.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tests/amdgpu/amd_bypass.c b/tests/amdgpu/amd_bypass.c
> index d191779b0..d192a30ea 100644
> --- a/tests/amdgpu/amd_bypass.c
> +++ b/tests/amdgpu/amd_bypass.c
> @@ -331,6 +331,13 @@ static void bypass_8bpc_test(data_t *data)
>   	igt_skip_on_f(igt_amd_read_dsc_clock_status(data->drm_fd, data->output->name) == 1,
>   		      "DSC enabled on %s and no sense to validate bypass mode\n", data->output->name);
>   
> +	/* 8bpc bypass only valid when DP or eDP Rx supports 8bpc or up. When
> +	 * Rx supports only up to 6bpc, Rx-crc will different from crtc-crc
> +	 * with 8bpc.
> +	 */
> +	igt_skip_on_f(igt_get_output_max_bpc(data->drm_fd, data->output->name) <= 6,
> +		      "check /sys/kernel/debug/dri/0/eDP-1 (connector)/output_bpc\n");
> +
>   	igt_create_fb(data->drm_fd, data->width, data->height,
>   		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
>   

  reply	other threads:[~2023-06-20 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 21:20 [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_bypass: Skip test when DP Rx output bpc < 8 bpc Hersen Wu
2023-06-20 22:28 ` Alex Hung [this message]
2023-06-20 23:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-21  8:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b92bde7-a8ab-f40f-1975-748aff4d9914@amd.com \
    --to=alex.hung@amd.com \
    --cc=aurabindo.pillai@amd.com \
    --cc=hamza.mahfooz@amd.com \
    --cc=hersenxs.wu@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=rodrigo.siqueira@amd.com \
    --cc=stylon.wang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox