From: "Kempczynski, Zbigniew" <zbigniew.kempczynski@intel.com>
To: "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [RFC] IGT device scanning and selection
Date: Tue, 4 Jun 2019 08:47:12 +0000 [thread overview]
Message-ID: <6bb5d8cf375fc1ce0f8afdddddbde87866c11b9e.camel@intel.com> (raw)
In-Reply-To: <20190604083615.s5mqxncl6nulz4lw@ahiler-desk1.fi.intel.com>
On Tue, 2019-06-04 at 11:36 +0300, Arkadiusz Hiler wrote:
>
> Hey,
>
> Seems like a well-written verbalization of some of the ideas that were
> floating around since XDC. Thanks!
>
>
> Couple of points that were not captured here:
>
> 1. We should have an option to set device via .igtrc and IGT_DEVICE env
> variable too. ENV variable would take precedence over .igtrc, and
> --device switch would take precedence over both of the other methods.
>
> That would help a lot with both automatization and having some defaults
> for local development.
Acked. I'll follow this override path.
>
>
> 2. What to do with drm_open_driver(DRIVER_INTEL) et al?
>
> Simplest solution would be to just skip if we are --device-ing a card
> that does not meet those "constraints", but we may want to rework those
> a bit?
>
IMHO --device specification should override this vendor requirement
constraint. Using globals is not pretty solution but allows easily
adds new device selection without rewritting all tests.
Best,
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-04 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 8:09 [igt-dev] [RFC] IGT device scanning and selection Kempczynski, Zbigniew
2019-06-04 8:29 ` Ser, Simon
2019-06-04 9:10 ` Michał Winiarski
2019-06-04 8:36 ` Arkadiusz Hiler
2019-06-04 8:47 ` Kempczynski, Zbigniew [this message]
2019-06-05 12:31 ` Daniel Vetter
2019-06-05 12:35 ` Daniel Vetter
2019-06-06 9:35 ` Kempczynski, Zbigniew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bb5d8cf375fc1ce0f8afdddddbde87866c11b9e.camel@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox