Re: [igt-dev] [PATCH i-g-t] lib/i915: Add a helper lib to read mmio registers via ioctl

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Fri, 2023-08-25 at 10:25 -0700, Teres Alexis, Alan Previn wrote:
> > > -	do_ioctl(drm_fd, DRM_IOCTL_I915_REG_READ, &rr);
> > > +	i915_reg_read_ioctl(drm_fd, 0x2358, &val);
> > ----------------------------------- ^^^^^^
> > Maybe define it at i915_mmio_reg.h ?
> > 
> > #define MMIO_REG_RENDER_RING_TIMESTAMP 0x2358
> > 
> alan: yes - my bad - i should have done that up front.
Just realized this thing is used/defined in a few places (below is the grep)
but i guess the right place would be lib/intel_reg.h with all the others?
I also feel we dont need the "MMIO_REG" in front (like others in intel_reg.h).
I'll re-rev and we can take a 2nd look. Thanks in advance.

   tests/i915/i915_pm_rpm.c:1862:	i915_reg_read_ioctl(drm_fd, 0x2358, &val);
   tests/i915/gem_reg_read.c:57:#define RENDER_RING_TIMESTAMP 0x2358
   tests/i915/gem_ctx_isolation.c:230:	{ "RCS timestamp", GEN6, ~0u, 0x2358 },
   
   tests/xe/xe_mmio.c:23:#define RCS_TIMESTAMP 0x2358
   
   lib/intel_reg.h:462:#define TIMESTAMP_QW           0x2358
   tools/intel_forcewaked.c:62:	return (intel_register_read(mmio_data, 0x2358) != 0);
   tools/i915-perf/i915_perf_recorder.c:626:#define RENDER_RING_TIMESTAMP 0x2358