From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190424153936.21279-1-chris@chris-wilson.co.uk> <20190424154722.24100-1-chris@chris-wilson.co.uk> From: Daniele Ceraolo Spurio Message-ID: <6cd5c83f-83a4-3d1a-73a9-28fecb61eb8b@intel.com> Date: Wed, 24 Apr 2019 10:53:08 -0700 MIME-Version: 1.0 In-Reply-To: <20190424154722.24100-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Check deps along implicit inter-engine semaphores List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Matthew Brost List-ID: CgpPbiA0LzI0LzE5IDg6NDcgQU0sIENocmlzIFdpbHNvbiB3cm90ZToKPiBHaXZlbiBhbiBpbXBs aWNpdCBzZW1hcGhvcmUgZnJvbSBvbmUgZW5naW5lIHRvIHRoZSBuZXh0LCBjaGVjayB0aGF0IGlm Cj4gd2Ugc2tpcCB0aGUgd2FpdCBvbiB0aGF0IHNlbWFwaG9yZSB0aGUgZm9sbG93aW5nIGJhdGNo IGFsdGhvdWdoCj4gc3VibWl0dGVkIGVhcmx5IChhcyBpdCBkZXBlbmRzIGFsb25nIHRoZSBzaW5n bGUgZW5naW5lIHRpbWVsaW5lKSBpcyBub3QKPiBleGVjdXRlZCBhaGVhZCBvZiBpdHMgZGVwZW5k ZW5jeS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1 cmlvQGludGVsLmNvbT4KPiBDYzogTWF0dGhldyBCcm9zdCA8bWF0dGhldy5icm9zdEBpbnRlbC5j b20+CgpSZXZpZXdlZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xv c3B1cmlvQGludGVsLmNvbT4KCnNvbWUgbml0cGlja3MgYmVsb3cuCgo+IC0tLQo+IE1ha2Ugc3Vy ZSB0aGVyZSBpcyBhY3R1YWxseSBhIHNlbWFwaG9yZSAocmVhZC1yZWFkIGRvZXNuJ3QgZ2VuZXJh dGUgYW4KPiBpbnRlcmVuZ2luZSBkZXBlbmRlbmN5ISkKPiAtLS0KPiAgIHRlc3RzL2k5MTUvZ2Vt X2V4ZWNfc2NoZWR1bGUuYyB8IDc1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK PiAgIDEgZmlsZSBjaGFuZ2VkLCA3NSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL3Rl c3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYyBiL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1 bGUuYwo+IGluZGV4IDM1OTBiNzM5YS4uYTZiNzRiM2I2IDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2k5 MTUvZ2VtX2V4ZWNfc2NoZWR1bGUuYwo+ICsrKyBiL3Rlc3RzL2k5MTUvZ2VtX2V4ZWNfc2NoZWR1 bGUuYwo+IEBAIC02MDMsNiArNjAzLDc5IEBAIHN0YXRpYyB2b2lkIHNlbWFwaG9yZV9yZXNvbHZl KGludCBpOTE1KQo+ICAgCWdlbV9jb250ZXh0X2Rlc3Ryb3koaTkxNSwgb3V0ZXIpOwo+ICAgfQo+ ICAgCj4gK3N0YXRpYyB2b2lkIHNlbWFwaG9yZV9ub3NraXAoaW50IGk5MTUpCj4gK3sKPiArCXVu c2lnbmVkIGludCBlbmdpbmUsIG90aGVyOwo+ICsJdWludDMyX3QgY3R4Owo+ICsKPiArCWlndF9h c3NlcnQoaW50ZWxfZ2V0X2RybV9kZXZpZChpOTE1KSA+PSA4KTsKCkkgd291bGQgbW92ZSB0aGlz IHRvIGlndF9yZXF1aXJlIHNpbmNlIHRoZSBzdWJ0ZXN0X2dyb3VwIG9ubHkgcmVxdWlyZXMgCnNj aGVkdWxlciAmIHByaW9yaXR5IGFuZCBldmVuIGlmIHdlIGN1cnJlbnRseSBkb24ndCBlbmFibGUg dGhvc2UgCnByZS1nZW44IEkgZG9uJ3QgdGhpbmsgd2UgY2FuIGFzc3VtZSB3ZSBuZXZlciB3aWxs LgoKPiArCj4gKwljdHggPSBnZW1fY29udGV4dF9jcmVhdGUoaTkxNSk7Cj4gKwo+ICsJZm9yX2Vh Y2hfcGh5c2ljYWxfZW5naW5lKGk5MTUsIGVuZ2luZSkgewo+ICsJZm9yX2VhY2hfcGh5c2ljYWxf ZW5naW5lKGk5MTUsIG90aGVyKSB7CgpJcyBpdCB3b3J0aCBoaWRpbmcgdGhlIGRvdWJsZSBsb29w IGluIGl0cyBvd24gbWFjcm8/IGUuZy46Cgpmb3JfZWFjaF9waHlzaWNhbF9lbmdpbmVfcGFpcihp OTE1LCBlbmdpbmUxLCBlbmdpbmUyKQoKPiArCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNfb2Jq ZWN0MiBvYmpbM107Cj4gKwkJc3RydWN0IGRybV9pOTE1X2dlbV9leGVjYnVmZmVyMiBlYjsKPiAr CQlpZ3Rfc3Bpbl90ICpjaGFpbiwgKnNwaW47Cj4gKwkJdWludDMyX3QgaGFuZGxlLCBjYW5jZWw7 Cj4gKwkJdWludDMyX3QgKmNzLCAqbWFwOwo+ICsKPiArCQlpZiAob3RoZXIgPT0gZW5naW5lIHx8 ICFnZW1fY2FuX3N0b3JlX2R3b3JkKGk5MTUsIG90aGVyKSkKPiArCQkJY29udGludWU7Cj4gKwo+ ICsJCWNoYWluID0gX19pZ3Rfc3Bpbl9uZXcoaTkxNSwgLmVuZ2luZSA9IGVuZ2luZSk7Cj4gKwo+ ICsJCXNwaW4gPSBfX2lndF9zcGluX25ldyhpOTE1LCAuZW5naW5lID0gb3RoZXIpOwo+ICsJCWln dF9zcGluX2VuZChzcGluKTsgLyogd2UganVzdCB3YW50IGl0cyBhZGRyZXNzIGZvciBsYXRlciAq Lwo+ICsJCWdlbV9zeW5jKGk5MTUsIHNwaW4tPmhhbmRsZSk7Cj4gKwkJaWd0X3NwaW5fcmVzZXQo c3Bpbik7Cj4gKwo+ICsJCWhhbmRsZSA9IGdlbV9jcmVhdGUoaTkxNSwgNDA5Nik7Cj4gKwkJY3Mg PSBtYXAgPSBnZW1fbW1hcF9fY3B1KGk5MTUsIGhhbmRsZSwgMCwgNDA5NiwgUFJPVF9XUklURSk7 Cj4gKwo+ICsJCS8qIENhbmNlbCB0aGUgZm9sbG93aW5nIHNwaW5uZXIgKi8KPiArCQkqY3MrKyA9 IE1JX1NUT1JFX0RXT1JEX0lNTTsKPiArCQkqY3MrKyA9IHNwaW4tPm9ialsxXS5vZmZzZXQgKyBv ZmZzZXRfaW5fcGFnZShzcGluLT5jb25kaXRpb24pOwo+ICsJCSpjcysrID0gMDsKPiArCQkqY3Mr KyA9IE1JX0JBVENIX0JVRkZFUl9FTkQ7Cj4gKwo+ICsJCSpjcysrID0gTUlfQkFUQ0hfQlVGRkVS X0VORDsKPiArCQltdW5tYXAobWFwLCA0MDk2KTsKPiArCj4gKwkJbWVtc2V0KG9iaiwgMCwgc2l6 ZW9mKG9iaikpOwo+ICsJCW9ialswXSA9IGNoYWluLT5vYmpbMV07Cj4gKwkJb2JqWzBdLmZsYWdz IHw9IEVYRUNfT0JKRUNUX1dSSVRFOwo+ICsJCW9ialsxXSA9IHNwaW4tPm9ialsxXTsKPiArCQlv YmpbMl0uaGFuZGxlID0gaGFuZGxlOwo+ICsJCW1lbXNldCgmZWIsIDAsIHNpemVvZihlYikpOwo+ ICsJCWViLmJ1ZmZlcl9jb3VudCA9IDM7Cj4gKwkJZWIuYnVmZmVyc19wdHIgPSB0b191c2VyX3Bv aW50ZXIob2JqKTsKPiArCQllYi5yc3ZkMSA9IGN0eDsKPiArCQllYi5mbGFncyA9IG90aGVyOwo+ ICsJCWdlbV9leGVjYnVmKGk5MTUsICZlYik7Cj4gKwo+ICsJCW1lbXNldChvYmosIDAsIHNpemVv ZihvYmopKTsKPiArCQlvYmpbMF0uaGFuZGxlID0gaGFuZGxlOwo+ICsJCW9ialswXS5mbGFncyA9 IEVYRUNfT0JKRUNUX1dSSVRFOwo+ICsJCW9ialsxXSA9IHNwaW4tPm9ialsxXTsKPiArCQltZW1z ZXQoJmViLCAwLCBzaXplb2YoZWIpKTsKPiArCQllYi5idWZmZXJfY291bnQgPSAyOwo+ICsJCWVi LmJ1ZmZlcnNfcHRyID0gdG9fdXNlcl9wb2ludGVyKG9iaik7Cj4gKwkJZWIuZmxhZ3MgPSBvdGhl cjsKPiArCQlnZW1fZXhlY2J1ZihpOTE1LCAmZWIpOwo+ICsKPiArCQlpZ3Rfc3Bpbl9zZXRfdGlt ZW91dChjaGFpbiwgTlNFQ19QRVJfU0VDIC8gMTAwKTsKPiArCQlnZW1fc3luYyhpOTE1LCBzcGlu LT5oYW5kbGUpOyAvKiBUbyBoYW5nIHVubGVzcyBjYW5jZWwgcnVucyEgKi8KPiArCj4gKwkJZ2Vt X2Nsb3NlKGk5MTUsIGhhbmRsZSk7Cj4gKwkJaWd0X3NwaW5fZnJlZShpOTE1LCBzcGluKTsKPiAr CQlpZ3Rfc3Bpbl9mcmVlKGk5MTUsIGNoYWluKTsKPiArCX0KPiArCX0KPiArCj4gKwlnZW1fY29u dGV4dF9kZXN0cm95KGk5MTUsIGN0eCk7Cj4gK30KPiArCj4gICBzdGF0aWMgdm9pZCByZW9yZGVy KGludCBmZCwgdW5zaWduZWQgcmluZywgdW5zaWduZWQgZmxhZ3MpCj4gICAjZGVmaW5lIEVRVUFM IDEKPiAgIHsKPiBAQCAtMTU5Miw2ICsxNjY1LDggQEAgaWd0X21haW4KPiAgIAkJCXNlbWFwaG9y ZV9jb2RlcGVuZGVuY3koZmQpOwo+ICAgCQlpZ3Rfc3VidGVzdCgic2VtYXBob3JlLXJlc29sdmUi KQo+ICAgCQkJc2VtYXBob3JlX3Jlc29sdmUoZmQpOwoKc2VtYXBob3JlX3Jlc29sdmUgaXNuJ3Qg bWVyZ2VkIHlldCA7KQoKRGFuaWVsZQoKPiArCQlpZ3Rfc3VidGVzdCgic2VtYXBob3JlLW5vc2tp cCIpCj4gKwkJCXNlbWFwaG9yZV9ub3NraXAoZmQpOwo+ICAgCj4gICAJCWlndF9zdWJ0ZXN0KCJz bW9rZXRlc3QtYWxsIikKPiAgIAkJCXNtb2tldGVzdChmZCwgQUxMX0VOR0lORVMsIDMwKTsKPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2