From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 533526EE76 for ; Sat, 27 Jul 2019 00:23:31 +0000 (UTC) References: <20190725203354.6757-1-lucas.demarchi@intel.com> <20190725203354.6757-5-lucas.demarchi@intel.com> From: Daniele Ceraolo Spurio Message-ID: <6d03eb5a-4b7a-5258-d93f-65b6cf54ad98@intel.com> Date: Fri, 26 Jul 2019 17:23:17 -0700 MIME-Version: 1.0 In-Reply-To: <20190725203354.6757-5-lucas.demarchi@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lucas De Marchi , igt-dev@lists.freedesktop.org List-ID: CgpPbiA3LzI1LzE5IDE6MzMgUE0sIEx1Y2FzIERlIE1hcmNoaSB3cm90ZToKPiBHZW4gMTIgYW5k IGxhdGVyIG9ubHkgaGF2ZSBnbG9iYWwgTU9DUzogdXNlIHRoZSBuZXcgb2Zmc2V0Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgoK UmV2aWV3ZWQtYnk6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJp b0BpbnRlbC5jb20+CgpEYW5pZWxlCgo+IC0tLQo+ICAgdGVzdHMvaTkxNS9nZW1fbW9jc19zZXR0 aW5ncy5jIHwgMTcgKysrKysrKysrKysrKy0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9pOTE1L2dl bV9tb2NzX3NldHRpbmdzLmMgYi90ZXN0cy9pOTE1L2dlbV9tb2NzX3NldHRpbmdzLmMKPiBpbmRl eCA5ZWMwYjEyMi4uM2E1OTMyMTkgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMvaTkxNS9nZW1fbW9jc19z ZXR0aW5ncy5jCj4gKysrIGIvdGVzdHMvaTkxNS9nZW1fbW9jc19zZXR0aW5ncy5jCj4gQEAgLTYz LDYgKzYzLDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKiBjb25zdCB0ZXN0X21vZGVzW10gPSB7Cj4g ICAjZGVmaW5lIEdFTjlfTUZYMV9NT0NTXzAJKDB4Y0EwMCkJLyogTWVkaWEgMSBNT0NTIGJhc2Ug cmVnaXN0ZXIqLwo+ICAgI2RlZmluZSBHRU45X1ZFQk9YX01PQ1NfMAkoMHhjQjAwKQkvKiBWaWRl byBNT0NTIGJhc2UgcmVnaXN0ZXIqLwo+ICAgI2RlZmluZSBHRU45X0JMVF9NT0NTXzAJCSgweGNj MDApCS8qIEJsaXR0ZXIgTU9DUyBiYXNlIHJlZ2lzdGVyKi8KPiArI2RlZmluZSBHRU4xMl9HTE9C QUxfTU9DUwkoMHg0MDAwKQo+ICAgI2RlZmluZSBJQ0VMQUtFX01PQ1NfUFRFCXsweDAwMDAwMDA0 LCAweDAwMzAsIDB4MX0KPiAgICNkZWZpbmUgTU9DU19QVEUJCXsweDAwMDAwMDM4LCAweDAwMzAs IDB4MX0KPiAgIAo+IEBAIC0xNjUsNiArMTY2LDExIEBAIHN0YXRpYyBjb25zdCB1aW50MzJfdCB3 cml0ZV92YWx1ZXNbR0VOOV9OVU1fTU9DU19FTlRSSUVTXSA9IHsKPiAgIAlbMCAuLi4gR0VOOV9O VU1fTU9DU19FTlRSSUVTIC0gMV0gPSAweEZGRkZGRkZGLAo+ICAgfTsKPiAgIAo+ICtzdGF0aWMg Ym9vbCBoYXNfZ2xvYmFsX21vY3MoaW50IGZkKQo+ICt7Cj4gKwlyZXR1cm4gaW50ZWxfZ2VuKGlu dGVsX2dldF9kcm1fZGV2aWQoZmQpKSA+PSAxMjsKPiArfQo+ICsKPiAgIHN0YXRpYyBib29sIGdl dF9tb2NzX3NldHRpbmdzKGludCBmZCwgc3RydWN0IG1vY3NfdGFibGUgKnRhYmxlLCBib29sIGRp cnR5KQo+ICAgewo+ICAgCXVpbnQzMl90IGRldmlkID0gaW50ZWxfZ2V0X2RybV9kZXZpZChmZCk7 Cj4gQEAgLTIwNCw4ICsyMTAsMTEgQEAgc3RhdGljIGJvb2wgZ2V0X21vY3Nfc2V0dGluZ3MoaW50 IGZkLCBzdHJ1Y3QgbW9jc190YWJsZSAqdGFibGUsIGJvb2wgZGlydHkpCj4gICAjZGVmaW5lIExP Q0FMX0k5MTVfRVhFQ19CU0QxIChJOTE1X0VYRUNfQlNEIHwgKDE8PDEzKSkKPiAgICNkZWZpbmUg TE9DQUxfSTkxNV9FWEVDX0JTRDIgKEk5MTVfRVhFQ19CU0QgfCAoMjw8MTMpKQo+ICAgCj4gLXN0 YXRpYyB1aW50MzJfdCBnZXRfZW5naW5lX2Jhc2UodWludDMyX3QgZW5naW5lKQo+ICtzdGF0aWMg dWludDMyX3QgZ2V0X2VuZ2luZV9iYXNlKGludCBmZCwgdWludDMyX3QgZW5naW5lKQo+ICAgewo+ ICsJaWYgKGhhc19nbG9iYWxfbW9jcyhmZCkpCj4gKwkJcmV0dXJuIEdFTjEyX0dMT0JBTF9NT0NT Owo+ICsKPiAgIAlzd2l0Y2ggKGVuZ2luZSkgewo+ICAgCWNhc2UgTE9DQUxfSTkxNV9FWEVDX0JT RDE6CXJldHVybiBHRU45X01GWDBfTU9DU18wOwo+ICAgCWNhc2UgTE9DQUxfSTkxNV9FWEVDX0JT RDI6CXJldHVybiBHRU45X01GWDFfTU9DU18wOwo+IEBAIC0zMzksNyArMzQ4LDcgQEAgc3RhdGlj IHZvaWQgY2hlY2tfY29udHJvbF9yZWdpc3RlcnMoaW50IGZkLAo+ICAgCQkJCSAgICB1aW50MzJf dCBjdHhfaWQsCj4gICAJCQkJICAgIGJvb2wgZGlydHkpCj4gICB7Cj4gLQljb25zdCB1aW50MzJf dCByZWdfYmFzZSA9IGdldF9lbmdpbmVfYmFzZShlbmdpbmUpOwo+ICsJY29uc3QgdWludDMyX3Qg cmVnX2Jhc2UgPSBnZXRfZW5naW5lX2Jhc2UoZmQsIGVuZ2luZSk7Cj4gICAJdWludDMyX3QgZHN0 X2hhbmRsZSA9IGdlbV9jcmVhdGUoZmQsIDQwOTYpOwo+ICAgCXVpbnQzMl90ICpyZWFkX3JlZ3M7 Cj4gICAJc3RydWN0IG1vY3NfdGFibGUgdGFibGU7Cj4gQEAgLTQ2Nyw3ICs0NzYsNyBAQCBzdGF0 aWMgdm9pZCB3cml0ZV9kaXJ0eV9tb2NzKGludCBmZCwKPiAgIAllbHNlCj4gICAJCW51bV9vZl9t b2NzX2VudHJpZXMgPSBHRU45X05VTV9NT0NTX0VOVFJJRVM7Cj4gICAKPiAtCXdyaXRlX3JlZ2lz dGVycyhmZCwgY3R4X2lkLCBnZXRfZW5naW5lX2Jhc2UoZW5naW5lKSwKPiArCXdyaXRlX3JlZ2lz dGVycyhmZCwgY3R4X2lkLCBnZXRfZW5naW5lX2Jhc2UoZmQsIGVuZ2luZSksCj4gICAJCQl3cml0 ZV92YWx1ZXMsIG51bV9vZl9tb2NzX2VudHJpZXMsCj4gICAJCQllbmdpbmUsIHByaXZpbGVnZWQp Owo+ICAgCj4gQEAgLTQ5NCw3ICs1MDMsNyBAQCBzdGF0aWMgdm9pZCBydW5fdGVzdChpbnQgZmQs IHVuc2lnbmVkIGVuZ2luZSwgdW5zaWduZWQgZmxhZ3MsIHVuc2lnbmVkIG1vZGUpCj4gICAJZ2Vt X3JlcXVpcmVfcmluZyhmZCwgZW5naW5lKTsKPiAgIAo+ICAgCS8qIFNraXAgaWYgd2UgZG9uJ3Qg a25vdyB3aGVyZSB0aGUgcmVnaXN0ZXJzIGFyZSBmb3IgdGhpcyBlbmdpbmUgKi8KPiAtCWlndF9y ZXF1aXJlKGdldF9lbmdpbmVfYmFzZShlbmdpbmUpKTsKPiArCWlndF9yZXF1aXJlKGdldF9lbmdp bmVfYmFzZShmZCwgZW5naW5lKSk7Cj4gICAKPiAgIAlpZiAoZmxhZ3MgJiBNT0NTX05PTl9ERUZB VUxUX0NUWCkKPiAgIAkJY3R4X2lkID0gZ2VtX2NvbnRleHRfY3JlYXRlKGZkKTsKPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2