From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3FCD6E116 for ; Tue, 21 Apr 2020 18:30:07 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id f13so17651603wrm.13 for ; Tue, 21 Apr 2020 11:30:07 -0700 (PDT) References: <20200421161725.12249-1-juhapekka.heikkila@gmail.com> <20200421161725.12249-8-juhapekka.heikkila@gmail.com> <158749264502.11203.2272792297388581562@build.alporthouse.com> From: Juha-Pekka Heikkila Message-ID: <6df922c2-fead-47b2-a447-7d224803cff6@gmail.com> Date: Tue, 21 Apr 2020 21:30:00 +0300 MIME-Version: 1.0 In-Reply-To: <158749264502.11203.2272792297388581562@build.alporthouse.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 7/8] lib/debugfs: use regular module param functions for prefault_disable List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , igt-dev@lists.freedesktop.org Cc: Jani Nikula List-ID: On 21.4.2020 21.10, Chris Wilson wrote: > Quoting Juha-Pekka Heikkila (2020-04-21 17:17:24) >> From: Jani Nikula >> >> Functional change switches from igt_require to igt_assert on errors. > > Adding entirely unused functions for fun? That probably is from legacy, Jani's igt branch that I took was not very new. Chris, you have opinion about patch 6/8 on what's going on there? There's in __igt_params_open(..) those two blocks of file checking which on first block is checking if wanted parameter file is in selected device directory and second block is just about 'guessing' default device name. I'm somehow thinking there would be easier way for those but I didn't find other way so I ended up reading and parsing files. It seems to work but not feeling comfortable with it. /Juha-Pekka _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev