Re: [igt-dev] [PATCH i-g-t 1/8] lib/params: add igt_params.c for module parameter access

Juha-Pekka Heikkila
2020-04-22T08:13:52Z

On 22.4.2020 11.02, Petri Latvala wrote:
> On Tue, Apr 21, 2020 at 07:17:18PM +0300, Juha-Pekka Heikkila wrote:
>> From: Jani Nikula <jani.nikula@intel.com>
>>
>> We have generic helpers for sysfs access in igt_sysfs.c, but we also
>> have a number of module parameter access specific helpers scattered here
>> and there. Start gathering the latter into a file of its own.
>>
>> For i915, the long-term goal is to migrate from module parameters to
>> device specific debugfs parameters. With all igt module param access
>> centralized in one place, we can make the transition much easier.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>
>
> This patch is just moving code around without functional changes,
> correct?

Yes, it's correct. It's just buildup for those changes that follow in
those other patches.

>
>
>> diff --git a/lib/meson.build b/lib/meson.build
>> index e2060430..c9af0403 100644
>> --- a/lib/meson.build
>> +++ b/lib/meson.build
>> @@ -17,6 +17,7 @@ lib_sources = [
>> 'igt_halffloat.c',
>> 'igt_matrix.c',
>> 'igt_perf.c',
>> + 'igt_params.c',
>> 'igt_primes.c',
>> 'igt_rand.c',
>> 'igt_rapl.c',
>
> Alphabetical ordering is off-by-one here.

I'll rearrange.