Re: [igt-dev] [PATCH i-g-t 7/8] lib/debugfs: use regular module param functions for prefault_disable

Chris Wilson
2020-04-21T18:36:37Z

Quoting Juha-Pekka Heikkila (2020-04-21 19:30:00)
> On 21.4.2020 21.10, Chris Wilson wrote:
> > Quoting Juha-Pekka Heikkila (2020-04-21 17:17:24)
> >> From: Jani Nikula <jani.nikula@intel.com>
> >>
> >> Functional change switches from igt_require to igt_assert on errors.
> >
> > Adding entirely unused functions for fun?
>
> That probably is from legacy, Jani's igt branch that I took was not very
> new.
>
> Chris, you have opinion about patch 6/8 on what's going on there?
> There's in __igt_params_open(..) those two blocks of file checking which
> on first block is checking if wanted parameter file is in selected
> device directory and second block is just about 'guessing' default
> device name. I'm somehow thinking there would be easier way for those
> but I didn't find other way so I ended up reading and parsing files. It
> seems to work but not feeling comfortable with it.

Heh, not guilty of igt_set_module_param(). I would rip out any implicit
device lookup and make sure there's always a device fd to work with. If
that is not possible, then make the module name a parameter.
-Chris