From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Naladala Ramanaidu <ramanaidu.naladala@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v1 2/5] tests/kms_plane_scaling: Add informative logs for single plane scaling operations
Date: Tue, 10 Sep 2024 13:12:02 +0530 [thread overview]
Message-ID: <6e3a3404-402c-4414-8043-609d0257f52e@intel.com> (raw)
In-Reply-To: <20240905145038.1569226-3-ramanaidu.naladala@intel.com>
Hi Ramanaidu,
On 05-Sep-24 8:20 PM, Naladala Ramanaidu wrote:
> This will adds informative logging to the kms_plane_scaling test
> Logs indicating which output is being tried for scaling. When a
> required scaling operation is not supported on a particular output
> and the test is moving to the next output.
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> ---
> tests/kms_plane_scaling.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 5c5837a51..f03a73a5e 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -1359,6 +1359,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> for_each_pipe(&data.display, pipe) {
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> for_each_valid_output_on_pipe(&data.display, pipe, output) {
> + igt_info("Trying on %s\n", igt_output_name(output));
> if (!pipe_output_combo_valid(&data.display, pipe, output))
> continue;
> if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1370,6 +1371,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> pipe, output);
> if (ret == 0)
> break;
> + igt_info("Required Scaling operation not supported on %s trying on next output\n",
Nitpick: s/Scaling/scaling
Please make this change in all igt_info()
With this fixed.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
> + igt_output_name(output));
> }
> igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> "Unsupported scaling operation in driver with return value %s\n",
> @@ -1385,6 +1388,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> for_each_pipe(&data.display, pipe) {
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> for_each_valid_output_on_pipe(&data.display, pipe, output) {
> + igt_info("Trying on %s\n", igt_output_name(output));
> if (!pipe_output_combo_valid(&data.display, pipe, output))
> continue;
> if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1397,6 +1401,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> pipe, output);
> if (ret == 0)
> break;
> + igt_info("Required Scaling operation not supported on %s trying on next output\n",
> + igt_output_name(output));
> }
> igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> "Unsupported scaling operation in driver with return value %s\n",
> @@ -1412,6 +1418,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> for_each_pipe(&data.display, pipe) {
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> for_each_valid_output_on_pipe(&data.display, pipe, output) {
> + igt_info("Trying on %s\n", igt_output_name(output));
> if (!pipe_output_combo_valid(&data.display, pipe, output))
> continue;
> if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1424,6 +1431,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> pipe, output);
> if (ret == 0)
> break;
> + igt_info("Required Scaling operation not supported on %s trying on next output\n",
> + igt_output_name(output));
> }
> igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> "Unsupported scaling operation in driver with return value %s\n",
> @@ -1438,6 +1447,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> for_each_pipe(&data.display, pipe) {
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> for_each_valid_output_on_pipe(&data.display, pipe, output) {
> + igt_info("Trying on %s\n", igt_output_name(output));
> if (!pipe_output_combo_valid(&data.display, pipe, output))
> continue;
> if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1448,6 +1458,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> output);
> if (ret == 0)
> break;
> + igt_info("Required Scaling operation not supported on %s trying on next output\n",
> + igt_output_name(output));
> }
> igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> "Unsupported scaling operation in driver with return value %s\n",
> @@ -1462,6 +1474,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> for_each_pipe(&data.display, pipe) {
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> for_each_valid_output_on_pipe(&data.display, pipe, output) {
> + igt_info("Trying on %s\n", igt_output_name(output));
> if (!pipe_output_combo_valid(&data.display, pipe, output))
> continue;
> if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1472,6 +1485,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> output);
> if (ret == 0)
> break;
> + igt_info("Required Scaling operation not supported on %s trying on next output\n",
> + igt_output_name(output));
> }
> igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> "Unsupported scaling operation in driver with return value %s\n",
> @@ -1485,6 +1500,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> for_each_pipe(&data.display, pipe) {
> igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
> for_each_valid_output_on_pipe(&data.display, pipe, output) {
> + igt_info("Trying on %s\n", igt_output_name(output));
> if (!pipe_output_combo_valid(&data.display, pipe, output))
> continue;
> if (get_num_scalers(&data.display, pipe) < 1)
> @@ -1495,6 +1511,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
> output);
> if (ret == 0)
> break;
> + igt_info("Required Scaling operation not supported on %s trying on next output\n",
> + igt_output_name(output));
> }
> igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> "Unsupported scaling operation in driver with return value %s\n",
next prev parent reply other threads:[~2024-09-10 7:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 14:50 [PATCH i-g-t v1 0/5] tests/kms_plane_scaling: Update scaling functions to retry on valid outputs Naladala Ramanaidu
2024-09-05 14:50 ` [PATCH i-g-t v1 1/5] tests/kms_plane_scaling: Update scaling functions to return error codes Naladala Ramanaidu
2024-09-10 7:06 ` Sharma, Swati2
2024-09-05 14:50 ` [PATCH i-g-t v1 2/5] tests/kms_plane_scaling: Add informative logs for single plane scaling operations Naladala Ramanaidu
2024-09-10 7:42 ` Sharma, Swati2 [this message]
2024-09-05 14:50 ` [PATCH i-g-t v1 3/5] tests/kms_plane_scaling: Return error code in test_planes_scaling_combo Naladala Ramanaidu
2024-09-10 8:09 ` Sharma, Swati2
2024-09-05 14:50 ` [PATCH i-g-t v1 4/5] tests/kms_plane_scaling: Add debug logs for output scaling attempts Naladala Ramanaidu
2024-09-10 8:12 ` Sharma, Swati2
2024-09-05 14:50 ` [PATCH i-g-t v1 5/5] HAX patch do not merge Naladala Ramanaidu
2024-09-05 23:37 ` ✗ CI.xeBAT: failure for tests/kms_plane_scaling: Update scaling functions to retry on valid outputs (rev2) Patchwork
2024-09-08 3:33 ` ✗ CI.xeFULL: " Patchwork
2024-09-10 10:57 ` ✗ CI.xeBAT: " Patchwork
2024-09-10 12:02 ` ✗ CI.xeFULL: " Patchwork
2024-09-10 23:03 ` ✗ CI.xeBAT: failure for tests/kms_plane_scaling: Update scaling functions to retry on valid outputs (rev3) Patchwork
2024-09-11 1:04 ` ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Update scaling functions to retry on valid outputs (rev2) Patchwork
2024-09-11 1:18 ` ✗ CI.xeFULL: failure for tests/kms_plane_scaling: Update scaling functions to retry on valid outputs (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e3a3404-402c-4414-8043-609d0257f52e@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox