Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_bw: Fix the condition check for max pipe count
Date: Tue, 26 Mar 2024 14:10:20 +0530	[thread overview]
Message-ID: <6e6228d5-e307-49f5-a4f6-6d3049e47391@intel.com> (raw)
In-Reply-To: <20240321052454.377561-1-bhanuprakash.modem@intel.com>


On 3/21/2024 10:54 AM, Bhanuprakash Modem wrote:
> Fix the condition check to skip the subtest if ASIC doesn't
> have the requested number of pipes.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_bw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_bw.c b/tests/kms_bw.c
> index 96b19199d..05f7e79ad 100644
> --- a/tests/kms_bw.c
> +++ b/tests/kms_bw.c
> @@ -186,7 +186,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo
>   	 * not give the numver of valid crtcs and always return IGT_MAX_PIPES */
>   	for_each_pipe(display, p) num_pipes++;
>   
> -	igt_skip_on_f(pipe > num_pipes,
> +	igt_skip_on_f(pipe >= num_pipes,
>                         "ASIC does not have %d pipes\n", pipe);
>   
>   	test_init(data);

      parent reply	other threads:[~2024-03-26  8:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21  5:24 [PATCH i-g-t] tests/kms_bw: Fix the condition check for max pipe count Bhanuprakash Modem
2024-03-21  6:24 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-21  6:39 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-22  1:30 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-26  8:40 ` Karthik B S [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e6228d5-e307-49f5-a4f6-6d3049e47391@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox