Re: [igt-dev] [PATCH i-g-t v2 4/9] tests/kms_chamelium: explain why 8-channel tests aren't performed

Martin Peres
2019-05-27T12:25:42Z

On 24/05/2019 18:03, Simon Ser wrote:
> Also add a reference to the relevant Chromium bug.
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>

Reviewed-by: Martin Peres <martin.peres@linux.intel.com>

> ---
> tests/kms_chamelium.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index 9c8f51e8798b..56918a3b43fc 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -1221,7 +1221,9 @@ test_display_audio(data_t *data, struct chamelium_port *port,
> ret = alsa_open_output(alsa, audio_device);
> igt_assert(ret >= 0);
>
> - /* TODO: playback on all 8 available channels */
> + /* TODO: playback on all 8 available channels (this
> + * isn't supported by Chamelium devices yet, see
> + * https://crbug.com/950917) */
> format = test_formats[j];
> channels = PLAYBACK_CHANNELS;
> sampling_rate = test_sampling_rates[i];
>