Re: [PATCH] tests/intel/xe_pm_residency: Fix suspend duration calculation

["Anirban, Sk" <sk.anirban@intel.com>]

Hi,

On 23-03-2026 03:24 pm, Jani Nikula wrote:
> On Mon, 23 Mar 2026, "Anirban, Sk" <sk.anirban@intel.com> wrote:
>> Hi,
>>
>> On 23-03-2026 03:00 pm, Jani Nikula wrote:
>>> On Mon, 23 Mar 2026, Sk Anirban <sk.anirban@intel.com> wrote:
>>>> Fix the unit mismatch caused by interpreting seconds as milliseconds
>>>> during suspend duration calculations. Apply MSEC_PER_SEC multiplier
>>>> to ensure correct unit handling.
>>>>
>>> Fixes: ?
>> The change is a part of test gap which is filed internally.
> No, Fixes: should point at the commit which introduced the use of the
> wrong unit in the public repo.
>
> BR,
> Jani.

Got it. I’ll include that update in the next revision.

Thanks,

Anirban

>
>> Thanks,
>>
>> Anirban
>>
>>>> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
>>>> ---
>>>>    tests/intel/xe_pm_residency.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
>>>> index 61b63ed4f..46718a444 100644
>>>> --- a/tests/intel/xe_pm_residency.c
>>>> +++ b/tests/intel/xe_pm_residency.c
>>>> @@ -223,7 +223,7 @@ static void test_idle_residency(int fd, int gt, enum test_type flag)
>>>>    		 * elapsed time during suspend is approximately equal to autoresume delay
>>>>    		 * when a full suspend cycle(SUSPEND_TEST_NONE) is used.
>>>>    		 */
>>>> -		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE);
>>>> +		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE) * MSEC_PER_SEC;
>>>>    		residency_start = read_idle_residency(fd, gt);
>>>>    		igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE, SUSPEND_TEST_NONE);
>>>>    		residency_end = read_idle_residency(fd, gt);